[Bps-public-commit] r10375 - bpsbuilder/BPB/lib/BPB/Source

sunnavy at bestpractical.com sunnavy at bestpractical.com
Thu Jan 17 03:38:19 EST 2008


Author: sunnavy
Date: Thu Jan 17 03:38:17 2008
New Revision: 10375

Modified:
   bpsbuilder/BPB/lib/BPB/Source/Base.pm

Log:
make perlcritic.t happy

Modified: bpsbuilder/BPB/lib/BPB/Source/Base.pm
==============================================================================
--- bpsbuilder/BPB/lib/BPB/Source/Base.pm	(original)
+++ bpsbuilder/BPB/lib/BPB/Source/Base.pm	Thu Jan 17 03:38:17 2008
@@ -30,7 +30,7 @@
 sub run {
     my $self = shift;
     for ( $self->_cmd ) {
-        BPB::Util->run( $_ );
+        BPB::Util->run($_);
     }
     $self->_copy(@_) if @_;
 }
@@ -97,7 +97,8 @@
             my @sources = readdir $dir;
 
             # remove version number
-            @sources = map { s/-\d[.\w]+$//; $_ } @sources;
+            s/-\d[.\w]+$// for @sources;
+
             close $dir;
 
             my $name;
@@ -181,10 +182,14 @@
     my %file = @_;
     for ( keys %file ) {
         if ( $file{$_} ) {
-            my $cmd = [ 'cp', $file{$_},
-              File::Spec->catfile( $self->directory, $self->name || $self->path,
-                $_ ) ];
-            BPB::Util->run( $cmd );
+            my $cmd = [
+                'cp',
+                $file{$_},
+                File::Spec->catfile(
+                    $self->directory, $self->name || $self->path, $_
+                )
+            ];
+            BPB::Util->run($cmd);
         }
     }
 }



More information about the Bps-public-commit mailing list