[Bps-public-commit] r10472 - bpsbuilder/Shipwright/lib/Shipwright

sunnavy at bestpractical.com sunnavy at bestpractical.com
Thu Jan 24 12:35:05 EST 2008


Author: sunnavy
Date: Thu Jan 24 12:35:05 2008
New Revision: 10472

Modified:
   bpsbuilder/Shipwright/lib/Shipwright/Build.pm

Log:
set default install_base in new, instead of run

Modified: bpsbuilder/Shipwright/lib/Shipwright/Build.pm
==============================================================================
--- bpsbuilder/Shipwright/lib/Shipwright/Build.pm	(original)
+++ bpsbuilder/Shipwright/lib/Shipwright/Build.pm	Thu Jan 24 12:35:05 2008
@@ -25,9 +25,14 @@
 sub new {
     my $class = shift;
     my $self  = {@_};
+    bless $self, $class;
+
     $self->{build_base} =
       File::Spec->catfile( tempdir( CLEANUP => 0 ), 'build' );
-    bless $self, $class;
+
+    unless ( $self->install_base ) {
+        $self->install_base( tempdir( CLEANUP => 0 ) );
+    }
 
     no warnings 'uninitialized';
 
@@ -72,11 +77,6 @@
         $self->$_( $args{$_} ) if $args{$_};
     }
 
-    unless ( $self->install_base ) {
-        $self->install_base( tempdir( CLEANUP => 0 ) );
-        $self->log->info( "we'll install at " . $self->install_base );
-    }
-
     $self->log->info( 'run build to install to ' . $self->install_base );
 
     mkdir $self->install_base unless -e $self->install_base;



More information about the Bps-public-commit mailing list