[Bps-public-commit] r16681 - in RT-Authen-ExternalAuth/trunk/lib/RT: Authen/ExternalAuth

[zordrak at bestpractical.com]

Author: zordrak
Date: Wed Nov  5 10:16:32 2008
New Revision: 16681

Modified:
   RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/DBI.pm
   RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/LDAP.pm
   RT-Authen-ExternalAuth/trunk/lib/RT/User_Vendor.pm

Log:
Basic Syntax fixes

Modified: RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/DBI.pm
==============================================================================
--- RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/DBI.pm	(original)
+++ RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/DBI.pm	Wed Nov  5 10:16:32 2008
@@ -232,8 +232,8 @@
     my ($username,$service) = @_;
     
     # FIRST, check that the user exists in the DBI service
-    unless UserExists($username,$service) {
-        $RT::Logger->debug("User (",$username,") doesn't exist! - Assuming not disabled for the purposes of disable checking";
+    unless(UserExists($username,$service)) {
+        $RT::Logger->debug("User (",$username,") doesn't exist! - Assuming not disabled for the purposes of disable checking");
         return 0;
     }
     
@@ -338,4 +338,4 @@
 
 # }}}
 
-1;
\ No newline at end of file
+1;

Modified: RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/LDAP.pm
==============================================================================
--- RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/LDAP.pm	(original)
+++ RT-Authen-ExternalAuth/trunk/lib/RT/Authen/ExternalAuth/LDAP.pm	Wed Nov  5 10:16:32 2008
@@ -54,7 +54,7 @@
                             ldap_error_name($ldap_msg->code), 
                             $ldap_msg->code);
         # Didn't even get a partial result - jump straight to the next external auth service
-        retun 0;
+        return 0;
     }
 
     unless ($ldap_msg->count == 1) {
@@ -336,8 +336,8 @@
     my ($username,$service) = @_;
 
     # FIRST, check that the user exists in the LDAP service
-    unless UserExists($username,$service) {
-        $RT::Logger->debug("User (",$username,") doesn't exist! - Assuming not disabled for the purposes of disable checking";
+    unless(UserExists($username,$service)) {
+        $RT::Logger->debug("User (",$username,") doesn't exist! - Assuming not disabled for the purposes of disable checking");
         return 0;
     }
     
@@ -471,4 +471,4 @@
 
 # }}}
 
-1;
\ No newline at end of file
+1;

Modified: RT-Authen-ExternalAuth/trunk/lib/RT/User_Vendor.pm
==============================================================================
--- RT-Authen-ExternalAuth/trunk/lib/RT/User_Vendor.pm	(original)
+++ RT-Authen-ExternalAuth/trunk/lib/RT/User_Vendor.pm	Wed Nov  5 10:16:32 2008
@@ -178,7 +178,7 @@
         foreach my $rt_attr (@{$config->{'attr_match_list'}}) {
             # Jump to the next attr in $args if this one isn't in the attr_match_list
             $RT::Logger->debug( "Attempting to use this canonicalization key:",$rt_attr);
-            unless defined($args->{$rt_attr}) {
+            unless(defined($args->{$rt_attr})) {
                 $RT::Logger->debug("This attribute (",
                                     $rt_attr,
                                     ") is not defined in the attr_match_list for this service (",
@@ -279,7 +279,7 @@
         my $config = $RT::ExternalSettings->{$service};
         
         # If the config doesn't exist, don't bother doing anything, skip to next in list.
-        unless defined($config) {
+        unless(defined($config)) {
             $RT::Logger->debug("You haven't defined a configuration for the service named \"",
                                 $service,
                                 "\" so I'm not going to try to get user information from it. Skipping...");
@@ -289,7 +289,7 @@
         # If it's a DBI config:
         if ($config->{'type'} eq 'db') {
             
-            unless RT::Authen::ExternalAuth::DBI->UserExists($username,$service) {
+            unless(RT::Authen::ExternalAuth::DBI->UserExists($username,$service)) {
                 $RT::Logger->debug("User (",
                                     $username,
                                     ") doesn't exist in service (",
@@ -301,7 +301,7 @@
             
         } elsif ($config->{'type'} eq 'ldap') {
             
-            unless RT::Authen::ExternalAuth::LDAP->UserExists($username,$service) {
+            unless(RT::Authen::ExternalAuth::LDAP->UserExists($username,$service)) {
                 $RT::Logger->debug("User (",
                                     $username,
                                     ") doesn't exist in service (",