[Bps-public-commit] r16605 - sd/trunk/lib/App/SD/Replica/rt

[ruz at bestpractical.com]

Author: ruz
Date: Wed Oct 29 16:08:40 2008
New Revision: 16605

Modified:
   sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm

Log:
* drop an incorrect warning. we have the current state of the ticket
  and some transaction in the middle of its history. It does not
  necessarily describe the latest change of a prop.

Modified: sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm
==============================================================================
--- sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm	(original)
+++ sd/trunk/lib/App/SD/Replica/rt/PullEncoder.pm	Wed Oct 29 16:08:40 2008
@@ -251,17 +251,12 @@
     }
 
     $args{'changeset'}->add_change( { change => $change } );
-    if ( $args{'ticket'}->{ $field } eq $new ) {
-        $args{'ticket'}->{ $field } = $old;
-    } else {
-        $args{'ticket'}->{ $field } = $old;
-        warn "Update consistency problem: " . $args{'ticket'}->{ $field } ." != ". $new;
-    }
-    $change->add_prop_change(
-        name => $field,
-        old  => $old,
-        new  => $new,
-    );
+    
+    # XXX: This line is kind of magic
+    # TODO: check if it's sill needed
+    $args{'ticket'}->{ $field } = $old;
+
+    $change->add_prop_change( name => $field, old => $old, new => $new );
 
 }