[Bps-public-commit] r16631 - in RT-Authen-ExternalAuth/branches/errorchecking: lib/RT

[falcone at bestpractical.com]

Author: falcone
Date: Thu Oct 30 17:22:01 2008
New Revision: 16631

Modified:
   RT-Authen-ExternalAuth/branches/errorchecking/   (props changed)
   RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/User_Vendor.pm

Log:
 r41191 at ketch:  falcone | 2008-10-30 17:21:56 -0400
 * shoving undef into the list is not what is wanted
   If the user doesn't define the config variable, we should
   have an empty list that skips the loop.


Modified: RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/User_Vendor.pm
==============================================================================
--- RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/User_Vendor.pm	(original)
+++ RT-Authen-ExternalAuth/branches/errorchecking/lib/RT/User_Vendor.pm	Thu Oct 30 17:22:01 2008
@@ -406,7 +406,7 @@
                             sort(keys(%$args))));
 
     # Get the list of defined external services
-    my @info_services = $RT::ExternalInfoPriority ? @{$RT::ExternalInfoPriority} : undef;
+    my @info_services = @{$RT::ExternalInfoPriority||[]};
     # For each external service...
     foreach my $service (@info_services) {
         
@@ -730,7 +730,7 @@
     my $user_disabled 	    = 0;
     
     # Get the list of information service names requested by user.    
-    my @info_services = $RT::ExternalInfoPriority ? @{$RT::ExternalInfoPriority} : undef;
+    my @info_services = @{$RT::ExternalInfoPriority||[]};
 
     # For each named service in the list
     # Check to see if the user is found in the external service