[Bps-public-commit] App-Changeloggr branch, master, updated. 329486280617af428ad029356e8a51191c4265df

sartak at bestpractical.com sartak at bestpractical.com
Wed Apr 29 15:22:39 EDT 2009


The branch, master has been updated
       via  329486280617af428ad029356e8a51191c4265df (commit)
       via  7a981e5126d63c3b3c73e3bf9cfbd9b01bb8ab97 (commit)
      from  488a7d71d02d7ed193c315ac1fa26f23b31fae19 (commit)

Summary of changes:
 lib/App/Changeloggr/Model/Changelog.pm |    3 ++-
 lib/App/Changeloggr/View/Admin.pm      |   15 +++++++++++++++
 2 files changed, 17 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 7a981e5126d63c3b3c73e3bf9cfbd9b01bb8ab97
Author: Shawn M Moore <sartak at gmail.com>
Date:   Wed Apr 29 15:15:13 2009 -0400

    More hinting for external_source

diff --git a/lib/App/Changeloggr/Model/Changelog.pm b/lib/App/Changeloggr/Model/Changelog.pm
index 0674d1f..b8eb86c 100644
--- a/lib/App/Changeloggr/Model/Changelog.pm
+++ b/lib/App/Changeloggr/Model/Changelog.pm
@@ -24,7 +24,8 @@ use App::Changeloggr::Record schema {
     column external_source =>
         type is 'text',
         render as 'text',
-        label is 'External URL per commit',
+        label is 'Commit view',
+        hints are 'The URL to view full commit info. __ID__ will be replaced with the commit ID.',
         since '0.0.3';
 };
 

commit 329486280617af428ad029356e8a51191c4265df
Author: Shawn M Moore <sartak at gmail.com>
Date:   Wed Apr 29 15:21:28 2009 -0400

    Display a message for unvoted-on-changes
    If there are no unvoted changes, display all

diff --git a/lib/App/Changeloggr/View/Admin.pm b/lib/App/Changeloggr/View/Admin.pm
index 5b97307..2a64a83 100644
--- a/lib/App/Changeloggr/View/Admin.pm
+++ b/lib/App/Changeloggr/View/Admin.pm
@@ -49,8 +49,18 @@ template '/changelog/votes' => page {
     my $changelog = Changelog(id => get('id'));
     my $changes = $changelog->changes;
 
+    my $count_all = $changes->count;
     $changes->limit_to_voted;
+    my $count_voted = $changes->count;
 
+    # if there are no votes, just show every change by pretending they've
+    # all been voted on. this is kind of abusive.
+    if ($count_voted == 0) {
+        $changes = $changelog->changes;
+        $count_all = $count_voted = $changes->count;
+    }
+
+    h3 { "Changes" }
     ul {
         for my $change (@$changes) {
             li {
@@ -71,6 +81,11 @@ template '/changelog/votes' => page {
                 }
             }
         }
+    };
+
+    my $count_unvoted = $count_all - $count_voted;
+    if ($count_unvoted) {
+        p { _("Not showing %quant(%1,change) that have not been voted on.", $count_unvoted) }
     }
 };
 

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list