[Bps-public-commit] App-Changeloggr branch, master, updated. 2e6ba35765a99cba0b93071b1b6118a99b9ca961

sartak at bestpractical.com sartak at bestpractical.com
Wed May 20 16:03:21 EDT 2009


The branch, master has been updated
       via  2e6ba35765a99cba0b93071b1b6118a99b9ca961 (commit)
      from  5cc1ce5c0bef713084f2658f203ecbd1270b69fc (commit)

Summary of changes:
 lib/App/Changeloggr/View.pm |   37 ++++++++-----------------------------
 1 files changed, 8 insertions(+), 29 deletions(-)

- Log -----------------------------------------------------------------
commit 2e6ba35765a99cba0b93071b1b6118a99b9ca961
Author: Shawn M Moore <sartak at gmail.com>
Date:   Wed May 20 16:03:05 2009 -0400

    Always show diffstat, above the full diff iframe

diff --git a/lib/App/Changeloggr/View.pm b/lib/App/Changeloggr/View.pm
index 8881f19..9280875 100644
--- a/lib/App/Changeloggr/View.pm
+++ b/lib/App/Changeloggr/View.pm
@@ -118,6 +118,14 @@ sub show_change {
             li { "Date: " . $change->date };
         };
 
+        render_region(
+            name      => "change_$id",
+            path      => '/change/more',
+            arguments => {
+                change => $id,
+            },
+        );
+
         my $id = $change->id;
         if (my $url = $change->external_source) {
             hyperlink(
@@ -138,35 +146,6 @@ sub show_change {
                 render_region("change_${id}_source");
             };
         }
-        if (Jifty->web->current_user->user_object->show_details) {
-            div {
-                render_region(
-                    name      => "change_$id",
-                    path      => '/change/more',
-                    arguments => {
-                        change => $id,
-                    },
-                );
-            };
-        }
-        else {
-            hyperlink(
-                label => 'more...',
-                onclick => [{
-                    region       => Jifty->web->qualified_region("change_$id"),
-                    replace_with => '/change/more',
-                    toggle       => 1,
-                    effect       => 'slideDown',
-                    arguments    => {
-                        change => $id,
-                    },
-                },
-                "this.innerHTML = this.innerHTML == 'more...' ? 'less...' : 'more...';",
-            ]);
-            div {
-                render_region("change_$id");
-            };
-        }
 
         if ($args{voting_form}) {
             hr {};

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list