[Bps-public-commit] rt-extension-jsgantt branch, master, updated. 0a1b07097b4caaee0bd32346a7eb00935f131064

? sunnavy sunnavy at bestpractical.com
Tue Jun 29 15:34:07 EDT 2010


The branch, master has been updated
       via  0a1b07097b4caaee0bd32346a7eb00935f131064 (commit)
       via  03577ab41e0c04684009238671082ba8b5c4d78f (commit)
       via  95350f681dd9e1fd183b6dec690e3af7608e792c (commit)
      from  9bcdee881275810f6603e4f924036873758a3b07 (commit)

Summary of changes:
 .../JSGantt/Search/Elements/ResultViews/AfterTools |    3 ++-
 html/Search/JSGantt.html                           |    7 ++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit 95350f681dd9e1fd183b6dec690e3af7608e792c
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Jun 30 03:32:29 2010 +0800

    fix subject escape bug

diff --git a/html/Search/JSGantt.html b/html/Search/JSGantt.html
index c581bed..bfd93e5 100644
--- a/html/Search/JSGantt.html
+++ b/html/Search/JSGantt.html
@@ -41,7 +41,8 @@
 %   my ( $min_start, $min_start_obj );
 %   while ( my $Ticket = $Tickets->Next ) {
 %   my $subject = $Ticket->Subject;
-%   $subject =~ s/'/\\'/;
+%   $subject =~ s/'/\\'/g;
+%   $subject =~ s/\\/\\\\/g;
 %   my ( $start, $end ) = ('', '');
 %   my ( $start_obj, $end_obj );
 %   if ( $Ticket->StartsObj->Unix ) {
@@ -146,7 +147,7 @@
 
 %   for my $item ( @info ) {
         g.AddTaskItem(new JSGantt.TaskItem( <% join ',', map { 
-           s/'/\\'/g; $_ =~ /^\d+$/ ? $_ : q{'} . $_ . q{'} } @$item |n%> ));
+           $_ =~ /^\d+$/ ? $_ : q{'} . $_ . q{'} } @$item |n%> ));
 %   }
 
     g.Draw();    

commit 03577ab41e0c04684009238671082ba8b5c4d78f
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Jun 30 03:32:51 2010 +0800

    make name field a bit shorter

diff --git a/html/Search/JSGantt.html b/html/Search/JSGantt.html
index bfd93e5..bee6d82 100644
--- a/html/Search/JSGantt.html
+++ b/html/Search/JSGantt.html
@@ -128,7 +128,7 @@
 %       }
 %   }
 
-%   push @info, [ $Ticket->id, ( $Ticket->id . ': ' . substr $subject, 0, 40 ),
+%   push @info, [ $Ticket->id, ( $Ticket->id . ': ' . substr $subject, 0, 30 ),
 %       $start, $end, $colors[$i++%@colors],
 %       ( RT->Config->Get('WebPath') . '/Ticket/Display.html?id=' .  $Ticket->id ),
 %       0, ( $Ticket->OwnerObj->Name || $Ticket->OwnerObj->EmailAddress ),

commit 0a1b07097b4caaee0bd32346a7eb00935f131064
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Jun 30 03:34:10 2010 +0800

    name tweak

diff --git a/html/Callbacks/JSGantt/Search/Elements/ResultViews/AfterTools b/html/Callbacks/JSGantt/Search/Elements/ResultViews/AfterTools
index 1988406..a0b8d6f 100644
--- a/html/Callbacks/JSGantt/Search/Elements/ResultViews/AfterTools
+++ b/html/Callbacks/JSGantt/Search/Elements/ResultViews/AfterTools
@@ -45,4 +45,5 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<li><a href="<%RT->Config->Get('WebPath')%>/Search/JSGantt.html<%$ARGS{QueryString}%>"><&|/l&>JSGantt</&></a></li>
+<li><a
+href="<%RT->Config->Get('WebPath')%>/Search/JSGantt.html<%$ARGS{QueryString}%>"><&|/l&>Gantt Chart</&></a></li>

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list