[Bps-public-commit] RTx-TakeScreenshots branch, master, updated. 5f86708b1f39d92cb474f50e0b13e16adf7f476e

Thomas Sibley trs at bestpractical.com
Mon Mar 21 11:25:51 EDT 2011


The branch, master has been updated
       via  5f86708b1f39d92cb474f50e0b13e16adf7f476e (commit)
       via  ea185e83ed1c9624cb325761ad98b750a3562e71 (commit)
       via  61e3bee6552a3bc1c52b4ea5b48427cfed9720d9 (commit)
       via  d6a9b8710db966547517a49034d6e3f812ee2255 (commit)
      from  fd9c44aaa7de0b0f8e86a4a24fdf64624739880b (commit)

Summary of changes:
 bin/crop-screenshot  |    6 ++++++
 bin/take-screenshots |    5 +++--
 etc/initialdata      |   16 ++++++++++++----
 3 files changed, 21 insertions(+), 6 deletions(-)

- Log -----------------------------------------------------------------
commit d6a9b8710db966547517a49034d6e3f812ee2255
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Mar 21 11:05:34 2011 -0400

    Crop height to 610 for mobile screenshots

diff --git a/bin/crop-screenshot b/bin/crop-screenshot
index 7960494..8943e2b 100755
--- a/bin/crop-screenshot
+++ b/bin/crop-screenshot
@@ -7,6 +7,12 @@ out="${2:-${1%.*}-cropped.${1#*.}}"
 # than 740px won't be cropped.
 geometry="1024x740>+0+0"
 
+# Crop mobile screenshots to a shorter height
+if [[ "$in" =~ mobile ]]; then
+    echo "Using 610 for mobile screenshots"
+    geometry="1024x610>+0+0"
+fi
+
 convert "$in" -crop "$geometry" +repage "$out"
 
 echo "Cropped $in"

commit 61e3bee6552a3bc1c52b4ea5b48427cfed9720d9
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Mar 21 11:09:31 2011 -0400

    Swap the large red and bold text to better emphasize the problem

diff --git a/bin/take-screenshots b/bin/take-screenshots
index 6fe24cf..0beadec 100755
--- a/bin/take-screenshots
+++ b/bin/take-screenshots
@@ -59,8 +59,8 @@ for my $subscribe (grep { $_->[1] =~ /Dashboards\/Subscription/ } @pages) {
     $firefox->wait_for_element_present('id=cke_Content', 10000);
     $firefox->run_script(<<"    .");
         CKEDITOR.instances.Content.setData(
-            "<p style='color: red; font-size: xx-large;'>The worst has happened.</p>"
-          + "<p><b>There is no coffee to be found anywhere in the office.</b></p>"
+            "<p><b>The worst has happened.</b></p>"
+          + "<p style='color: red; font-size: xx-large;'>There is no coffee to be found anywhere in the office.</p>"
           + "<p>Productivity is at an <u>all-time low</u>!</p>"
         );
     .
diff --git a/etc/initialdata b/etc/initialdata
index 9671e0b..6917ae5 100644
--- a/etc/initialdata
+++ b/etc/initialdata
@@ -59,8 +59,8 @@ our @Tickets = (
         DependsOn   => 2,
         ContentType => 'text/html',
         Content     => <<'.',
-<p style="color: red; font-size: xx-large;">The worst has happened.</p>
-<p><b>There's no coffee to be found anywhere in the office.</b></p>
+<p><b>The worst has happened.</b></p>
+<p style="color: red; font-size: xx-large;">There's no coffee to be found anywhere in the office.</p>
 <p>Productivity is at an <u>all-time low</u>!</p>
 .
     },
@@ -167,8 +167,8 @@ RFP sent out to the vendors.
                 Type => 'text/html',
                 Data => [<<'.'
 <blockquote>
-<p style="color: red; font-size: xx-large;">The worst has happened.</p>
-<p><b>There's no coffee to be found anywhere in the office.</b></p>
+<p><b>The worst has happened.</b></p>
+<p style="color: red; font-size: xx-large;">There's no coffee to be found anywhere in the office.</p>
 </blockquote>
 
 <p>I'll look into this ASAP.  Thanks for the heads up.</p><script>alert("hi");</script>

commit ea185e83ed1c9624cb325761ad98b750a3562e71
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Mar 21 11:19:02 2011 -0400

    Take a screenshot of our ticket charts

diff --git a/bin/take-screenshots b/bin/take-screenshots
index 0beadec..3e3be37 100755
--- a/bin/take-screenshots
+++ b/bin/take-screenshots
@@ -103,6 +103,7 @@ ticket_history|/Ticket/History.html?id=1
 search_results|/Search/Results.html?Query=id+<+4;Order=DESC
 search_bulk_update|/Search/Bulk.html?Query=id+<+4;Order=DESC
 ticket_relationships|/Ticket/Graphs/index.html?id=1&Direction=LR&LeadingLink=DependsOn&MaxDepth=0&ShowLinks=MemberOf&ShowLinks=RefersTo&FillUsing=&Level-1-Properties=Subject&Level-1-Properties=Status&Level-2-Properties=Subject&Level-2-Properties=Status&Level-3-Properties=Subject&Level-3-Properties=Status&Update=Update+Graph&SavedSearchId=new&SavedSearchOwner=RT::User-12&SavedSearchDescription=&SavedSearchLoad=
+ticket_charts|/Search/Chart.html?Query=Created+%3C+%27tomorrow%27&SavedChartSearchId=new&ChartStyle=bar&PrimaryGroupBy=Owner.Name
 dashboard|/Dashboards/10/SLA+Performance
 dashboard_subscription|/Dashboards/Subscription.html?id=10
 theme_editor|/Admin/Tools/Theme.html

commit 5f86708b1f39d92cb474f50e0b13e16adf7f476e
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Mar 21 11:25:48 2011 -0400

    Always use a testfile MailCommand

diff --git a/etc/initialdata b/etc/initialdata
index 6917ae5..4403c9c 100644
--- a/etc/initialdata
+++ b/etc/initialdata
@@ -1,6 +1,14 @@
 # This is meant to be an easy way to load up our standard demo data for taking
 # screenshots.  It builds on top of the stock initialdata.
 
+ at Initial = (
+    sub {
+        # We want to make it look like mail always works, and not actually send
+        # any mail
+        RT->Config->Set(MailCommand => 'testfile');
+    }
+);
+
 @Queues = (
     {
         Name              => 'Office',

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list