[Bps-public-commit] RT-Extension-LDAPImport branch, master, updated. 0.32_01-1-gb31467e

Thomas Sibley trs at bestpractical.com
Wed Feb 22 14:15:12 EST 2012


The branch, master has been updated
       via  b31467ecb1102d38e09731300507de50182f2397 (commit)
      from  dee4ef725c217504f6f64cb413bf7f4ad7aa1fa0 (commit)

Summary of changes:
 lib/RT/Extension/LDAPImport.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit b31467ecb1102d38e09731300507de50182f2397
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Feb 22 14:15:05 2012 -0500

    Avoid uninitialized warnings

diff --git a/lib/RT/Extension/LDAPImport.pm b/lib/RT/Extension/LDAPImport.pm
index d6e9b60..9922777 100644
--- a/lib/RT/Extension/LDAPImport.pm
+++ b/lib/RT/Extension/LDAPImport.pm
@@ -253,7 +253,7 @@ sub _show_user_info {
         my $old_value;
         if ($rt_user) {
             eval { $old_value = $rt_user->$key() };
-            if ($user->{$key} && $old_value eq $user->{$key}) {
+            if ($user->{$key} && defined $old_value && $old_value eq $user->{$key}) {
                 $old_value = 'unchanged';
             }
         }
@@ -862,7 +862,7 @@ sub _show_group_info {
         my $old_value;
         if ($rt_group) {
             eval { $old_value = $rt_group->$key() };
-            if ($group->{$key} && $old_value eq $group->{$key}) {
+            if ($group->{$key} && defined $old_value && $old_value eq $group->{$key}) {
                 $old_value = 'unchanged';
             }
         }

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list