[Bps-public-commit] rt-authen-externalauth branch, master, updated. 0.12-2-g1dcb308

[Thomas Sibley]

The branch, master has been updated
       via  1dcb308728945b1174765ce459266d1d3229ef7f (commit)
       via  f85b348dab935c4ea582f56a87e0908ecfb62ff9 (commit)
      from  857dcc53caf42c6da9d314357cc48e77c45fc0d0 (commit)

Summary of changes:
 inc/Module/Install/RTx.pm           |  2 +-
 inc/Module/Install/ReadmeFromPod.pm |  2 +-
 lib/RT/Authen/ExternalAuth.pm       | 23 ++++++-----------------
 3 files changed, 8 insertions(+), 19 deletions(-)

- Log -----------------------------------------------------------------
commit f85b348dab935c4ea582f56a87e0908ecfb62ff9
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Jan 31 09:34:32 2013 -0800

    Cut down on code by using the core RT::Record->Update method

diff --git a/lib/RT/Authen/ExternalAuth.pm b/lib/RT/Authen/ExternalAuth.pm
index 6dba7e2..941b158 100644
--- a/lib/RT/Authen/ExternalAuth.pm
+++ b/lib/RT/Authen/ExternalAuth.pm
@@ -413,23 +413,12 @@ sub UpdateUserInfo {
 
     # For each piece of information returned by CanonicalizeUserInfo,
     # run the Set method for that piece of info to change it for the user
-    foreach my $key (sort(keys(%args))) {
-        next unless $args{$key};
-        my $method = "Set$key";
-        # We do this on the UserObj from above, not self so that there 
-        # are no permission restrictions on setting information
-        my ($method_success,$method_msg) = $UserObj->$method($args{$key});
-        
-        # If your user information is not getting updated, 
-        # uncomment the following logging statements
-        if ($method_success) {
-            # At DEBUG level, log that method succeeded
-            # $RT::Logger->debug((caller(0))[3],"$method Succeeded. $method_msg");
-        } else {
-            # At DEBUG level, log that method failed
-            # $RT::Logger->debug((caller(0))[3],"$method Failed. $method_msg");
-        }
-    }
+    my @results = $UserObj->Update(
+        ARGSRef         => \%args,
+        AttributesRef   => [keys %args],
+    );
+    $RT::Logger->debug("UPDATED user $username: $_")
+        for @results;
 
     # Confirm update success
     $updated = 1;

commit 1dcb308728945b1174765ce459266d1d3229ef7f
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Jan 31 11:16:27 2013 -0800

    Update build toolchain

diff --git a/inc/Module/Install/RTx.pm b/inc/Module/Install/RTx.pm
index 2eba7ad..ce01018 100644
--- a/inc/Module/Install/RTx.pm
+++ b/inc/Module/Install/RTx.pm
@@ -8,7 +8,7 @@ no warnings 'once';
 
 use Module::Install::Base;
 use base 'Module::Install::Base';
-our $VERSION = '0.29_02';
+our $VERSION = '0.30';
 
 use FindBin;
 use File::Glob     ();
diff --git a/inc/Module/Install/ReadmeFromPod.pm b/inc/Module/Install/ReadmeFromPod.pm
index fb7075f..6a80818 100644
--- a/inc/Module/Install/ReadmeFromPod.pm
+++ b/inc/Module/Install/ReadmeFromPod.pm
@@ -7,7 +7,7 @@ use warnings;
 use base qw(Module::Install::Base);
 use vars qw($VERSION);
 
-$VERSION = '0.18';
+$VERSION = '0.20';
 
 sub readme_from {
   my $self = shift;

-----------------------------------------------------------------------