[Bps-public-commit] RT-Extension-ExtractCustomFieldValues branch, master, updated. 3.09-2-gf540588

? sunnavy sunnavy at bestpractical.com
Thu Oct 3 08:43:45 EDT 2013


The branch, master has been updated
       via  f54058893e228deaa879319e737cf7bf6deb2e83 (commit)
       via  8a8a58886d8fe20243d355ae62baffea86fefe15 (commit)
      from  167f70d25e290dbc520d1c1856e6452a92f579ec (commit)

Summary of changes:
 etc/initialdata                           | 4 ++--
 lib/RT/Action/ExtractCustomFieldValues.pm | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 8a8a58886d8fe20243d355ae62baffea86fefe15
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Oct 3 20:07:58 2013 +0800

    to make template compiler check happy
    
    the "#" before "{" doesn't actually comment as it's not in the perl block yet.
    thus we need to close the block by removing "#" before last "}".
    I removed "#" before "{" too to make it more consistent.

diff --git a/etc/initialdata b/etc/initialdata
index bee0309..ea5db1e 100644
--- a/etc/initialdata
+++ b/etc/initialdata
@@ -73,7 +73,7 @@
 # 8. If you need to dynamically build your matching, and want to trigger on headers and body
 #    and invode some arbitrary code like example 5
 # Separator=~~
-# {
+ {
 #    my $action = 'use My::Site; My::Site::SetSiteID( Ticket => $self->TicketObj, Site => $_ );';
 #
 #    for my $regex (My::Site::ValidRegexps) {
@@ -86,7 +86,7 @@
 #            $OUT .= "\n";
 #        }
 #    }
-# }
+ }
 
 EOTEXT
     }

commit f54058893e228deaa879319e737cf7bf6deb2e83
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Oct 3 20:36:05 2013 +0800

    strip out heading spaces when parsing template lines
    
    to make it more tolerant in case user mis-types.

diff --git a/lib/RT/Action/ExtractCustomFieldValues.pm b/lib/RT/Action/ExtractCustomFieldValues.pm
index dad0189..db6731a 100644
--- a/lib/RT/Action/ExtractCustomFieldValues.pm
+++ b/lib/RT/Action/ExtractCustomFieldValues.pm
@@ -47,6 +47,8 @@ sub TemplateConfig {
         chomp;
         next if /^#/;
         next if /^\s*$/;
+        s!^\s+!!;
+        s!\s+$!!;
         if (/^Separator=(.+)$/) {
             $Separator = $1;
             next;

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list