[Bps-public-commit] rt-extension-quickreply branch, master, updated. 77818711caeceadaa55d4df3259e6742da10fe3f

[? sunnavy]

The branch, master has been updated
       via  77818711caeceadaa55d4df3259e6742da10fe3f (commit)
       via  82454e26ab40afdb412577c4a896c5673710d044 (commit)
      from  11cad97e36092034ca8eeb3d01d1394d9da86fe0 (commit)

Summary of changes:
 README                          | 16 +++++++++++++++-
 html/Ticket/Elements/QuickReply |  4 ++--
 2 files changed, 17 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 82454e26ab40afdb412577c4a896c5673710d044
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Oct 21 22:52:09 2013 +0800

    up to date README

diff --git a/README b/README
index 3fb93bd..76dd676 100644
--- a/README
+++ b/README
@@ -17,6 +17,20 @@ INSTALLATION
 
         or add "RT::Extension::QuickReply" to your existing @Plugins line.
 
+        By default, Quick reply is not enabled in search results page, you
+        can turn it on by:
+
+            Set($QuickReplyInSearchResults, 1);
+
+        By default, Quick reply shows up in Ticket Display page after
+        History section, you can customize the position by:
+
+            Set($QuickReplyPositionInDisplay, 'BeforeShowHistory');
+
+        or
+
+            Set($QuickReplyPositionInDisplay, 'BeforeShowSummary');
+
     Clear your mason cache
             rm -rf /opt/rt4/var/mason_data/obj
 
@@ -34,7 +48,7 @@ BUGS
     y>.
 
 LICENSE AND COPYRIGHT
-    Shipwright is Copyright 2013 Best Practical Solutions, LLC.
+    This software is Copyright 2013 Best Practical Solutions, LLC.
 
     This is free software, licensed under:
 

commit 77818711caeceadaa55d4df3259e6742da10fe3f
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Oct 21 22:52:51 2013 +0800

    default update type to "comment"

diff --git a/html/Ticket/Elements/QuickReply b/html/Ticket/Elements/QuickReply
index cf10b1e..06d6858 100755
--- a/html/Ticket/Elements/QuickReply
+++ b/html/Ticket/Elements/QuickReply
@@ -70,7 +70,7 @@
                         <option value="private" <% $ARGS{'UpdateType'} eq "private" ? qq[ selected="selected"] : '' |n %>><&|/l&>Comments (Not sent to requestors)</&></option>
 % }
 % if ($CanRespond) {
-                        <option value="response" <% $ARGS{'UpdateType'} ? qq[ selected="selected"] : '' |n %>><&|/l&>Reply to requestors</&></option>
+                        <option value="response" <% $ARGS{'UpdateType'} ne 'private' ? qq[ selected="selected"] : '' |n %>><&|/l&>Reply to requestors</&></option>
 % }
                     </select>
                 </td>
@@ -124,8 +124,8 @@ $CanComment = 1 if ( $Ticket->CurrentUserHasRight('CommentOnTicket') or
 
 $ShowStatus = 0 unless $Ticket->CurrentUserHasRight('ModifyTicket');
 
-$ARGS{'UpdateType'} ||= 'response' if $CanRespond;
 $ARGS{'UpdateType'} ||= 'private' if $CanComment;
+$ARGS{'UpdateType'} ||= 'response' if $CanRespond;
 my $type = $ARGS{'UpdateType'};
 
 return unless $CanRespond || $CanComment;

-----------------------------------------------------------------------