[Bps-public-commit] rt-extension-assets branch, master, updated. 1.0rc1-6-g0591c12

Alex Vandiver alexmv at bestpractical.com
Tue Feb 18 19:42:23 EST 2014


The branch, master has been updated
       via  0591c12ed15a682ba8225ef82668aa7f137083c0 (commit)
       via  af45230cde3d153aea03ef4891a797229fb93acb (commit)
       via  2aa247125592a008bc5f198e9c8751929e70432e (commit)
       via  aa07c87a8aa52f762bbeb4cf20a8dc1bfa9696a7 (commit)
       via  4a531b4d7e10a5b17edb13f0b3405b42ccea7ecc (commit)
      from  f21a7f66b69bb8f80cbd717c66ad04d2c9d53d7a (commit)

Summary of changes:
 static/css/RTx-Assets.css | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 4a531b4d7e10a5b17edb13f0b3405b42ccea7ecc
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Feb 18 19:35:38 2014 -0500

    Limit 50%-width rules to asset CFs, not _all_ CFs

diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
index f1c2c94..f04d363 100644
--- a/static/css/RTx-Assets.css
+++ b/static/css/RTx-Assets.css
@@ -136,13 +136,13 @@
 
 /* On a reasonable-width screen, make better use of whitespace */
 @media (min-width: 601px) {
-    .edit-custom-fields tr,
+    .asset-info-cfs .edit-custom-fields tr,
     #ModifyAsset .asset-basics tr {
         display: inline-block;
         width: 49%;
     }
 
-    .edit-custom-fields tr td.cflabel,
+    .asset-info-cfs .edit-custom-fields tr td.cflabel,
     #ModifyAsset .asset-basics tr td.label,
     #ModifyAsset .asset-basics tr td.cflabel {
         width: 13em;

commit aa07c87a8aa52f762bbeb4cf20a8dc1bfa9696a7
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Feb 18 19:37:10 2014 -0500

    Setting width: 49% when there is only one <tr> makes the text entry 0-width

diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
index f04d363..b87fa81 100644
--- a/static/css/RTx-Assets.css
+++ b/static/css/RTx-Assets.css
@@ -141,6 +141,10 @@
         display: inline-block;
         width: 49%;
     }
+    .asset-info-cfs .edit-custom-fields tr:only-child,
+    #ModifyAsset .asset-basics tr:only-child {
+        width: inherit;
+    }
 
     .asset-info-cfs .edit-custom-fields tr td.cflabel,
     #ModifyAsset .asset-basics tr td.label,

commit 2aa247125592a008bc5f198e9c8751929e70432e
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Feb 18 19:38:34 2014 -0500

    Force full-width on the CFs, to line up vertically with the Basics columns

diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
index b87fa81..c3d6bba 100644
--- a/static/css/RTx-Assets.css
+++ b/static/css/RTx-Assets.css
@@ -136,6 +136,10 @@
 
 /* On a reasonable-width screen, make better use of whitespace */
 @media (min-width: 601px) {
+    .asset-info-cfs .edit-custom-fields {
+        width: 100%;
+    }
+
     .asset-info-cfs .edit-custom-fields tr,
     #ModifyAsset .asset-basics tr {
         display: inline-block;

commit af45230cde3d153aea03ef4891a797229fb93acb
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Feb 18 19:38:57 2014 -0500

    Set the <td>s to be inline-block as well, to fix rendering width
    
    <td>s inside an inline-block render extremely oddly, failing to
    correctly observe explicit width: constraints because they fail to find
    any objects with display: table-row set above them.  Swap them to
    inline-block, to provide a more consistent display.

diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
index c3d6bba..5530aa0 100644
--- a/static/css/RTx-Assets.css
+++ b/static/css/RTx-Assets.css
@@ -140,6 +140,11 @@
         width: 100%;
     }
 
+    .asset-info-cfs .edit-custom-fields tr td,
+    #ModifyAsset .asset-basics tr td {
+        display: inline-block;
+    }
+
     .asset-info-cfs .edit-custom-fields tr,
     #ModifyAsset .asset-basics tr {
         display: inline-block;

commit 0591c12ed15a682ba8225ef82668aa7f137083c0
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Feb 18 19:40:28 2014 -0500

    Tighten up labels to reduce wrapping problems with inline-block
    
    Redering <td>s as inline-block brings in somewwhat confusing redering
    when the width is insufficient for the elements, wrapping them to the
    next line.  Reduce the size of the labels to make the range of widths
    with these problems smaller; once the window width is small enough, the
    rendering switches to single-column, with none of these issues.

diff --git a/static/css/RTx-Assets.css b/static/css/RTx-Assets.css
index 5530aa0..3f7232f 100644
--- a/static/css/RTx-Assets.css
+++ b/static/css/RTx-Assets.css
@@ -158,7 +158,7 @@
     .asset-info-cfs .edit-custom-fields tr td.cflabel,
     #ModifyAsset .asset-basics tr td.label,
     #ModifyAsset .asset-basics tr td.cflabel {
-        width: 13em;
+        width: 8em;
     }
 
     /* Asset creation */

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list