[Bps-public-commit] smokingit branch, master, updated. 123c687481134c6383da7077f2f77a5ebdd07671

Alex Vandiver alexmv at bestpractical.com
Mon Jan 6 23:06:09 EST 2014


The branch, master has been updated
       via  123c687481134c6383da7077f2f77a5ebdd07671 (commit)
      from  64e88327518c5cbfa3f9375b497d3c6e2dd1fd26 (commit)

Summary of changes:
 lib/Smokingit/IRC.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 123c687481134c6383da7077f2f77a5ebdd07671
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Jan 6 23:05:28 2014 -0500

    Move $url to where before it is used

diff --git a/lib/Smokingit/IRC.pm b/lib/Smokingit/IRC.pm
index 1d50288..5e39829 100644
--- a/lib/Smokingit/IRC.pm
+++ b/lib/Smokingit/IRC.pm
@@ -370,9 +370,9 @@ sub do_analyze {
                 value  => 0,
             );
             $status = "is failing " . enum(", ", sort map {$_->filename} @{$fails->items_array_ref});
-            $status = String::IRC->new($status)->red . " - $url");
+            my $url = Jifty->web->url(path => "/test/".$commit->short_sha);
+            $status = String::IRC->new($status)->red . " - $url";
         }
-        my $url = Jifty->web->url(path => "/test/".$commit->short_sha);
         return $smoke->configuration->name . " of ".$commit->short_sha . " on ".$smoke->branch_name
             ." $status";
     }

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list