[Bps-public-commit] rt-extension-assets annotated tag, 1.0rc1, created. 1.0rc1

Alex Vandiver alexmv at bestpractical.com
Mon Jan 27 17:29:47 EST 2014


The annotated tag, 1.0rc1 has been created
        at  4fdcc4d586e79c08e393ec8e02d71fd3ad5589e4 (tag)
   tagging  ea428b68c1579d7ef130bb4b915455d782dc87c3 (commit)
 tagged by  Alex Vandiver
        on  Mon Jan 27 17:29:10 2014 -0500

- Log -----------------------------------------------------------------
Version 1.0rc1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAlLm3bYACgkQMflWJZZAbqBRagCgpbNiyvXhOSIL4e0L/wtR0gm+
+q8An143EncsIiORriA7p4nML9kNTf86
=nSCj
-----END PGP SIGNATURE-----

Alex Vandiver (135):
      Prevent a 500 (fatal error) when there are no non-fatal errors
      Move from a Disabled column to a Status column with a lifecycle
      Remove paging restriction for now
      Don't display checkboxes for single member role groups
      Switch to a user autocomplete for Owners
      Remove stray debugging line
      Merge branch 'catalogs'
      Fix variable name to compile
      Replace LimitRoleMember with RoleLimit from RT::Role::SearchBuilder::Roles
      Basic search
      CF searching
      Allow searching on asset roles
      Default to a "LIKE" match on CFs
      Update for new CustomFieldLookupType
      Add role group columns
      Add columnmaps for related ticket searches
      Allow sorting of search results
      Updated Module::Install::RTx and static/ now that JS does in static/js
      Update META.yml for 81ee54f
      Merge branch 'ticket-asset-summary'
      Use data-autocomplete and friends for autocompleters
      Passing Catalog => 0 is a supported operation
      Allow passing of id during RT::Asset->Create
      Link titlebox headers on asset CF groupings
      Merge branch 'search-improvements'
      Always select the first possible Requestor option
      Link asset names to their display pages
      Show history on asset display page
      Show all related assets, not just HeldBy
      Role restrictions to /User/Elements/AssetList are AND'd; use Roles => [''] for 'any role'
      Omit the (Unchanged) in asset statuses, as scrips can't fire and alter them
      Merge branch 'use-default-catalog-everywhere'
      Date CFs are now handled by core /Elements/SelectCustomFieldValue
      CFs may appear multiple times on the search page; avoid ARRAY(0xdeadbeef) in textboxes
      Like CF edit boxes, synchronize CF values between identical boxes
      CSS is now served from static/css/ not html/Noauth/css/
      Ensure that CSS classes are applied to all input/display rows, for ease of customization
      Updates for new 4.2 menu organization
      Move CFs to below people and links
      Revert "always show Assets widget and also with an input to link one"
      Show Assets box when lacking assets, only for configured queues
      Add quick ways of removing and adding more linked assets
      Localize the asset number placeholder
      Update for new rights API
      CreateRoleGroup now takes a Name, not a Type
      Seeing things is more of a General right; it's odd to not list any such
      Allow per-catalog CF rights
      Ensure that CFs from Catalogs have their ContextObj set
      Warning avoidance
      Hide groupings in the menu which do not apply
      Restore "refresh on catalog select" functionality
      Show information in Assets box for all related assets, not just targets
      Link users and groups with ShowUser
      Let users know if the search ran but produced no results
      Don't clobber the existing context object if it has one already
      Show "Create linked ticket" on selfservice pages
      Do modal popup for SelfService pages as well; move JS into RTx-Assets.js
      Allow linking to assets one cannot modify
      Show assets for unpriv users as well
      Paging of assets
      Add documentation on existing configuration options
      Simple searching for assets
      Use the new $Path callback argument
      Show assets during ticket creation
      Search input that should have been added in e2bb2ab
      Remove misplaced closing </form> tag
      There is no reason to default to an empty role type
      Selecting single-value role groups to add to is unnecessary
      Don't recurse into groups in roles (see rt 740704a)
      Sorting by id is slightly more useful
      Role ColumnMap properties are now automatically computed
      Don't apply these classes during asset creation
      Autocomplete roles during asset search
      CF limits now warn unless case sensitivity is specified
      CFs during create need to know their context object for rights
      Make the asset search box "sticky"
      Support LIKE searches on id, via CAST(), which is supported on all DB types
      Default to sorting by id
      Add a CSS class to the asset list on user summary
      Show all CFs in the Basics grouping along with the asset basics when searching
      There is no need to pass an unloaded asset object around; pass the class, instead
      Only check ->Count once for determining if we have content
      Support negative searching on asset attributes
      Allow sorting by CF by loading the CF object when we have context
      Add a portlet for searching assets
      For consistency with CFs, add a : after the core properties
      Move to calling ShowRoleMembers twice instead of using a subref
      Show extra user information on users related to assets
      Show user information in an accordion
      Update Module::Install::RTx version
      Switch to the new public RegisterLookupType method from _ForObjectType
      Tighten up people display
      Add additional callbacks for manipulating people display
      Remove an unnecessary callback; DefaultOnCreate is sufficient
      Preserve negative search parameters upon bulk submit, as well
      Don't lose the ! on negative search parameters in @PassArguments
      Don't submit ARRAY(0x...) for query CFs that appear multiply
      Only show statuses for the current catalog
      Display initial statuses only if we have a new AssetObj
      Merge branch 'bulk-update'
      Bump versions in inc/
      Enable plugin before installing tables, so the lifecycle exists
      Swap to the new Plugin() line; since Assets is 4.2+, it is guaranteed to exist
      Tag lib/RT/Extension/Assets.pm and update year
      Merge branch 'license-tagging'
      checkpoint
      Prevent undef warning if there are no query params
      Use   to prevent awkward word wrapping
      Revert "checkpoint"
      Allow Initial callback to adjust results, as well as prevent updates
      Set the "inverse" class on titlebox titles, which makes them render well on rudder
      Bump the version slightly; still pre-1.0
      Ensure that assets on the ticket display page are full-width
      Move ModifyAssetSearch earlier, so it can modify the set of roles
      Ensure that OCF SortORder is applied, not CF SortOrder
      Split People out into their own box
      Ensure that CFs in Dates and Links also get a chance to show
      Append colons to main 4 status fields, for consistency with CFs
      Merge branch '1.0/bug-fixes'
      Re-add necessary =encoding line
      Trailing "1;" is unnecessary, and shows up in POD
      Unwrap incorrectly wrapped link
      Trim trailing whitespace
      Typo fixes
      Simplify wording; also, because on 4.2 and above we recommend Plugin()
      Line up configuration lines
      Minor wording changes
      Switch to two-column layout on middling width displays
      CSS tidy to standardize whitespace variations
      Merge branch '1.0/style'
      Add catalog name to all asset modify and display pages
      Merge branch '1.0/add-catalog-css-class'
      Version bump for 1.0rc1
      Ignore generated SIGNATURE
      Expand the #!include_default, as Make wants to do

Jesse Vincent (8):
      Cut some input sizes down so they will actually fit inside a reflowed layout
      Make the "create an asset" form contain a table for semi-reliable twocol layout.
      add some more html so we can style it
      wording change "but not" -> "not" for brevity
      styling hook for 'not'
      Brevity. In a column labeled 'tickets', don't repeat the words "tickets" twice per line
      This change would want to move into RT if it's accepted. it makes our search results not wrap funny
      First pass at comprehensive styling for assets

Jim Brandt (22):
      Add tests for CF methods
      Port LoadCustomFieldByIdentifier to assets
      Show only search CFs on initial page load
      Use groupings to display asset search criteria
      Add catalog to the search
      Assign a subclause to the delete status limit
      Add status to search criteria
      Add DefaultCatalog and RememberDefaultCatalog options
      Use default catalog logic with asset create
      Move GetCatalogObj component to LoadDefaultCatalog function
      Update Assets Admin page with correct menu
      Add link descriptions for Asset Admin page
      Pass correct parameter name Asset with asset it
      Don't set a DefaultCatalog by default
      Add rights section to default assets configuration
      Don't show User Summary link on SelfService pages
      Add tutorial config and initialdata files
      Add tutorial document
      Check in images
      Move getting started docs into primary module file
      Update README and MANIFEST
      Merge branch '1.0/tutorial'

Kevin Falcone (11):
      Move MyAssets into UserElements
      Provide a callback to modify the format used to list Assets
      Document the MyAssets and UserAssets portlets
      Say "Asset #3" more consistently
      Show the Asset's Name in the link stringification
      You can call AssetList with Roles => [''] to get "all roles"
      Add a ModifyAssetSearch so that you can tweak the Role search
      Rename id to Asset for consistency
      Accept a Requestors argument
      Run RT's license_tag on the assets extension.
      Display the number of assets found.

Ruslan Zakirov (3):
      extract search arguments processing
      Make it possible to skip session update
      bulk updates for assets

Thomas Sibley (156):
      Skeleton
      Build and install framework
      Requires at least RT 4.0.0
      Asset schema
      Testing infrastructure
      Basic record creation for Assets
      Failing tests for adding CF values to new Assets
      Allow custom fields to be applied to Assets
      Add more documentation and rearrange a little code to fit
      Basic global rights for asset creation, reading, and updating
      RT::Assets class and tests
      Database ACLs on our new table for Pg
      Upgrade M::I::RTx to 0.29_02
      Links support for assets
      Simplify rights checks on unloaded Asset objects
      Skip undefined custom field values during asset creation
      Beginnings of a basic Create page
      Handle the Disabled field and use WritableAttributes instead of a hardcoded list
      loc() the permission denied Abort() message
      Pass a reference to %ARGS instead of %ARGS itself
      Implicit form actions allow default query params in the request URL
      Beginnings of a basic Update page
      Beginnings of a basic display page
      Sketch of menus; not all links point to existing pages
      Create system and per-asset role groups for Owner, User, Technical Contact
      Require ShowAsset for RT::Asset->RoleGroup
      People on the Asset display page
      Convenience methods to grab asset Owners, Users, and Technical Contacts
      Refactoring loading assets in Mason into a LoadAsset function
      Nothing about asset roles implies watching; rename for accuracy
      Spaces in role names make life needlessly difficult
      Methods to add and delete members from role groups
      Support for adding role members in RT::Asset->Create
      Modify People page
      Protect asset role membership with ModifyAsset
      Avoid passing Type to _AddMember; _AddMember doesn't use it
      Refactor generic role member methods into 4.2/extensible-roles
      Tests for role member management
      Consistently format right names in POD with I<>
      Merge branch 'roles'
      Localize a bunch of titlebox titles
      Move the colon outside of localization so the role name is translated
      Index asset names for better loading
      The changes to scrips in soon-to-be-master renamed this method
      A basic column map for assets
      Switch to Show/EditCustomFieldCustomGroups from core
      Use the new custom field grouping components
      Built-in CF groupings for assets: Basics, People, Dates, Links
      Move People CFs around for better layout
      Display Created, LastUpdated, and CF dates
      Modify dates page
      Add global CF admin page for asset CFs
      Modify links page
      Show links on the display page!
      Use the passed in asset name in Create's success message
      Silence test warnings
      Don't index HTML::Mason::Commands; whenever this may end up on CPAN...
      Test for Add/DelWatcher transactions for role member changes
      Update M::I
      Newer ValidateCustomFields element ignores NamePrefix and expects Object
      History page using new generic component from trs/history branch
      Move the History menu item next to Display, emulating the page menu for tickets
      Transactions of type Enabled and Disabled when setting the Disabled column
      Basic assets list for easier testing and poking around
      LimitRoleMember method for RT::Assets
      A basic My Assets page for Self Service users
      Tests: Refactor the meat of create_assets() into a singular create_asset()
      Tests: Failing tests for granting rights on asset roles
      Link display was added in 9ebc4344
      Check ShowAsset in LoadAsset() and create LoadAssetForUpdate() to check ModifyAsset
      Replace asset loading and rights boilerplate with LoadAsset()
      Refactor display page into a separate element for reuse in Self Service
      Self Service asset display
      Refactor ShowSummary to loop rather than repeat itself
      Link the section titles to the relevant modify pages
      The basics modify page is Modify.html not ModifyBasics.html
      Color the various boxes the same as tickets
      Validate CF values on all modify pages
      ShowRelationLabel is now fixed in master
      Show non-core CF groupings as separate pages
      Remove incorrect interpolation from localized strings
      Extracted message catalog
      History page for Self Service
      Don't show the asset page menus on create
      Test the correct column, now with current master
      Use the new role group parsing/creation on master during asset creation
      Avoid undef warnings; the empty string matches \D
      Test web create form
      Failing test for CFs with validation in custom groupings on web create
      Let user see the role groups of just-created assets
      Rename roles to Owner, Held By, and Contact
      Test specifying a Contact with CreateAsset but not ShowAsset works
      Mark failing tests as TODO
      Remove most ModifyAsset ACL checks from UI
      Index the Disabled column since it's a persistent clause in almost every asset query
      Easily create tickets linked to the current asset from asset pages
      Avoid generating menus for invalid asset IDs
      Render lifecycle actions in the page menu
      First draft of a "getting started" doc for assets
      Update M::I
      Move _DoSearch and _DoCount under Private Methods and (briefly) document them
      Initial cut of Catalogs (queues for assets)
      Adjust tests to account for catalogs
      Create transactions of type Status when the field is Status
      Changing Catalogs can now make the asset unreadable; override that in _Set
      Show Catalog names, instead of ids, in transaction descriptions
      Support catalogs on the create and edit pages
      Catalog selection interstitial before the asset create page
      Adjust target element for the create linked ticket modal
      Global Asset CFs now involve Catalogs
      Turn role member handling and processing into generic components
      Escape role name in CSS classes
      Admin interface for Catalogs
      Show implicit role members from the asset's catalog
      Unsubmitted CFs are now skipped during validation
      Basic cache busting for SelectCatalog
      Roles are now in a role, adjust our ACL wrapping of methods appropriately
      Mark the Owner role as only for ACLs at the catalog and system level
      Canonicalize catalog names into numeric IDs during asset creation
      Extract a fresh blank message catalog for Catalogs
      Workaround the lack of context objects for Catalogs
      No longer true with ACLOnly roles
      Merge branch 'searching'
      Correct documentation to point to the role instead of RT::Record
      Sort roles in general order of importance: Owner, Held By, Contact
      Consume the Links role in order to process links on create and purge some code
      Use the renamed roles from 4.2/rename-role-classes
      Add links to the asset create form
      Provide a default catalog for ease of getting started
      Update the getting started doc to account for catalogs
      Note the current caching limitation
      Add some more explanation about catalogs
      Don't show catalog role members for Single user roles, such as Owner
      Offer to prefill Requestors with one of the populated asset role members
      Don't try to grant rights directly to asset roles
      Switch to runtime loading of class dependencies
      Bust the catalog cache when ShowCatalog or CreateAsset is granted or revoked
      Add two BeforeActionList callbacks for customizing the asset display
      Add another two BeforeDisplay callbacks
      Tell PAUSE not to index RT::Transaction
      Clean up documentation on the new CF methods
      Update Module::Install::RTx
      Merge branch 'add-load-custom-field-by-identifier'
      RoleLimit requires a subclause otherwise entry aggregators are mangled
      Merge branch 'user-summary-assets'
      Merge branch 'more-info-in-asstring'
      Asset column map entry for Catalog
      Summarize linked assets on the ticket display page
      Add configuration option for the asset summary format
      Show other tickets related to the asset in the asset summary
      History is only shown on the history page, so set the DisplayPath appropriately
      Lowercase statuses on asset creation to match behaviour of core
      Groups on master now have a unified Name column instead of Name and/or Type
      Include the current and next statuses for lifecycle actions
      AfterUpdate callback pairs nicely with the BeforeUpdate callback
      Preserve the DisplayAfter argument to Modify.html in case of forced resubmission

sunnavy (19):
      add AfterShowSummary callback
      default to nobody if user is empty
      always show Assets widget and also with an input to link one
      people widget for create page
      abstract edit people stuff to a separated component
      don't hardcore role names in people edit page
      split create page into "Basics" and "Details" tabs
      make default behavior of AssetBasicCustomFieldsOnCreate better
      add extra css class for each role in EditPeople widget
      autocomplete EditPeople
      we have RT::Interface::CSSClass to migrate name to valid css class
      add DefaultStatus callback in EditBasics
      data-autocomplete is in core now
      grouping custom fields for bulk update
      Initial callback so we can check right or something in the callback
      like search page, widens to 2 columns for bulk update page too
      don't position "User Summary" as "absolute right" for small screens.
      edge case fix so we can use 2-columns in modify pages generally.
      2-columns layout for people widget in search/bulk

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list