[Bps-public-commit] rt-extension-announce branch, master, updated. 0.06-7-gd69ba32

Wallace Reis wreis at bestpractical.com
Mon Mar 10 14:37:56 EDT 2014


The branch, master has been updated
       via  d69ba3253c59fc4fd1c243e417888cf38b59f977 (commit)
       via  2ad5ba9954259d5e49990d1d6fcd68616e40bbac (commit)
      from  ffe0fffedbf58f123d892116d8df2e38bc56d692 (commit)

Summary of changes:
 MANIFEST                                 |   2 +
 README                                   |   7 ++
 {static => html/NoAuth}/css/announce.css |   0
 {static => html/NoAuth}/js/announce.js   |   0
 inc/Module/Install/Can.pm                | 154 -------------------------------
 inc/Module/Install/Fetch.pm              |  93 -------------------
 inc/Module/Install/RTx.pm                |  22 +++--
 inc/Module/Install/RTx/Factory.pm        |  11 ++-
 inc/Module/Install/ReadmeFromPod.pm      |   2 +-
 inc/Module/Install/Substitute.pm         | 131 --------------------------
 inc/Module/Install/Win32.pm              |  64 -------------
 inc/Module/Install/WriteAll.pm           |  63 -------------
 12 files changed, 34 insertions(+), 515 deletions(-)
 copy {static => html/NoAuth}/css/announce.css (100%)
 copy {static => html/NoAuth}/js/announce.js (100%)
 delete mode 100644 inc/Module/Install/Can.pm
 delete mode 100644 inc/Module/Install/Fetch.pm
 delete mode 100644 inc/Module/Install/Substitute.pm
 delete mode 100644 inc/Module/Install/Win32.pm
 delete mode 100644 inc/Module/Install/WriteAll.pm

- Log -----------------------------------------------------------------
commit 2ad5ba9954259d5e49990d1d6fcd68616e40bbac
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Mon Mar 10 15:35:57 2014 -0300

    RT#91227, GH#1 - Keep backcompat with 4.0
    
    For now, let's have copy of the files. Eventually, there will be a
    new release of RTx for handling this better.

diff --git a/MANIFEST b/MANIFEST
index 79b0584..f6e4bc8 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -2,6 +2,8 @@ etc/initialdata
 html/Callbacks/RT-Extension-Announce/Elements/PageLayout/BeforeBody
 html/Callbacks/RT-Extension-Announce/m/_elements/menu/MassageMenu
 html/m/announcements
+html/NoAuth/css/announce.css
+html/NoAuth/js/announce.js
 static/css/announce.css
 static/js/announce.js
 inc/Module/Install.pm
diff --git a/html/NoAuth/css/announce.css b/html/NoAuth/css/announce.css
new file mode 100644
index 0000000..022eac9
--- /dev/null
+++ b/html/NoAuth/css/announce.css
@@ -0,0 +1,84 @@
+#announce {
+  padding-top: 10px; /* Keep from running into the menu on the right */
+}
+
+table.announce {
+  background-color:#fcc;
+  width: 100%;
+  border-top-left-radius: 0.3em;
+  border-top-right-radius: 0.3em;
+  border-bottom-right-radius: 0.3em;
+  border-bottom-left-radius: 0.3em;
+  valign: top;
+  border-left: 1px solid #ccc;
+  border-top: 1px solid #ccc;
+  border-bottom: 2px solid #aaa;
+  border-right: 2px solid #aaa;
+  border-radius: 0.5em;
+  padding: 1em 1em 1em 1em;
+}
+
+td.toggle_announcements {
+  text-align: center;
+}
+
+a.toggle_announcements:link {
+  font-weight: bold;
+  color: #000000;
+}
+
+a.toggle_announcements:visited {
+  font-weight: bold;
+  color: #000000;
+}
+
+a.toggle_announcements:hover {
+  font-weight: bold;
+  color: #808080;
+  text-decoration: none;
+}
+
+a.announcements_detail:link {
+  text-decoration: underline;
+}
+
+a.announcements_detail:visited {
+  text-decoration: underline;
+}
+
+a.announcements_detail:hover {
+  text-decoration: underline;
+}
+
+td.announce_subject {
+  width: 25%;
+  color: red;
+  font-weight: bold;
+}
+
+a.announce_subject:link, span.announce_subject {
+  color: red;
+  font-weight: bold;
+}
+
+a.announce_subject:visited {
+  color: red;
+  font-weight: bold;
+}
+
+ul.menu li:first-child {
+  background-color: #fcc;
+  margin-top: -1em;
+  padding-top: 1.4em; /* to fill the background for parent margin-top */
+  border-top-left-radius: 1em;
+  border-top-right-radius: 1em;
+}
+
+ul.menu a.announce {
+  background-color: #fcc;
+}
+
+table.announce td.date {
+  font-size: smaller;
+  color: #777;
+}
diff --git a/html/NoAuth/js/announce.js b/html/NoAuth/js/announce.js
new file mode 100644
index 0000000..588f503
--- /dev/null
+++ b/html/NoAuth/js/announce.js
@@ -0,0 +1,17 @@
+
+jQuery(document).ready(function() {
+    jQuery('#more_announcements').hide();
+    var hide = true;
+    jQuery('#toggle_announcements').click( function() {
+        if ( hide == true ) {
+            jQuery('#more_announcements').show();
+            jQuery('#toggle_announcements').html('Less Announcements');
+            hide = false;
+        }
+        else if ( hide == false ) {
+            jQuery('#more_announcements').hide();
+            jQuery('#toggle_announcements').html('More Announcements');
+            hide = true;
+        }
+    });
+});
diff --git a/inc/Module/Install/Can.pm b/inc/Module/Install/Can.pm
deleted file mode 100644
index 22167b8..0000000
--- a/inc/Module/Install/Can.pm
+++ /dev/null
@@ -1,154 +0,0 @@
-#line 1
-package Module::Install::Can;
-
-use strict;
-use Config                ();
-use ExtUtils::MakeMaker   ();
-use Module::Install::Base ();
-
-use vars qw{$VERSION @ISA $ISCORE};
-BEGIN {
-	$VERSION = '1.06';
-	@ISA     = 'Module::Install::Base';
-	$ISCORE  = 1;
-}
-
-# check if we can load some module
-### Upgrade this to not have to load the module if possible
-sub can_use {
-	my ($self, $mod, $ver) = @_;
-	$mod =~ s{::|\\}{/}g;
-	$mod .= '.pm' unless $mod =~ /\.pm$/i;
-
-	my $pkg = $mod;
-	$pkg =~ s{/}{::}g;
-	$pkg =~ s{\.pm$}{}i;
-
-	local $@;
-	eval { require $mod; $pkg->VERSION($ver || 0); 1 };
-}
-
-# Check if we can run some command
-sub can_run {
-	my ($self, $cmd) = @_;
-
-	my $_cmd = $cmd;
-	return $_cmd if (-x $_cmd or $_cmd = MM->maybe_command($_cmd));
-
-	for my $dir ((split /$Config::Config{path_sep}/, $ENV{PATH}), '.') {
-		next if $dir eq '';
-		require File::Spec;
-		my $abs = File::Spec->catfile($dir, $cmd);
-		return $abs if (-x $abs or $abs = MM->maybe_command($abs));
-	}
-
-	return;
-}
-
-# Can our C compiler environment build XS files
-sub can_xs {
-	my $self = shift;
-
-	# Ensure we have the CBuilder module
-	$self->configure_requires( 'ExtUtils::CBuilder' => 0.27 );
-
-	# Do we have the configure_requires checker?
-	local $@;
-	eval "require ExtUtils::CBuilder;";
-	if ( $@ ) {
-		# They don't obey configure_requires, so it is
-		# someone old and delicate. Try to avoid hurting
-		# them by falling back to an older simpler test.
-		return $self->can_cc();
-	}
-
-	# Do we have a working C compiler
-	my $builder = ExtUtils::CBuilder->new(
-		quiet => 1,
-	);
-	unless ( $builder->have_compiler ) {
-		# No working C compiler
-		return 0;
-	}
-
-	# Write a C file representative of what XS becomes
-	require File::Temp;
-	my ( $FH, $tmpfile ) = File::Temp::tempfile(
-		"compilexs-XXXXX",
-		SUFFIX => '.c',
-	);
-	binmode $FH;
-	print $FH <<'END_C';
-#include "EXTERN.h"
-#include "perl.h"
-#include "XSUB.h"
-
-int main(int argc, char **argv) {
-    return 0;
-}
-
-int boot_sanexs() {
-    return 1;
-}
-
-END_C
-	close $FH;
-
-	# Can the C compiler access the same headers XS does
-	my @libs   = ();
-	my $object = undef;
-	eval {
-		local $^W = 0;
-		$object = $builder->compile(
-			source => $tmpfile,
-		);
-		@libs = $builder->link(
-			objects     => $object,
-			module_name => 'sanexs',
-		);
-	};
-	my $result = $@ ? 0 : 1;
-
-	# Clean up all the build files
-	foreach ( $tmpfile, $object, @libs ) {
-		next unless defined $_;
-		1 while unlink;
-	}
-
-	return $result;
-}
-
-# Can we locate a (the) C compiler
-sub can_cc {
-	my $self   = shift;
-	my @chunks = split(/ /, $Config::Config{cc}) or return;
-
-	# $Config{cc} may contain args; try to find out the program part
-	while (@chunks) {
-		return $self->can_run("@chunks") || (pop(@chunks), next);
-	}
-
-	return;
-}
-
-# Fix Cygwin bug on maybe_command();
-if ( $^O eq 'cygwin' ) {
-	require ExtUtils::MM_Cygwin;
-	require ExtUtils::MM_Win32;
-	if ( ! defined(&ExtUtils::MM_Cygwin::maybe_command) ) {
-		*ExtUtils::MM_Cygwin::maybe_command = sub {
-			my ($self, $file) = @_;
-			if ($file =~ m{^/cygdrive/}i and ExtUtils::MM_Win32->can('maybe_command')) {
-				ExtUtils::MM_Win32->maybe_command($file);
-			} else {
-				ExtUtils::MM_Unix->maybe_command($file);
-			}
-		}
-	}
-}
-
-1;
-
-__END__
-
-#line 236
diff --git a/inc/Module/Install/Fetch.pm b/inc/Module/Install/Fetch.pm
deleted file mode 100644
index bee0c4f..0000000
--- a/inc/Module/Install/Fetch.pm
+++ /dev/null
@@ -1,93 +0,0 @@
-#line 1
-package Module::Install::Fetch;
-
-use strict;
-use Module::Install::Base ();
-
-use vars qw{$VERSION @ISA $ISCORE};
-BEGIN {
-	$VERSION = '1.06';
-	@ISA     = 'Module::Install::Base';
-	$ISCORE  = 1;
-}
-
-sub get_file {
-    my ($self, %args) = @_;
-    my ($scheme, $host, $path, $file) =
-        $args{url} =~ m|^(\w+)://([^/]+)(.+)/(.+)| or return;
-
-    if ( $scheme eq 'http' and ! eval { require LWP::Simple; 1 } ) {
-        $args{url} = $args{ftp_url}
-            or (warn("LWP support unavailable!\n"), return);
-        ($scheme, $host, $path, $file) =
-            $args{url} =~ m|^(\w+)://([^/]+)(.+)/(.+)| or return;
-    }
-
-    $|++;
-    print "Fetching '$file' from $host... ";
-
-    unless (eval { require Socket; Socket::inet_aton($host) }) {
-        warn "'$host' resolve failed!\n";
-        return;
-    }
-
-    return unless $scheme eq 'ftp' or $scheme eq 'http';
-
-    require Cwd;
-    my $dir = Cwd::getcwd();
-    chdir $args{local_dir} or return if exists $args{local_dir};
-
-    if (eval { require LWP::Simple; 1 }) {
-        LWP::Simple::mirror($args{url}, $file);
-    }
-    elsif (eval { require Net::FTP; 1 }) { eval {
-        # use Net::FTP to get past firewall
-        my $ftp = Net::FTP->new($host, Passive => 1, Timeout => 600);
-        $ftp->login("anonymous", 'anonymous at example.com');
-        $ftp->cwd($path);
-        $ftp->binary;
-        $ftp->get($file) or (warn("$!\n"), return);
-        $ftp->quit;
-    } }
-    elsif (my $ftp = $self->can_run('ftp')) { eval {
-        # no Net::FTP, fallback to ftp.exe
-        require FileHandle;
-        my $fh = FileHandle->new;
-
-        local $SIG{CHLD} = 'IGNORE';
-        unless ($fh->open("|$ftp -n")) {
-            warn "Couldn't open ftp: $!\n";
-            chdir $dir; return;
-        }
-
-        my @dialog = split(/\n/, <<"END_FTP");
-open $host
-user anonymous anonymous\@example.com
-cd $path
-binary
-get $file $file
-quit
-END_FTP
-        foreach (@dialog) { $fh->print("$_\n") }
-        $fh->close;
-    } }
-    else {
-        warn "No working 'ftp' program available!\n";
-        chdir $dir; return;
-    }
-
-    unless (-f $file) {
-        warn "Fetching failed: $@\n";
-        chdir $dir; return;
-    }
-
-    return if exists $args{size} and -s $file != $args{size};
-    system($args{run}) if exists $args{run};
-    unlink($file) if $args{remove};
-
-    print(((!exists $args{check_for} or -e $args{check_for})
-        ? "done!" : "failed! ($!)"), "\n");
-    chdir $dir; return !$?;
-}
-
-1;
diff --git a/inc/Module/Install/RTx.pm b/inc/Module/Install/RTx.pm
index 6f778bc..ac04c79 100644
--- a/inc/Module/Install/RTx.pm
+++ b/inc/Module/Install/RTx.pm
@@ -8,13 +8,13 @@ no warnings 'once';
 
 use Module::Install::Base;
 use base 'Module::Install::Base';
-our $VERSION = '0.30';
+our $VERSION = '0.32';
 
 use FindBin;
 use File::Glob     ();
 use File::Basename ();
 
-my @DIRS = qw(etc lib html bin sbin po var static);
+my @DIRS = qw(etc lib html static bin sbin po var);
 my @INDEX_DIRS = qw(lib bin sbin);
 
 sub RTx {
@@ -62,10 +62,11 @@ sub RTx {
     unshift @INC, "$RT::LocalPath/lib" if $RT::LocalPath;
     unshift @INC, $lib_path;
 
-    $RT::LocalVarPath  ||= $RT::VarPath;
-    $RT::LocalPoPath   ||= $RT::LocalLexiconPath;
-    $RT::LocalHtmlPath ||= $RT::MasonComponentRoot;
-    $RT::LocalLibPath  ||= "$RT::LocalPath/lib";
+    $RT::LocalVarPath    ||= $RT::VarPath;
+    $RT::LocalPoPath     ||= $RT::LocalLexiconPath;
+    $RT::LocalHtmlPath   ||= $RT::MasonComponentRoot;
+    $RT::LocalStaticPath ||= $RT::StaticPath;
+    $RT::LocalLibPath    ||= "$RT::LocalPath/lib";
 
     my $with_subdirs = $ENV{WITH_SUBDIRS};
     @ARGV = grep { /WITH_SUBDIRS=(.*)/ ? ( ( $with_subdirs = $1 ), 0 ) : 1 }
@@ -135,6 +136,7 @@ install ::
         $has_etc{acl}++;
     }
     if ( -e 'etc/initialdata' ) { $has_etc{initialdata}++; }
+    if ( -d 'etc/upgrade/' )    { $has_etc{upgrade}++; }
 
     $self->postamble("$postamble\n");
     unless ( $subdirs{'lib'} ) {
@@ -163,6 +165,12 @@ install ::
 .
         $self->postamble("initdb ::\n$initdb\n");
         $self->postamble("initialize-database ::\n$initdb\n");
+        if ($has_etc{upgrade}) {
+            print "To upgrade from a previous version of this extension, use 'make upgrade-database'\n";
+            my $upgradedb = qq|\t\$(NOECHO) \$(PERL) -Ilib -I"$local_lib_path" -I"$lib_path" -Minc::Module::Install -e"RTxInitDB(qw(upgrade \$(NAME) \$(VERSION)))"\n|;
+            $self->postamble("upgrade-database ::\n$upgradedb\n");
+            $self->postamble("upgradedb ::\n$upgradedb\n");
+        }
     }
 }
 
@@ -208,4 +216,4 @@ sub requires_rt {
 
 __END__
 
-#line 328
+#line 336
diff --git a/inc/Module/Install/RTx/Factory.pm b/inc/Module/Install/RTx/Factory.pm
index a8702e4..6776688 100644
--- a/inc/Module/Install/RTx/Factory.pm
+++ b/inc/Module/Install/RTx/Factory.pm
@@ -32,12 +32,19 @@ sub RTxInitDB {
         "-I$lib_path",
         "$RT::SbinPath/rt-setup-database",
         "--action"      => $action,
-        "--datadir"     => "etc",
+        ($action eq 'upgrade' ? () : ("--datadir"     => "etc")),
         (($action eq 'insert') ? ("--datafile"    => "etc/initialdata") : ()),
-        "--dba"         => $RT::DatabaseUser,
+        "--dba"         => $RT::DatabaseAdmin || $RT::DatabaseUser,
         "--prompt-for-dba-password" => '',
         (RT::System->can('AddUpgradeHistory') ? ("--package" => $name, "--ext-version" => $version) : ()),
     );
+    # If we're upgrading against an RT which isn't at least 4.2 (has
+    # AddUpgradeHistory) then pass --package.  Upgrades against later RT
+    # releases will pick up --package from AddUpgradeHistory.
+    if ($action eq 'upgrade' and
+        not RT::System->can('AddUpgradeHistory')) {
+        push @args, "--package" => $name;
+    }
 
     print "$^X @args\n";
     (system($^X, @args) == 0) or die "...returned with error: $?\n";
diff --git a/inc/Module/Install/ReadmeFromPod.pm b/inc/Module/Install/ReadmeFromPod.pm
index fb7075f..b5e03c3 100644
--- a/inc/Module/Install/ReadmeFromPod.pm
+++ b/inc/Module/Install/ReadmeFromPod.pm
@@ -7,7 +7,7 @@ use warnings;
 use base qw(Module::Install::Base);
 use vars qw($VERSION);
 
-$VERSION = '0.18';
+$VERSION = '0.22';
 
 sub readme_from {
   my $self = shift;
diff --git a/inc/Module/Install/Substitute.pm b/inc/Module/Install/Substitute.pm
deleted file mode 100644
index 56af7fe..0000000
--- a/inc/Module/Install/Substitute.pm
+++ /dev/null
@@ -1,131 +0,0 @@
-#line 1
-package Module::Install::Substitute;
-
-use strict;
-use warnings;
-use 5.008; # I don't care much about earlier versions
-
-use Module::Install::Base;
-our @ISA = qw(Module::Install::Base);
-
-our $VERSION = '0.03';
-
-require File::Temp;
-require File::Spec;
-require Cwd;
-
-#line 89
-
-sub substitute
-{
-	my $self = shift;
-	$self->{__subst} = shift;
-	$self->{__option} = {};
-	if( UNIVERSAL::isa( $_[0], 'HASH' ) ) {
-		my $opts = shift;
-		while( my ($k,$v) = each( %$opts ) ) {
-			$self->{__option}->{ lc( $k ) } = $v || '';
-		}
-	}
-	$self->_parse_options;
-
-	my @file = @_;
-	foreach my $f (@file) {
-		$self->_rewrite_file( $f );
-	}
-
-	return;
-}
-
-sub _parse_options
-{
-	my $self = shift;
-	my $cwd = Cwd::getcwd();
-	foreach my $t ( qw(from to) ) {
-        $self->{__option}->{$t} = $cwd unless $self->{__option}->{$t};
-		my $d = $self->{__option}->{$t};
-		die "Couldn't read directory '$d'" unless -d $d && -r _;
-	}
-}
-
-sub _rewrite_file
-{
-	my ($self, $file) = @_;
-	my $source = File::Spec->catfile( $self->{__option}{from}, $file );
-	$source .= $self->{__option}{sufix} if $self->{__option}{sufix};
-	unless( -f $source && -r _ ) {
-		print STDERR "Couldn't find file '$source'\n";
-		return;
-	}
-	my $dest = File::Spec->catfile( $self->{__option}{to}, $file );
-	return $self->__rewrite_file( $source, $dest );
-}
-
-sub __rewrite_file
-{
-	my ($self, $source, $dest) = @_;
-
-	my $mode = (stat($source))[2];
-
-	open my $sfh, "<$source" or die "Couldn't open '$source' for read";
-	print "Open input '$source' file for substitution\n";
-
-	my ($tmpfh, $tmpfname) = File::Temp::tempfile('mi-subst-XXXX', UNLINK => 1);
-	$self->__process_streams( $sfh, $tmpfh, ($source eq $dest)? 1: 0 );
-	close $sfh;
-
-	seek $tmpfh, 0, 0 or die "Couldn't seek in tmp file";
-
-	open my $dfh, ">$dest" or die "Couldn't open '$dest' for write";
-	print "Open output '$dest' file for substitution\n";
-
-	while( <$tmpfh> ) {
-		print $dfh $_;
-	}
-	close $dfh;
-	chmod $mode, $dest or "Couldn't change mode on '$dest'";
-}
-
-sub __process_streams
-{
-	my ($self, $in, $out, $replace) = @_;
-	
-	my @queue = ();
-	my $subst = $self->{'__subst'};
-	my $re_subst = join('|', map {"\Q$_"} keys %{ $subst } );
-
-	while( my $str = <$in> ) {
-		if( $str =~ /^###\s*(before|replace|after)\:\s?(.*)$/s ) {
-			my ($action, $nstr) = ($1,$2);
-			$nstr =~ s/\@($re_subst)\@/$subst->{$1}/ge;
-
-			die "Replace action is bad idea for situations when dest is equal to source"
-                if $replace && $action eq 'replace';
-			if( $action eq 'before' ) {
-				die "no line before 'before' action" unless @queue;
-				# overwrite prev line;
-				pop @queue;
-				push @queue, $nstr;
-				push @queue, $str;
-			} elsif( $action eq 'replace' ) {
-				push @queue, $nstr;
-			} elsif( $action eq 'after' ) {
-				push @queue, $str;
-				push @queue, $nstr;
-				# skip one line;
-				<$in>;
-			}
-		} else {
-			push @queue, $str;
-		}
-		while( @queue > 3 ) {
-			print $out shift(@queue);
-		}
-	}
-	while( scalar @queue ) {
-		print $out shift(@queue);
-	}
-}
-
-1;
-
diff --git a/inc/Module/Install/Win32.pm b/inc/Module/Install/Win32.pm
deleted file mode 100644
index eeaa3fe..0000000
--- a/inc/Module/Install/Win32.pm
+++ /dev/null
@@ -1,64 +0,0 @@
-#line 1
-package Module::Install::Win32;
-
-use strict;
-use Module::Install::Base ();
-
-use vars qw{$VERSION @ISA $ISCORE};
-BEGIN {
-	$VERSION = '1.06';
-	@ISA     = 'Module::Install::Base';
-	$ISCORE  = 1;
-}
-
-# determine if the user needs nmake, and download it if needed
-sub check_nmake {
-	my $self = shift;
-	$self->load('can_run');
-	$self->load('get_file');
-
-	require Config;
-	return unless (
-		$^O eq 'MSWin32'                     and
-		$Config::Config{make}                and
-		$Config::Config{make} =~ /^nmake\b/i and
-		! $self->can_run('nmake')
-	);
-
-	print "The required 'nmake' executable not found, fetching it...\n";
-
-	require File::Basename;
-	my $rv = $self->get_file(
-		url       => 'http://download.microsoft.com/download/vc15/Patch/1.52/W95/EN-US/Nmake15.exe',
-		ftp_url   => 'ftp://ftp.microsoft.com/Softlib/MSLFILES/Nmake15.exe',
-		local_dir => File::Basename::dirname($^X),
-		size      => 51928,
-		run       => 'Nmake15.exe /o > nul',
-		check_for => 'Nmake.exe',
-		remove    => 1,
-	);
-
-	die <<'END_MESSAGE' unless $rv;
-
--------------------------------------------------------------------------------
-
-Since you are using Microsoft Windows, you will need the 'nmake' utility
-before installation. It's available at:
-
-  http://download.microsoft.com/download/vc15/Patch/1.52/W95/EN-US/Nmake15.exe
-      or
-  ftp://ftp.microsoft.com/Softlib/MSLFILES/Nmake15.exe
-
-Please download the file manually, save it to a directory in %PATH% (e.g.
-C:\WINDOWS\COMMAND\), then launch the MS-DOS command line shell, "cd" to
-that directory, and run "Nmake15.exe" from there; that will create the
-'nmake.exe' file needed by this module.
-
-You may then resume the installation process described in README.
-
--------------------------------------------------------------------------------
-END_MESSAGE
-
-}
-
-1;
diff --git a/inc/Module/Install/WriteAll.pm b/inc/Module/Install/WriteAll.pm
deleted file mode 100644
index 85d8018..0000000
--- a/inc/Module/Install/WriteAll.pm
+++ /dev/null
@@ -1,63 +0,0 @@
-#line 1
-package Module::Install::WriteAll;
-
-use strict;
-use Module::Install::Base ();
-
-use vars qw{$VERSION @ISA $ISCORE};
-BEGIN {
-	$VERSION = '1.06';
-	@ISA     = qw{Module::Install::Base};
-	$ISCORE  = 1;
-}
-
-sub WriteAll {
-	my $self = shift;
-	my %args = (
-		meta        => 1,
-		sign        => 0,
-		inline      => 0,
-		check_nmake => 1,
-		@_,
-	);
-
-	$self->sign(1)                if $args{sign};
-	$self->admin->WriteAll(%args) if $self->is_admin;
-
-	$self->check_nmake if $args{check_nmake};
-	unless ( $self->makemaker_args->{PL_FILES} ) {
-		# XXX: This still may be a bit over-defensive...
-		unless ($self->makemaker(6.25)) {
-			$self->makemaker_args( PL_FILES => {} ) if -f 'Build.PL';
-		}
-	}
-
-	# Until ExtUtils::MakeMaker support MYMETA.yml, make sure
-	# we clean it up properly ourself.
-	$self->realclean_files('MYMETA.yml');
-
-	if ( $args{inline} ) {
-		$self->Inline->write;
-	} else {
-		$self->Makefile->write;
-	}
-
-	# The Makefile write process adds a couple of dependencies,
-	# so write the META.yml files after the Makefile.
-	if ( $args{meta} ) {
-		$self->Meta->write;
-	}
-
-	# Experimental support for MYMETA
-	if ( $ENV{X_MYMETA} ) {
-		if ( $ENV{X_MYMETA} eq 'JSON' ) {
-			$self->Meta->write_mymeta_json;
-		} else {
-			$self->Meta->write_mymeta_yaml;
-		}
-	}
-
-	return 1;
-}
-
-1;

commit d69ba3253c59fc4fd1c243e417888cf38b59f977
Author: Wallace Reis <wreis at bestpractical.com>
Date:   Mon Mar 10 15:37:31 2014 -0300

    Update README

diff --git a/README b/README
index a01db58..990c299 100644
--- a/README
+++ b/README
@@ -13,6 +13,7 @@ INSTALLATION
             Set(@Plugins, qw(RT::Extension::Announce));
             Set(@CustomFieldValuesSources, (qw(RT::CustomFieldValues::AnnounceGroups)));
             Set($ShowAnnouncementsInSelfService, 1); # display for selfservice home page too
+            Set(@AnnounceDefaultGroups, 'foo', 'bar'); # default groups on ticket creation
 
         or add "RT::Extension::Announce" to your existing @Plugins line.
 
@@ -84,6 +85,12 @@ CONFIGURATION
 
         Set($RTAnnounceQueue, 'Custom Announce Name');
 
+    By default, all the user defined groups will be listed in "Announcement
+    Groups", you can customize the group list by setting @AnnounceGroups in
+    your RT_SiteConfig.pm:
+
+        Set(@AnnounceGroups, 'foo', 'bar', 'baz');
+
     Then clear your mason cache and restart your server.
 
 AUTHOR

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list