[Bps-public-commit] smokingit-worker branch, master, updated. 70642b1b6fdcb6b3ebfee6ff1eb6a9d988a33755

Alex Vandiver alexmv at bestpractical.com
Fri Mar 28 13:39:50 EDT 2014


The branch, master has been updated
       via  70642b1b6fdcb6b3ebfee6ff1eb6a9d988a33755 (commit)
      from  788896dbdc0ceac7d278f05e03b5924c639bf8c0 (commit)

Summary of changes:
 lib/Smokingit/Worker.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 70642b1b6fdcb6b3ebfee6ff1eb6a9d988a33755
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Fri Mar 28 13:39:20 2014 -0400

    Calling on_failure does not ack the query
    
    The return value from the RPC call (via is_success) is ignored, in this
    case.  But calling on_failure does not ack the request, causing the
    worker to stall.

diff --git a/lib/Smokingit/Worker.pm b/lib/Smokingit/Worker.pm
index 8619eec..5494587 100644
--- a/lib/Smokingit/Worker.pm
+++ b/lib/Smokingit/Worker.pm
@@ -132,7 +132,7 @@ sub run_tests {
             args => $result
         );
         $cleanup->();
-        $args{on_failure}->( $result->{error} );
+        $args{on_success}->( $result->{error} );
     };
 
     # Check the SHA and check it out

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list