[Bps-public-commit] RT-Extension-CommandByMail branch, ignore-unknown-commands, repushed

Dustin Graves dustin at bestpractical.com
Mon Aug 22 18:04:25 EDT 2016


The branch ignore-unknown-commands was deleted and repushed:
       was 934a451a36d9c2280a32f90c51e55862f24ac858
       now 738799920a98fae4491ef19c82c35e8c3ac890d9

1:  934a451 ! 1:  7387999 remove error for unknown commands and add config setting $CommandByMailErrorOnUnknown to restore default behavior
    @@ -1,6 +1,6 @@
     Author: Dustin Graves <dustin at bestpractical.com>
     
    -    add config setting $CommandByMailSkipUnknown to suppress unknown command errors/crits
    +    remove error for unknown commands and add config setting $CommandByMailErrorOnUnknown to restore default behavior
     
     diff --git a/README b/README
     --- a/README
    @@ -9,10 +9,10 @@
          If set, the body will not be examined, only the header defined by the
          previous configuration option.
      
    -+  $CommandByMailSkipUnknown
    -+    Traditionally, this extension throws an error if it finds an unknown
    -+    command. Setting this will make CommandByMail silently skip them
    -+    instead.
    ++  $CommandByMailErrorOnUnknown
    ++    Prior to 2.02, this extension throws an error if it finds an unknown
    ++    command. This is no longer the case. Setting this option will restore
    ++    that legacy behavior.
     +
      CAVEATS
          This extension is incompatible with UnsafeEmailCommands RT option.
    @@ -25,10 +25,11 @@
      If set, the body will not be examined, only the header defined by the previous
      configuration option.
      
    -+=head2 C<$CommandByMailSkipUnknown>
    ++=head2 C<$CommandByMailErrorOnUnknown>
     +
    -+Traditionally, this extension throws an error if it finds an unknown command.
    -+Setting this will make CommandByMail silently skip them instead.
    ++Prior to 2.02, this extension throws an error if it finds an unknown command.
    ++This is no longer the case. Setting this option will restore that legacy
    ++behavior.
     +
      =head1 CAVEATS
      
    @@ -49,7 +50,7 @@
              return 1 if grep $cmd eq lc $_, @LINK_ATTRIBUTES, @WATCHER_ATTRIBUTES;
          }
      
    -+    return 2 if RT->Config->Get('CommandByMailSkipUnknown');
    ++    return 2 unless RT->Config->Get('CommandByMailErrorOnUnknown');
          return (0, "Command '$cmd' is unknown");
      }
      



More information about the Bps-public-commit mailing list