[Bps-public-commit] rt-extension-timetracking branch, master, updated. 8e9eddcfb0c34fae27386b24e894016f94c60580

Shawn Moore shawn at bestpractical.com
Wed Apr 12 13:54:09 EDT 2017


The branch, master has been updated
       via  8e9eddcfb0c34fae27386b24e894016f94c60580 (commit)
      from  733f9581b449d117d4b90c8360d48077423a91a8 (commit)

Summary of changes:
 .../RT-Extension-TimeTracking/Ticket/Elements/ShowBasics/EndOfList    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 8e9eddcfb0c34fae27386b24e894016f94c60580
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Wed Apr 12 13:54:06 2017 -0400

    Use idiomatic version check

diff --git a/html/Callbacks/RT-Extension-TimeTracking/Ticket/Elements/ShowBasics/EndOfList b/html/Callbacks/RT-Extension-TimeTracking/Ticket/Elements/ShowBasics/EndOfList
index 43ee5d6..57ae606 100644
--- a/html/Callbacks/RT-Extension-TimeTracking/Ticket/Elements/ShowBasics/EndOfList
+++ b/html/Callbacks/RT-Extension-TimeTracking/Ticket/Elements/ShowBasics/EndOfList
@@ -58,9 +58,7 @@ input#<% $cf_style %> {
 </tr>
 
 % # Render if less than RT 4.4.0, (which includes per user time)
-% $RT::VERSION =~ /(\d+)\.(\d+)\.(\d+)/;
-% my $version = ($1*1000+$2);
-% if ( ($version < 4004) && $TicketObj->TimeWorked ) {
+% if ( RT::Handle::cmp_version($RT::VERSION,'4.4.0') < 0 && $TicketObj->TimeWorked ) {
 <tr class="time worked">
     <td class="label"><&|/l&>Worked</&>:</td>
     <td>

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list