[Bps-public-commit] rt-authen-oauth2 branch, master, updated. 5000c5f6c16584a50b2009cb70fc5a347baa54cb

? sunnavy sunnavy at bestpractical.com
Sun Mar 25 17:02:22 EDT 2018


The branch, master has been updated
       via  5000c5f6c16584a50b2009cb70fc5a347baa54cb (commit)
       via  bdaf6835d4e1a8697ffe28e146bc089a1c17afe8 (commit)
      from  acfb7da0bc97622978e25c239d14ce85bc303067 (commit)

Summary of changes:
 html/Callbacks/OAuth/Elements/Login/Default | 2 +-
 lib/RT/Authen/OAuth2.pm                     | 8 ++++----
 lib/RT/Authen/OAuth2/Google.pm              | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

- Log -----------------------------------------------------------------
commit bdaf6835d4e1a8697ffe28e146bc089a1c17afe8
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Mar 26 04:57:45 2018 +0800

    Add WebPath for the auth2 login URL

diff --git a/html/Callbacks/OAuth/Elements/Login/Default b/html/Callbacks/OAuth/Elements/Login/Default
index 6696b3d..16edc4d 100644
--- a/html/Callbacks/OAuth/Elements/Login/Default
+++ b/html/Callbacks/OAuth/Elements/Login/Default
@@ -4,5 +4,5 @@ return unless RT->Config->Get('EnableOAuth2');
 <div class="button-row">
 % my $next_state = $session{NextPage}->{$ARGS{next} || ''};
 % $next_state = $next_state->{url} if ref $next_state;
-<span class="input"><a href="/NoAuth/OAuth<% $next_state ? "?next=$next_state" : "" %>"><img src="<% RT::Authen::OAuth2::IDPLoginButtonImage() %>" alt="<% loc('Log in using OAuth 2') %>" /></a></span>
+<span class="input"><a href="<%RT->Config->Get('WebPath')%>/NoAuth/OAuth<% $next_state ? "?next=$next_state" : "" %>"><img src="<% RT::Authen::OAuth2::IDPLoginButtonImage() %>" alt="<% loc('Log in using OAuth 2') %>" /></a></span>
 </div>

commit 5000c5f6c16584a50b2009cb70fc5a347baa54cb
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Mar 26 05:02:11 2018 +0800

    Fix POD syntax

diff --git a/lib/RT/Authen/OAuth2.pm b/lib/RT/Authen/OAuth2.pm
index e073e2d..7880a41 100644
--- a/lib/RT/Authen/OAuth2.pm
+++ b/lib/RT/Authen/OAuth2.pm
@@ -86,7 +86,7 @@ This is free software, licensed under:
 =cut
 
 
-=item C<RequestAuthorization()>
+=head2 C<RequestAuthorization()>
 
 =over 4
 
@@ -123,7 +123,7 @@ sub RequestAuthorization {
 }
 
 
-=item C<LogUserIn()>
+=head2 C<LogUserIn()>
 
 =over 4
 
@@ -229,7 +229,7 @@ sub LogUserIn {
 }
 
 
-=item C<IDPLoginButtonImage()>
+=head2 C<IDPLoginButtonImage()>
 
 =over 4
 
@@ -246,7 +246,7 @@ sub IDPLoginButtonImage {
     return RT->Config->Get('OAuthIDPs')->{$idp}->{LoginPageButton};
 }
 
-=item C<LogOutURL()>
+=head2 C<LogOutURL()>
 
 =over 4
 
diff --git a/lib/RT/Authen/OAuth2/Google.pm b/lib/RT/Authen/OAuth2/Google.pm
index 6bdba23..a75cfdc 100644
--- a/lib/RT/Authen/OAuth2/Google.pm
+++ b/lib/RT/Authen/OAuth2/Google.pm
@@ -13,7 +13,7 @@ RT::Authen::OAuth2::Google - Handler for Google OAuth2 logins
 
 =cut
 
-=item Example Metadata
+=head2 Example Metadata
 
 =over 4
 
@@ -34,7 +34,7 @@ Google returns something like this:
 =cut
 
 
-=item Configuring Google
+=head2 Configuring Google
 
 =over 4
 
@@ -61,7 +61,7 @@ B<Save> twice. The Google user interface is a bit finicky.
 =cut
 
 
-=item C<Metadata()>
+=head2 C<Metadata()>
 
 =over 4
 

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list