[Bps-public-commit] rtx-calendar branch, master, updated. 1.02-1-gb0c2363

? sunnavy sunnavy at bestpractical.com
Fri Jul 17 15:30:23 EDT 2020


The branch, master has been updated
       via  b0c2363d169ae408e2186a438d2d07bcbb384daf (commit)
      from  505d9a5f658670faeb75b917cd1d6fae8b4ae286 (commit)

Summary of changes:
 html/Callbacks/RTx-Calendar/Elements/Tabs/Privileged | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit b0c2363d169ae408e2186a438d2d07bcbb384daf
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Jul 18 03:23:30 2020 +0800

    Fix logic issue that any URL with Class param can pass the condition
    
    Luckily that as we have a second condition block to check "Chart" page
    menu, which appears on ticket search pages only, the issue doesn't break
    stuff.

diff --git a/html/Callbacks/RTx-Calendar/Elements/Tabs/Privileged b/html/Callbacks/RTx-Calendar/Elements/Tabs/Privileged
index 9862702..93e4e29 100644
--- a/html/Callbacks/RTx-Calendar/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTx-Calendar/Elements/Tabs/Privileged
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 <%INIT>
 
-if ( $Path =~ qr{^/Search/} && $Has_Query && !$DECODED_ARGS->{Class} || $DECODED_ARGS->{Class} eq 'RT::Tickets' ) {
+if ( $Path =~ qr{^/Search/} && $Has_Query && ( !$DECODED_ARGS->{Class} || $DECODED_ARGS->{Class} eq 'RT::Tickets' ) ) {
     if ( my $chart = PageMenu->child('chart') ) {
         $chart->add_after( 'calendar' => title => loc('Calendar'), path => "/Search/Calendar.html$Search_Args" );
     }

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list