<br><br><div><span class="gmail_quote">On 8/22/07, <b class="gmail_sendername">Jesse Vincent</b> <<a href="mailto:jesse@bestpractical.com">jesse@bestpractical.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style=""><div><span class="q"><blockquote type="cite"><div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div><div><span><blockquote type="cite">
<ol><li><span style="font-weight: bold;">Trunk change:</span> Add two new "pseudo-triggers" <span style="font-family: courier new,monospace;">before_any_set </span> and <span style="font-family: courier new,monospace;">
after_any_set</span>. Setting a <span style="font-family: courier new,monospace;">before_any_set</span> trigger would cause a <span style="font-family: courier new,monospace;"> before_set_X</span> trigger to be set for every column on the table. The
<span style="font-family: courier new,monospace;">after_any_set</span> trigger would do the same for <span style="font-family: courier new,monospace;"> after_set_X</span>. The virtual models branch would then add these triggers to any new column as they are created as well.
</li></ol></blockquote></span><div>I know I like #2. </div><div><br></div><div>after_set and before_set feel more natural than after_any_... </div></div></div></blockquote><div><br>I am not sure where the best place is to implement this one. It seems like it should be an override of add_trigger() in Jifty::DBI::Record, but since add_trigger() is directly imported into Jifty::DBI::Record from Jifty::DBI::Class::Trigger, that's a bit messy. I can do the messy solution, but if there's a better way, I'd rather do that instead if someone has a suggestion.
<br><br></div></div></blockquote></span><div>Why not just add another trigger to Jifty::DBI::Record? oh. also now Jifty::DBI can use the released Class::Trigger. 0.12 has all the features we added to the forked version.</div>
</div></div></blockquote><div><br>As in just add an additional call to call_trigger() for before_set and after_set to _set? I'm generally hesitant to making a change that could have such global affects for performance. If you don't think that's a problem, I don't have a problem with it.
<br></div><br></div><br>