[rt-commit] CVS commit: rt

[Jesse]

On Mon, May 22, 2000 at 05:24:13PM -0400, tobiasb at fsck.com wrote:
> 
> Module Name:	rt
> Committed By:	tobiasb
> Date:		Mon May 22 21:24:13 UTC 2000
> 
> Modified Files:
> 	rt/lib/RT: Ticket.pm
> 
> Log Message:
> I do use $Ticket->Subject (and other stuff as well) frequently when
> I'm editing Mason.  There is two issues;
> 
> 1) Things might look freaked if the ticket has no subject, i.e. Display.html
>
that can be fixed with an  
 
> 2) Things might get totally whacko if the subject contains HTML code.
> 
>

> I could ensure the "right" behaviour all the places by using
> HTML::Entities::encode (I've done it one place), and by always using
> $Subject||"(No subject)". 

One way to deal is to add that to create and make the Subject column 
not null.

> Anyway, I think it might be more
> appropriate to have a sub RT::Ticket::VerboseSubject and
> RT::Ticket::HTMLSubject.
>

What's VerboseSubject?  

I'd almost rather have an HTML::Mason::escape routine.

so we could do escape($Ticket->Subject)

 
> What do you think?
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.1.2.94 -r1.1.2.95 rt/lib/RT/Ticket.pm
> 
> 
> 
> _______________________________________________
> Rt-commit mailing list
> Rt-commit at lists.fsck.com
> http://lists.fsck.com/mailman/listinfo/rt-commit
> 

-- 
jesse reed vincent --- root at eruditorum.org --- jesse at fsck.com 
pgp keyprint: 50 41 9C 03 D0 BC BC C8 2C B9 77 26 6F E1 EB 91
-------------------------------------------------------------
"Bother," said Pooh, "Eeyore, ready two photon torpedoes and lock
phasers on the Heffalump, Piglet, meet me in transporter room three"