[Rt-commit] [svn] r775 - in rt/branches/rt-3.1: . lib/RT

jesse at pallas.eruditorum.org jesse at pallas.eruditorum.org
Thu Apr 29 22:17:24 EDT 2004


Author: jesse
Date: Thu Apr 29 22:17:23 2004
New Revision: 775

Modified:
   rt/branches/rt-3.1/   (props changed)
   rt/branches/rt-3.1/lib/RT/Transactions_Overlay.pm
Log:
 ----------------------------------------------------------------------
 r1395 at debian:  jesse | 2004-04-30T11:16:57.160412Z
 
 Fixing RT::Transactions to better honor the trnansaction ACLs
 
 ----------------------------------------------------------------------


Modified: rt/branches/rt-3.1/lib/RT/Transactions_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Transactions_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Transactions_Overlay.pm	Thu Apr 29 22:17:23 2004
@@ -68,11 +68,9 @@
  	
     my $Transaction = $self->SUPER::Next();
     if ((defined($Transaction)) and (ref($Transaction))) {
-	if ($Transaction->__Value('Type') =~ /^Comment/ && 
-	    $Transaction->TicketObj->CurrentUserHasRight('ShowTicketComments')) {
-	    return($Transaction);
-	} elsif ($Transaction->__Value('Type') !~ /^Comment/ && 
-		 $Transaction->TicketObj->CurrentUserHasRight('ShowTicket')) {
+    	# If the user can see the transaction's type, then they can 
+	#  see the transaction and we should hand it back.
+	if ($Transaction->Type) {
 	    return($Transaction);
 	}
 
@@ -89,24 +87,6 @@
 }
 # }}}
 
-=head2 example methods
-
-  Queue RT::Queue or Queue Id
-  Ticket RT::Ticket or Ticket Id
-
-
-LimitDate 
-  
-Type TRANSTYPE
-Field STRING
-OldValue OLDVAL
-NewValue NEWVAL
-Data DATA
-TimeTaken
-Actor USEROBJ/USERID
-ContentMatches STRING
-
-=cut
 
 
 1;


More information about the Rt-commit mailing list