[Rt-commit] r2117 - in DBIx-SearchBuilder/trunk: . SearchBuilder

[jesse at bestpractical.com]

Author: jesse
Date: Wed Jan 19 17:21:13 2005
New Revision: 2117

Modified:
   DBIx-SearchBuilder/trunk/   (props changed)
   DBIx-SearchBuilder/trunk/Changes
   DBIx-SearchBuilder/trunk/META.yml
   DBIx-SearchBuilder/trunk/SearchBuilder.pm
   DBIx-SearchBuilder/trunk/SearchBuilder/Record.pm
Log:
 r3889 at hualien:  jesse | 2005-01-19T18:03:50.382478Z
 Bumping to 1.21, fix for blob value corruption after update with oracle
 
 


Modified: DBIx-SearchBuilder/trunk/Changes
==============================================================================
--- DBIx-SearchBuilder/trunk/Changes	(original)
+++ DBIx-SearchBuilder/trunk/Changes	Wed Jan 19 17:21:13 2005
@@ -1,5 +1,8 @@
 Revision history for Perl extension DBIx::SearchBuilder.
 
+1.21
+    - Oracle LOB handling caused us to corrupt item values on update.
+
 1.20 Tue Jan 18 08:24:15 EST 2005
     - Minor test suite fixes from Ruslan.
 

Modified: DBIx-SearchBuilder/trunk/META.yml
==============================================================================
--- DBIx-SearchBuilder/trunk/META.yml	(original)
+++ DBIx-SearchBuilder/trunk/META.yml	Wed Jan 19 17:21:13 2005
@@ -1,5 +1,5 @@
 name: DBIx-SearchBuilder
-version: 1.20
+version: 1.21
 license: perl
 distribution_type: module
 build_requires:

Modified: DBIx-SearchBuilder/trunk/SearchBuilder.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder.pm	Wed Jan 19 17:21:13 2005
@@ -5,7 +5,7 @@
 use strict;
 use vars qw($VERSION);
 
-$VERSION = "1.20";
+$VERSION = "1.21";
 
 =head1 NAME
 

Modified: DBIx-SearchBuilder/trunk/SearchBuilder/Record.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder/Record.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder/Record.pm	Wed Jan 19 17:21:13 2005
@@ -740,6 +740,10 @@
     $args{'Table'}       = $self->Table();
     $args{'PrimaryKeys'} = { $self->PrimaryKeys() };
 
+    # The blob handling will destroy $args{'Value'}. But we assign
+    # that back to the object at the end. this works around that
+    my $unmunged_value = $args{'Value'};
+
     unless ( $self->_Handle->KnowsBLOBs ) {
         # Support for databases which don't deal with LOBs automatically
         my $ca = $self->_ClassAccessible();
@@ -771,7 +775,7 @@
         $self->Load( $self->Id );
     }
     else {
-        $self->{'values'}->{"$column"} = $args{'Value'};
+        $self->{'values'}->{"$column"} = $unmunged_value;
     }
     $ret->as_array( 1, "The new value has been set." );
     return ( $ret->return_value );