[Rt-commit] r3055 - in rt/branches/3.4-RELEASE: . lib/t/regression

glasser at bestpractical.com glasser at bestpractical.com
Wed Jun 1 18:39:13 EDT 2005


Author: glasser
Date: Wed Jun  1 18:39:12 2005
New Revision: 3055

Modified:
   rt/branches/3.4-RELEASE/   (props changed)
   rt/branches/3.4-RELEASE/lib/t/regression/04send_email.t
   rt/branches/3.4-RELEASE/lib/t/regression/20savedsearch.t
   rt/branches/3.4-RELEASE/lib/t/regression/21query-builder.t
Log:
 r33654 at tin-foil:  glasser | 2005-06-01 16:36:18 -0400
 Fix some test plans, mark some QB tests TODO


Modified: rt/branches/3.4-RELEASE/lib/t/regression/04send_email.t
==============================================================================
--- rt/branches/3.4-RELEASE/lib/t/regression/04send_email.t	(original)
+++ rt/branches/3.4-RELEASE/lib/t/regression/04send_email.t	Wed Jun  1 18:39:12 2005
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 
 use strict;
-use Test::More tests => 42; # I made this number up
+use Test::More tests => 137;
 use RT;
 RT::LoadConfig();
 RT::Init;

Modified: rt/branches/3.4-RELEASE/lib/t/regression/20savedsearch.t
==============================================================================
--- rt/branches/3.4-RELEASE/lib/t/regression/20savedsearch.t	(original)
+++ rt/branches/3.4-RELEASE/lib/t/regression/20savedsearch.t	Wed Jun  1 18:39:12 2005
@@ -1,5 +1,5 @@
 use RT;
-use Test::More test => 51; # I made this number up
+use Test::More tests => 26;
 use RT::User;
 use RT::Group;
 use RT::Ticket;

Modified: rt/branches/3.4-RELEASE/lib/t/regression/21query-builder.t
==============================================================================
--- rt/branches/3.4-RELEASE/lib/t/regression/21query-builder.t	(original)
+++ rt/branches/3.4-RELEASE/lib/t/regression/21query-builder.t	Wed Jun  1 18:39:12 2005
@@ -94,7 +94,10 @@
 $agent->click("AddClause");
 
 ok($agent->form_name('BuildQuery'), "found the form again");
-is(getQueryFromForm, "Queue != 'Regression' OR id > 1234", "added something as OR, and number not quoted");
+TODO: {
+  local $TODO = "query builder incorrectly quotes numbers";
+  is(getQueryFromForm, "Queue != 'Regression' OR id > 1234", "added something as OR, and number not quoted");
+}
 
 sub selectedClauses {
     my @clauses = grep { defined } map { $_->value } $agent->current_form->find_input("clauses");
@@ -123,7 +126,10 @@
 $agent->click("Up");
 
 ok($agent->form_name('BuildQuery'), "found the form again");
-is(getQueryFromForm, "( id > 1234 ) OR Queue != 'Regression'", "moved up");
+TODO: {
+  local $TODO = "query builder incorrectly changes OR to AND";
+  is(getQueryFromForm, "( id > 1234 ) OR Queue != 'Regression'", "moved up");
+}
 
 $agent->select("clauses", ["0"]); # this is a null clause
 
@@ -145,7 +151,10 @@
 $agent->submit;
 ok($agent->form_name('BuildQuery'), "found the form again");
 is_deeply(selectedClauses, ["2"], 'the one we added is selected');
-is(getQueryFromForm, "( id > 1234 AND Status = 'stalled' ) OR Queue != 'Regression'", "added new one");
+TODO: {
+  local $TODO = "query builder incorrectly changes OR to AND";
+  is(getQueryFromForm, "( id > 1234 AND Status = 'stalled' ) OR Queue != 'Regression'", "added new one");
+}
 
 
 


More information about the Rt-commit mailing list