[Rt-commit] r4045 - in Jifty-DBI/trunk: . lib/Jifty/DBI

jesse at bestpractical.com jesse at bestpractical.com
Sun Nov 6 19:21:28 EST 2005


Author: jesse
Date: Sun Nov  6 19:21:27 2005
New Revision: 4045

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
Log:
 r18432 at truegrounds:  jesse | 2005-11-06 19:17:47 -0500
 LowerCasing of QueryString


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	Sun Nov  6 19:21:27 2005
@@ -589,12 +589,12 @@
 
     if ( !$self->{'fetched'}{ $column->name } and my $id = $self->id() ) {
         my $pkey        = $self->_primary_key();
-        my $QueryString = "SELECT "
+        my $query_string = "SELECT "
             . $column->name
             . " FROM "
             . $self->table
             . " WHERE $pkey = ?";
-        my $sth = $self->_handle->simple_query( $QueryString, $id );
+        my $sth = $self->_handle->simple_query( $query_string, $id );
         my ($value) = eval { $sth->fetchrow_array() };
         warn $@ if $@;
 
@@ -856,11 +856,11 @@
         }
     }
 
-    my $QueryString = "SELECT  * FROM "
+    my $query_string = "SELECT  * FROM "
         . $self->table
         . " WHERE "
         . join( ' AND ', @phrases );
-    return ( $self->_load_from_sql( $QueryString, @bind ) );
+    return ( $self->_load_from_sql( $query_string, @bind ) );
 }
 
 =head2 load_by_primary_keys 
@@ -908,10 +908,10 @@
 
 sub _load_from_sql {
     my $self        = shift;
-    my $QueryString = shift;
+    my $query_string = shift;
     my @bind_values = (@_);
 
-    my $sth = $self->_handle->simple_query( $QueryString, @bind_values );
+    my $sth = $self->_handle->simple_query( $query_string, @bind_values );
 
     #TODO this only gets the first row. we should check if there are more.
 
@@ -1025,8 +1025,8 @@
     }
 
     $where =~ s/AND\s$//;
-    my $QueryString = "DELETE FROM " . $self->table . ' ' . $where;
-    my $return      = $self->_handle->simple_query( $QueryString, @bind );
+    my $query_string = "DELETE FROM " . $self->table . ' ' . $where;
+    my $return      = $self->_handle->simple_query( $query_string, @bind );
 
     if ( UNIVERSAL::isa( 'Class::ReturnValue', $return ) ) {
         return ($return);


More information about the Rt-commit mailing list