[Rt-commit] r3877 - in rt/branches/3.4-RELEASE: . lib/RT

alexmv at bestpractical.com alexmv at bestpractical.com
Thu Sep 22 15:09:23 EDT 2005


Author: alexmv
Date: Thu Sep 22 15:09:22 2005
New Revision: 3877

Modified:
   rt/branches/3.4-RELEASE/   (props changed)
   rt/branches/3.4-RELEASE/lib/RT/CustomField_Overlay.pm
   rt/branches/3.4-RELEASE/lib/RT/EmailParser.pm
   rt/branches/3.4-RELEASE/lib/RT/Link_Overlay.pm
   rt/branches/3.4-RELEASE/lib/RT/ObjectCustomFieldValues_Overlay.pm
   rt/branches/3.4-RELEASE/lib/RT/Queue_Overlay.pm
   rt/branches/3.4-RELEASE/lib/RT/Record.pm
   rt/branches/3.4-RELEASE/lib/RT/Ticket_Overlay.pm
   rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm
   rt/branches/3.4-RELEASE/lib/RT/Transactions_Overlay.pm
Log:
 r6458 at zoq-fot-pik:  chmrr | 2005-09-22 15:08:37 -0400
  * Add where the faulty caller was in deprecated warnings


Modified: rt/branches/3.4-RELEASE/lib/RT/CustomField_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/CustomField_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/CustomField_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -461,7 +461,7 @@
 	my $self = shift;
     my $ticket_id = shift;
     
-    $RT::Logger->debug( ref($self) . " -> ValuesForTicket deprecated in favor of ValuesForObject"); 
+    $RT::Logger->debug( ref($self) . " -> ValuesForTicket deprecated in favor of ValuesForObject at (". join(":",caller).")"); 
     my $ticket = RT::Ticket->new($self->CurrentUser);
     $ticket->Load($ticket_id);
 
@@ -485,7 +485,7 @@
 	my %args = ( Ticket => undef,
                  Content => undef,
 		     @_ );
-    $RT::Logger->debug( ref($self) . " -> AddValueForTicket deprecated in favor of AddValueForObject"); 
+    $RT::Logger->debug( ref($self) . " -> AddValueForTicket deprecated in favor of AddValueForObject at (". join(":",caller).")");
 
 
     my $ticket = RT::Ticket->new($self->CurrentUser);
@@ -513,7 +513,7 @@
                  Content => undef,
 		     @_ );
 
-    $RT::Logger->debug( ref($self) . " -> DeleteValueForTicket deprecated in favor of DeleteValueForObject"); 
+    $RT::Logger->debug( ref($self) . " -> DeleteValueForTicket deprecated in favor of DeleteValueForObject at (". join(":",caller).")"); 
 
 
     my $ticket = RT::Ticket->new($self->CurrentUser);
@@ -615,7 +615,7 @@
     my $type = shift;
 
     if ($type =~ s/(?:Single|Multiple)$//) {
-	$RT::Logger->warning( "Prefix 'Single' and 'Multiple' to Type deprecated, use MaxValues instead");
+	$RT::Logger->warning( "Prefix 'Single' and 'Multiple' to Type deprecated, use MaxValues instead at (". join(":",caller).")");
     }
 
     if( $FieldTypes{$type}) {
@@ -631,7 +631,7 @@
     my $self = shift;
     my $type = shift;
     if ($type =~ s/(?:(Single)|Multiple)$//) {
-	warn "'Single' and 'Multiple' on SetType deprecated, use SetMaxValues instead";
+	$RT::Logger->warning("'Single' and 'Multiple' on SetType deprecated, use SetMaxValues instead at (". join(":",caller).")");
 	$self->SetMaxValues($1 ? 1 : 0);
     }
     $self->SUPER::SetType($type);
@@ -738,19 +738,19 @@
 # }}}
 
 sub Queue {
-    $RT::Logger->debug( ref($_[0]) . " -> Queue deprecated");
+    $RT::Logger->debug( ref($_[0]) . " -> Queue deprecated at (". join(":",caller).")");
     
     return 0;
 }
 
 sub SetQueue {
-    $RT::Logger->debug( ref($_[0]) . " -> SetQueue deprecated");
+    $RT::Logger->debug( ref($_[0]) . " -> SetQueue deprecated at (". join(":",caller).")");
 
     return 0;
 }
 
 sub QueueObj {
-    $RT::Logger->debug( ref($_[0]) . " -> QueueObj deprecated");
+    $RT::Logger->debug( ref($_[0]) . " -> QueueObj deprecated at (". join(":",caller).")");
 
     return undef;
 }

Modified: rt/branches/3.4-RELEASE/lib/RT/EmailParser.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/EmailParser.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/EmailParser.pm	Thu Sep 22 15:09:22 2005
@@ -277,7 +277,7 @@
 
 sub ParseTicketId {
     my $self = shift;
-    $RT::Logger->warnings("RT::EmailParser->ParseTicketId deprecated. You should be using RT::Interface::Email");
+    $RT::Logger->warnings("RT::EmailParser->ParseTicketId deprecated. You should be using RT::Interface::Email at (". join(":",caller).")");
 
     require RT::Interface::Email;
     RT::Interface::Email::ParseTicketId(@_);

Modified: rt/branches/3.4-RELEASE/lib/RT/Link_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Link_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Link_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -315,7 +315,7 @@
 
 sub BaseIsLocal {
   my $self = shift;
-  $RT::Logger->crit("Link::BaseIsLocal is deprecated in favor of Link->BaseURI->IsLocal");
+  $RT::Logger->crit("Link::BaseIsLocal is deprecated in favor of Link->BaseURI->IsLocal at (". join(":",caller).")");
   return $self->BaseURI->IsLocal;
 }
 
@@ -331,7 +331,7 @@
 
 sub TargetIsLocal {
   my $self = shift;
-  $RT::Logger->crit("Link::BaseIsLocal is deprecated in favor of Link->BaseURI->IsLocal");
+  $RT::Logger->crit("Link::BaseIsLocal is deprecated in favor of Link->BaseURI->IsLocal at (". join(":",caller).")");
   return $self->TargetURI->IsLocal;
 }
 
@@ -348,7 +348,7 @@
 
 sub BaseAsHREF {
   my $self = shift;
-  $RT::Logger->crit("Link::BaseAsHREF deprecated in favor of ->BaseURI->AsHREF");
+  $RT::Logger->crit("Link::BaseAsHREF deprecated in favor of ->BaseURI->AsHREF at (". join(":",caller).")");
   return $self->BaseURI->HREF;
 }
 # }}}
@@ -363,7 +363,7 @@
 
 sub TargetAsHREF {
   my $self = shift;
-  $RT::Logger->crit("Link::TargetAsHREF deprecated in favor of ->TargetURI->AsHREF");
+  $RT::Logger->crit("Link::TargetAsHREF deprecated in favor of ->TargetURI->AsHREF at (". join(":",caller).")");
   return $self->TargetURI->HREF;
 }
 # }}}

Modified: rt/branches/3.4-RELEASE/lib/RT/ObjectCustomFieldValues_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/ObjectCustomFieldValues_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/ObjectCustomFieldValues_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -80,7 +80,7 @@
     my $ticket = shift;
 
 
-    $RT::Logger->warning(ref($self) . " -> LimitToTicket deprecated in favor of LimitToObject");
+    $RT::Logger->warning(ref($self) . " -> LimitToTicket deprecated in favor of LimitToObject at (". join(":",caller).")");
 
     $self->Limit( FIELD => 'ObjectType',
 		  VALUE => 'RT::Ticket',

Modified: rt/branches/3.4-RELEASE/lib/RT/Queue_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Queue_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Queue_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -521,7 +521,7 @@
 
 sub CustomFields {
     my $self = shift;
-    warn "Queue->CustomFields is deprecated, use Queue->TicketCustomFields instead";
+    warn "Queue->CustomFields is deprecated, use Queue->TicketCustomFields instead at (". join(":",caller).")";
     return $self->TicketCustomFields(@_);
 }
 

Modified: rt/branches/3.4-RELEASE/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Record.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Record.pm	Thu Sep 22 15:09:22 2005
@@ -1545,8 +1545,7 @@
 #TODO Deprecated API. Destroy in 3.6
 sub _LookupTypes { 
     my  $self = shift;
-    $RT::Logger->warning("_LookupTypes call is deprecated. Replace with CustomFieldLookupType");
-    $RT::Logger->warning("Besides, it was a private API. Were you doing using it?");
+    $RT::Logger->warning("_LookupTypes call is deprecated at (". join(":",caller)."). Replace with CustomFieldLookupType");
 
     return($self->CustomFieldLookupType);
 

Modified: rt/branches/3.4-RELEASE/lib/RT/Ticket_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Ticket_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Ticket_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -3239,7 +3239,7 @@
 
 sub Kill {
     my $self = shift;
-    $RT::Logger->crit("'Kill' is deprecated. use 'Delete' instead.");
+    $RT::Logger->crit("'Kill' is deprecated. use 'Delete' instead at (". join(":",caller).").");
     return $self->Delete;
 }
 

Modified: rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -1819,10 +1819,7 @@
 sub LimitRequestor {
     my $self = shift;
     my %args = (@_);
-    my ( $package, $filename, $line ) = caller;
-    $RT::Logger->error(
-"Tickets->LimitRequestor is deprecated. please rewrite call at  $package - $filename: $line"
-    );
+    $RT::Logger->error("Tickets->LimitRequestor is deprecated  at (". join(":",caller).")");
     $self->LimitWatcher( TYPE => 'Requestor', @_ );
 
 }

Modified: rt/branches/3.4-RELEASE/lib/RT/Transactions_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Transactions_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Transactions_Overlay.pm	Thu Sep 22 15:09:22 2005
@@ -100,7 +100,7 @@
 	my %args = (@_);
 
 	if ($args{'FIELD'} eq 'Ticket') {
-		Carp::cluck("Historical code calling RT::Transactions::Limit with a 'Ticket'.  This deprecated API will be deleted in 3.6");
+		Carp::cluck("Historical code calling RT::Transactions::Limit with a 'Ticket' at (". join(":",caller).").  This deprecated API will be deleted in 3.6");
 		$self->SUPER::Limit(FIELD => 'ObjectType', OPERATOR => '=', VALUE =>'RT::Ticket');
 		$args{'FIELD'} = 'ObjectId';
 		$self->SUPER::Limit(%args);


More information about the Rt-commit mailing list