[Rt-commit] r8280 - rt/branches/3.6-RELEASE/lib/t/regression

ruz at bestpractical.com ruz at bestpractical.com
Wed Jul 25 10:34:39 EDT 2007


Author: ruz
Date: Wed Jul 25 10:34:34 2007
New Revision: 8280

Modified:
   rt/branches/3.6-RELEASE/lib/t/regression/22search_tix_by_watcher.t

Log:
* mark only one query as todo instead of many which really should pass

Modified: rt/branches/3.6-RELEASE/lib/t/regression/22search_tix_by_watcher.t
==============================================================================
--- rt/branches/3.6-RELEASE/lib/t/regression/22search_tix_by_watcher.t	(original)
+++ rt/branches/3.6-RELEASE/lib/t/regression/22search_tix_by_watcher.t	Wed Jul 25 10:34:34 2007
@@ -40,10 +40,7 @@
 
         my $count = 0;
         $count++ foreach grep $_, values %{ $test{$key} };
-        TODO: { 
-            local $TODO = "we can't generate this query yet";
-            is($tix->Count, $count, "found correct number of ticket(s) by '$key'") or $error = 1;
-            };
+        is($tix->Count, $count, "found correct number of ticket(s) by '$key'") or $error = 1;
 
         my $good_tickets = 1;
         while ( my $ticket = $tix->Next ) {
@@ -77,7 +74,8 @@
     'Requestor IS NULL'            => { xy => 0, x => 0, y => 0, '-' => 1, z => 0 },
     'Requestor IS NOT NULL'        => { xy => 1, x => 1, y => 1, '-' => 0, z => 1 },
 
-    'Requestor = "x at example.com" AND Requestor = "y at example.com"'   => { xy => 1, x => 0, y => 0, '-' => 0, z => 0 },
+# this test is a todo, we run it later
+#    'Requestor = "x at example.com" AND Requestor = "y at example.com"'   => { xy => 1, x => 0, y => 0, '-' => 0, z => 0 },
     'Requestor = "x at example.com" OR Requestor = "y at example.com"'    => { xy => 1, x => 1, y => 1, '-' => 0, z => 0 },
 
     'Requestor != "x at example.com" AND Requestor != "y at example.com"' => { xy => 0, x => 0, y => 0, '-' => 1, z => 1 },
@@ -97,6 +95,15 @@
 }
 run_tests();
 
+TODO: {
+    local $TODO = "we can't generate this query yet";
+    %test = (
+        'Requestor = "x at example.com" AND Requestor = "y at example.com"'
+            => { xy => 1, x => 0, y => 0, '-' => 0, z => 0 },
+    );
+    run_tests();
+}
+
 @data = (
     { Subject => 'xy', Cc => ['x at example.com'], Requestor => [ 'y at example.com' ] },
     { Subject => 'x-', Cc => ['x at example.com'], Requestor => [] },


More information about the Rt-commit mailing list