[Rt-commit] r11721 - rt/branches/3.8-TESTING/lib/RT

sunnavy at bestpractical.com sunnavy at bestpractical.com
Mon Apr 14 05:53:21 EDT 2008


Author: sunnavy
Date: Mon Apr 14 05:53:20 2008
New Revision: 11721

Modified:
   rt/branches/3.8-TESTING/lib/RT/Handle.pm

Log:
return something for InsertData

Modified: rt/branches/3.8-TESTING/lib/RT/Handle.pm
==============================================================================
--- rt/branches/3.8-TESTING/lib/RT/Handle.pm	(original)
+++ rt/branches/3.8-TESTING/lib/RT/Handle.pm	Mon Apr 14 05:53:20 2008
@@ -969,6 +969,11 @@
     $RT::Handle->Disconnect() unless $db_type eq 'SQLite';
 
     $RT::Logger->debug("Done setting up database content.");
+
+# TODO is it ok to return 1 here? If so, the previous codes in this sub
+# should return (0, $msg) if error happens instead of just warning.
+# anyway, we need to return something here to tell if everything is ok
+    return( 1, 'Done inserting data' );
 }
 
 =head2 ACLEquivGroupId


More information about the Rt-commit mailing list