[Rt-commit] r15250 - in rt/branches/3.999-DANGEROUS: lib/RT lib/RT/Model lib/RT/ScripAction

jesse at bestpractical.com jesse at bestpractical.com
Tue Aug 19 18:03:55 EDT 2008


Author: jesse
Date: Tue Aug 19 18:03:55 2008
New Revision: 15250

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroupAsComment.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm

Log:
 r43687 at jesse-vincents-macbook-air:  jesse | 2008-08-19 18:02:48 -0400
 * camel case fixes


Modified: rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Condition.pm	Tue Aug 19 18:03:55 2008
@@ -54,9 +54,9 @@
 
     use RT::Condition;
     my $foo = RT::Condition->new( 
-		TransactionObj => $tr, 
-		TicketObj => $ti, 
-		ScripObj => $scr, 
+		transaction_obj => $tr, 
+		ticket_obj => $ti, 
+		scrip_obj => $scr, 
 		Argument => $arg, 
 		Type => $type);
 
@@ -135,9 +135,9 @@
 
 # }}}
 
-# {{{ sub TicketObj
+# {{{ sub ticket_obj
 
-=head2 TicketObj
+=head2 ticket_obj
 
 Return the ticket object we're talking about
 
@@ -150,9 +150,9 @@
 
 # }}}
 
-# {{{ sub ScripObj
+# {{{ sub scrip_obj
 
-=head2 ScripObj
+=head2 scrip_obj
 
 Return the Scrip object we're talking about
 
@@ -164,9 +164,9 @@
 }
 
 # }}}
-# {{{ sub TransactionObj
+# {{{ sub transaction_obj
 
-=head2 TransactionObj
+=head2 transaction_obj
 
 Return the transaction object we're talking about
 
@@ -198,7 +198,7 @@
 
 #What does this type of Action does
 
-# {{{ sub Describe
+# {{{ sub describe
 sub describe {
     my $self = shift;
     return ( $self->loc( "No description for %1", ref $self ) );
@@ -210,7 +210,7 @@
 
 #If this rule applies to this transaction, return true.
 
-# {{{ sub IsApplicable
+# {{{ sub is_applicable
 sub is_applicable {
     my $self = shift;
     return (undef);

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm	Tue Aug 19 18:03:55 2008
@@ -151,7 +151,7 @@
 
 =head2 describe 
 
-Helper method to call the condition module\'s Describe method.
+Helper method to call the condition module's describe method.
 
 =cut
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	Tue Aug 19 18:03:55 2008
@@ -2964,7 +2964,7 @@
                 subclause        => 'acl',
                 column           => 'type',
                 operator         => '!=',
-                value            => "commentEmailRecord",
+                value            => "CommentEmailRecord",
                 entry_aggregator => 'AND'
             );
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm	Tue Aug 19 18:03:55 2008
@@ -814,7 +814,7 @@
 }
 
 %_brief_descriptions = (
-    commentEmailRecord => sub {
+    CommentEmailRecord => sub {
         my $self = shift;
         return _("Outgoing email about a comment recorded");
     },
@@ -1108,7 +1108,7 @@
         unless ( $self->current_user_has_right('ShowTicketcomments') ) {
             return 0;
         }
-    } elsif ( $type eq 'commentEmailRecord' ) {
+    } elsif ( $type eq 'CommentEmailRecord' ) {
         unless ( $self->current_user_has_right('ShowTicketcomments')
             && $self->current_user_has_right('ShowOutgoingEmail') )
         {
@@ -1281,7 +1281,7 @@
     "RT::Model::Queue-RT::Model::Ticket-RT::Model::Transaction";
 }
 
-=item DeferredRecipients($freq, $include_sent )
+=item deferred_recipients($freq, $include_sent )
 
 Takes the following arguments:
 
@@ -1300,7 +1300,7 @@
 
 =cut
 
-sub DeferredRecipients {
+sub deferred_recipients {
     my $self         = shift;
     my $freq         = shift;
     my $include_sent = @_ ? shift : 0;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction.pm	Tue Aug 19 18:03:55 2008
@@ -86,11 +86,11 @@
     my %args = (
         Argument       => undef,
         CurrentUser    => undef,
-        ScripActionObj => undef,
-        ScripObj       => undef,
-        TemplateObj    => undef,
-        TicketObj      => undef,
-        TransactionObj => undef,
+        scrip_action_obj => undef,
+        scrip_obj       => undef,
+        template_obj    => undef,
+        ticket_obj      => undef,
+        transaction_obj => undef,
         Type           => undef,
 
         @_
@@ -98,18 +98,18 @@
 
     $self->{'Argument'} = $args{'Argument'};
     $self->current_user( $args{'CurrentUser'} );
-    $self->{'ScripActionObj'} = $args{'ScripActionObj'};
-    $self->{'ScripObj'}       = $args{'ScripObj'};
-    $self->{'TemplateObj'}    = $args{'TemplateObj'};
-    $self->{'TicketObj'}      = $args{'TicketObj'};
-    $self->{'TransactionObj'} = $args{'TransactionObj'};
+    $self->{'scrip_action_obj'} = $args{'scrip_action_obj'};
+    $self->{'scrip_obj'}       = $args{'scrip_obj'};
+    $self->{'template_obj'}    = $args{'template_obj'};
+    $self->{'ticket_obj'}      = $args{'ticket_obj'};
+    $self->{'transaction_obj'} = $args{'transaction_obj'};
     $self->{'Type'}           = $args{'Type'};
 
-    Scalar::Util::weaken( $self->{'ScripActionObj'} );
-    Scalar::Util::weaken( $self->{'ScripObj'} );
-    Scalar::Util::weaken( $self->{'TemplateObj'} );
-    Scalar::Util::weaken( $self->{'TicketObj'} );
-    Scalar::Util::weaken( $self->{'TransactionObj'} );
+    Scalar::Util::weaken( $self->{'scrip_action_obj'} );
+    Scalar::Util::weaken( $self->{'scrip_obj'} );
+    Scalar::Util::weaken( $self->{'template_obj'} );
+    Scalar::Util::weaken( $self->{'ticket_obj'} );
+    Scalar::Util::weaken( $self->{'transaction_obj'} );
 
 }
 
@@ -125,42 +125,42 @@
 
 # }}}
 
-# {{{ sub TicketObj
-sub TicketObj {
+# {{{ sub ticket_obj
+sub ticket_obj {
     my $self = shift;
-    return ( $self->{'TicketObj'} );
+    return ( $self->{'ticket_obj'} );
 }
 
 # }}}
 
-# {{{ sub TransactionObj
-sub TransactionObj {
+# {{{ sub transaction_obj
+sub transaction_obj {
     my $self = shift;
-    return ( $self->{'TransactionObj'} );
+    return ( $self->{'transaction_obj'} );
 }
 
 # }}}
 
-# {{{ sub TemplateObj
-sub TemplateObj {
+# {{{ sub template_obj
+sub template_obj {
     my $self = shift;
-    return ( $self->{'TemplateObj'} );
+    return ( $self->{'template_obj'} );
 }
 
 # }}}
 
-# {{{ sub ScripObj
-sub ScripObj {
+# {{{ sub scrip_obj
+sub scrip_obj {
     my $self = shift;
-    return ( $self->{'ScripObj'} );
+    return ( $self->{'scrip_obj'} );
 }
 
 # }}}
 
-# {{{ sub ScripActionObj
-sub ScripActionObj {
+# {{{ sub scrip_action_obj
+sub scrip_action_obj {
     my $self = shift;
-    return ( $self->{'ScripActionObj'} );
+    return ( $self->{'scrip_action_obj'} );
 }
 
 # }}}
@@ -187,8 +187,8 @@
 
 #What does this type of Action does
 
-# {{{ sub Describe
-sub Describe {
+# {{{ sub describe
+sub describe {
     my $self = shift;
     return $self->loc( "No description for %1", ref $self );
 }
@@ -197,8 +197,8 @@
 
 #Parse the templates, get things ready to go.
 
-# {{{ sub Prepare
-sub Prepare {
+# {{{ sub prepare
+sub prepare {
     my $self = shift;
     return ( 0, $self->loc("Prepare Stubbed") );
 }
@@ -207,8 +207,8 @@
 
 #If this rule applies to this transaction, return true.
 
-# {{{ sub IsApplicable
-sub IsApplicable {
+# {{{ sub is_applicable
+sub is_applicable {
     my $self = shift;
     return (undef);
 }
@@ -221,10 +221,10 @@
 
     # We need to clean up all the references that might maybe get
     # oddly circular
-    $self->{'ScripActionObj'} = undef;
-    $self->{'ScripObj'}       = undef;
-    $self->{'TemplateObj'}    = undef $self->{'TicketObj'} = undef;
-    $self->{'TransactionObj'} = undef;
+    $self->{'scrip_action_obj'} = undef;
+    $self->{'scrip_obj'}       = undef;
+    $self->{'template_obj'}    = undef $self->{'ticket_obj'} = undef;
+    $self->{'transaction_obj'} = undef;
 }
 
 # }}}

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/ExtractSubjectTag.pm	Tue Aug 19 18:03:55 2008
@@ -50,12 +50,12 @@
 use base 'RT::ScripAction';
 use strict;
 
-sub Describe {
+sub describe {
     my $self = shift;
     return ( ref $self );
 }
 
-sub Prepare {
+sub prepare {
     return (1);
 }
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/LinearEscalate.pm	Tue Aug 19 18:03:55 2008
@@ -146,13 +146,13 @@
 
 #What does this type of Action does
 
-sub Describe {
+sub describe {
     my $self = shift;
     my $class = ref($self) || $self;
     return "$class will move a ticket's priority toward its final priority.";
 }
 
-sub Prepare {
+sub prepare {
     my $self = shift;
 
     my $ticket = $self->ticket_obj;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroup.pm	Tue Aug 19 18:03:55 2008
@@ -70,13 +70,13 @@
 
 =head1 METHODS
 
-=head2 SetRecipients
+=head2 set_recipients
 
 Sets the recipients of this message to Groups and/or Users.
 
 =cut
 
-sub SetRecipients {
+sub set_recipients {
     my $self = shift;
 
     my $arg = $self->argument;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroupAsComment.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroupAsComment.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/NotifyGroupAsComment.pm	Tue Aug 19 18:03:55 2008
@@ -66,10 +66,10 @@
 
 use base qw(RT::ScripAction::NotifyGroup);
 
-sub SetReturnAddress {
+sub set_return_address {
     my $self = shift;
     $self->{'comment'} = 1;
-    return $self->SUPER::SetReturnAddress( @_, is_comment => 1 );
+    return $self->SUPER::set_return_address( @_, is_comment => 1 );
 }
 
 =head1 AUTHOR

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/SendEmail.pm	Tue Aug 19 18:03:55 2008
@@ -507,7 +507,7 @@
 
     my $type;
     if ( $self->transaction_obj->type eq 'comment' ) {
-        $type = 'commentEmailRecord';
+        $type = 'CommentEmailRecord';
     } else {
         $type = 'EmailRecord';
     }


More information about the Rt-commit mailing list