[Rt-commit] r10673 - in rt/branches/3.999-DANGEROUS: lib/RT lib/RT/Model lib/RT/ScripAction

[jesse at bestpractical.com]

Author: jesse
Date: Sat Feb  2 00:54:07 2008
New Revision: 10673

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Record.pm
   rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm

Log:
 r76091 at pinglin:  jesse | 2008-02-02 00:39:19 -0500
 * fix a bunch of warnings that happened because txn creators weren't set
 r76096 at pinglin:  jesse | 2008-02-02 00:53:06 -0500
 * made AutoOpen actually work


Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm	Sat Feb  2 00:54:07 2008
@@ -1018,6 +1018,7 @@
     } elsif ( $principal =~ /^\d+$/ ) {
         $id = $principal;
     } else {
+        Carp::cluck;
         Jifty->log->error(
                   "Group::has_member was called with an argument that"
                 . " isn't an RT::Model::Principal or id. It's $principal" );

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Transaction.pm	Sat Feb  2 00:54:07 2008
@@ -299,7 +299,6 @@
 
     #if we didn't specify a ticket, we need to bail
     unless ( $args{'object_id'} && $args{'object_type'} ) {
-        Carp::cluck();
         return (
             0,
             _(  "Transaction->create couldn't, as you didn't specify an object type and id"

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Record.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Record.pm	Sat Feb  2 00:54:07 2008
@@ -270,8 +270,8 @@
         }
     }
 
-    $attribs{'Creator'} ||= $self->current_user->id
-        if $self->can('Creator') && $self->current_user;
+    $attribs{'creator'} ||= $self->current_user->id
+        if $self->can('creator') && $self->current_user;
 
     my $now = RT::Date->new( current_user => $self->current_user );
     $now->set( format => 'unix', value => time );

Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm	Sat Feb  2 00:54:07 2008
@@ -85,9 +85,9 @@
     my $self = shift;
 
     my $oldstatus = $self->ticket_obj->status;
-    $self->ticket_obj->__set( column => 'Status', value => 'open' );
+    $self->ticket_obj->__set( column => 'status', value => 'open' );
     $self->ticket_obj->_new_transaction(
-        type      => 'Status',
+        type      => 'status',
         field     => 'Status',
         old_value => $oldstatus,
         new_value => 'open',