[Rt-commit] r10685 - in rt/branches/3.999-DANGEROUS: html html/Elements html/Search html/Search/Elements lib/RT/Model
ruz at bestpractical.com
ruz at bestpractical.com
Sun Feb 3 03:16:49 EST 2008
Author: ruz
Date: Sun Feb 3 03:16:48 2008
New Revision: 10685
Modified:
rt/branches/3.999-DANGEROUS/html/Elements/QuickCreate
rt/branches/3.999-DANGEROUS/html/Elements/SelectNewTicketQueue
rt/branches/3.999-DANGEROUS/html/Elements/SelectQueue
rt/branches/3.999-DANGEROUS/html/Elements/SelectTimezone
rt/branches/3.999-DANGEROUS/html/Search/Build.html
rt/branches/3.999-DANGEROUS/html/Search/Elements/ConditionRow
rt/branches/3.999-DANGEROUS/html/Search/Elements/PickBasics
rt/branches/3.999-DANGEROUS/html/index.html
rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm
rt/branches/3.999-DANGEROUS/t/web/basic.t
rt/branches/3.999-DANGEROUS/t/web/cf_access.t
rt/branches/3.999-DANGEROUS/t/web/custom_frontpage.t
rt/branches/3.999-DANGEROUS/t/web/query_builder.t
rt/branches/3.999-DANGEROUS/t/web/rights1.t
Log:
* more updates
Modified: rt/branches/3.999-DANGEROUS/html/Elements/QuickCreate
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Elements/QuickCreate (original)
+++ rt/branches/3.999-DANGEROUS/html/Elements/QuickCreate Sun Feb 3 03:16:48 2008
@@ -48,15 +48,15 @@
<div class="quick-create">
<&| /Widgets/TitleBox, title => _('Quick ticket creation') &>
<form method="post" action="<%RT->config->get('WebPath')%>/index.html">
-<input type="hidden" class="hidden" name="QuickCreate" value="1" />
+<input type="hidden" class="hidden" name="quick_create" value="1" />
<table>
<tr><td>
<&|/l&>subject</&>:<br /><input size="15" name="subject" />
</td><td>
-<&|/l&>Queue</&>:<br /><& /Elements/SelectNewTicketQueue, name => 'queue', ShowNullOption => 0 &>
+<&|/l&>Queue</&>:<br /><& /Elements/SelectNewTicketQueue, name => 'queue', show_null_option => 0 &>
</td><td>
<&|/l&>Owner</&>:<br />
-<select type="select" name="Owner">
+<select type="select" name="owner">
<option value="<%Jifty->web->current_user->id%>" selected><%Jifty->web->current_user->name %></option>
<option value="<%RT->nobody->id%>"><%_('Nobody')%></option>
</select>
Modified: rt/branches/3.999-DANGEROUS/html/Elements/SelectNewTicketQueue
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Elements/SelectNewTicketQueue (original)
+++ rt/branches/3.999-DANGEROUS/html/Elements/SelectNewTicketQueue Sun Feb 3 03:16:48 2008
@@ -46,5 +46,5 @@
%#
%# END BPS TAGGED BLOCK }}}
<label accesskey="9">
- <& /Elements/SelectQueue, name => 'queue', %ARGS, ShowNullOption => 0, ShowAllQueues => 0 &>
+ <& /Elements/SelectQueue, name => 'queue', %ARGS, show_null_option => 0, ShowAllQueues => 0 &>
</label>
Modified: rt/branches/3.999-DANGEROUS/html/Elements/SelectQueue
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Elements/SelectQueue (original)
+++ rt/branches/3.999-DANGEROUS/html/Elements/SelectQueue Sun Feb 3 03:16:48 2008
@@ -52,7 +52,7 @@
% }
% else {
<select name="<%$name%>">
-% if ($ShowNullOption) {
+% if ($show_null_option) {
<option value="">-</option>
% }
% for my $queue (@{$session{$cache_key}}) {
@@ -68,7 +68,7 @@
% }
<%args>
$CheckQueueRight => 'CreateTicket'
-$ShowNullOption => 1
+$show_null_option => 1
$ShowAllQueues => 1
$name => undef
$Verbose => undef
Modified: rt/branches/3.999-DANGEROUS/html/Elements/SelectTimezone
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Elements/SelectTimezone (original)
+++ rt/branches/3.999-DANGEROUS/html/Elements/SelectTimezone Sun Feb 3 03:16:48 2008
@@ -54,7 +54,7 @@
<imput type="text" name="<% $name %>" value="<% $Default %>" />
% }
<select name="<% $name %>">
-% if ( $ShowNullOption ) {
+% if ( $show_null_option ) {
<option value=""><&|/l&>System Default</&></option>
% }
% foreach my $tz (@names) {
@@ -62,7 +62,7 @@
% }
</select>
<%ARGS>
-$ShowNullOption => 1
+$show_null_option => 1
$name => undef
$Default => 0
</%ARGS>
Modified: rt/branches/3.999-DANGEROUS/html/Search/Build.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Search/Build.html (original)
+++ rt/branches/3.999-DANGEROUS/html/Search/Build.html Sun Feb 3 03:16:48 2008
@@ -185,7 +185,7 @@
# {{{ Try to find if we're adding a clause
foreach my $arg ( keys %ARGS ) {
- next unless $arg =~ m/^ValueOf(\w+|'CF.{.*?}')$/
+ next unless $arg =~ m/^value_of_(\w+|'CF.{.*?}')$/
&& ( ref $ARGS{$arg} eq "ARRAY"
? grep $_ ne '', @{ $ARGS{$arg} }
: $ARGS{$arg} ne '' );
@@ -196,18 +196,18 @@
my ($op, $value);
#figure out if it's a grouping
- my $keyword = $ARGS{ $field . "Field" } || $field;
+ my $keyword = $ARGS{ $field . "_field" } || $field;
my ( @ops, @values );
- if ( ref $ARGS{ 'ValueOf' . $field } eq "ARRAY" ) {
+ if ( ref $ARGS{ 'value_of_' . $field } eq "ARRAY" ) {
# we have many keys/values to iterate over, because there is
# more than one CF with the same name.
- @ops = @{ $ARGS{ $field . 'Op' } };
- @values = @{ $ARGS{ 'ValueOf' . $field } };
+ @ops = @{ $ARGS{ $field . '_op' } };
+ @values = @{ $ARGS{ 'value_of_' . $field } };
}
else {
- @ops = ( $ARGS{ $field . 'Op' } );
- @values = ( $ARGS{ 'ValueOf' . $field } );
+ @ops = ( $ARGS{ $field . '_op' } );
+ @values = ( $ARGS{ 'value_of_' . $field } );
}
Jifty->log->error("Bad Parameters passed into Query Builder")
unless @ops == @values;
Modified: rt/branches/3.999-DANGEROUS/html/Search/Elements/ConditionRow
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Search/Elements/ConditionRow (original)
+++ rt/branches/3.999-DANGEROUS/html/Search/Elements/ConditionRow Sun Feb 3 03:16:48 2008
@@ -46,15 +46,15 @@
%#
%# END BPS TAGGED BLOCK }}}
<tr>
-<td class="label"><% $handle_block->( $Condition->{'Field'}, $Condition->{'name'} .'Field' ) |n %></td>
-<td class="operator"><% $handle_block->( $Condition->{'Op'}, $Condition->{'name'} .'Op') |n %></td>
-<td class="value"><% $handle_block->( $Condition->{'Value'}, 'ValueOf'. $Condition->{'name'} ) |n %></td>
+<td class="label"><% $handle_block->( $condition->{'field'}, $condition->{'name'} .'_field' ) |n %></td>
+<td class="operator"><% $handle_block->( $condition->{'op'}, $condition->{'name'} .'_op') |n %></td>
+<td class="value"><% $handle_block->( $condition->{'value'}, 'value_of_'. $condition->{'name'} ) |n %></td>
</tr>
<%INIT>
-return unless $Condition && $Condition->{'name'};
+return unless $condition && $condition->{'name'};
-$m->callback( Condition => \$Condition );
-return unless $Condition;
+$m->callback( Condition => \$condition );
+return unless $condition;
my $handle_block;
$handle_block = sub {
@@ -70,20 +70,21 @@
return undef unless UNIVERSAL::isa($box, 'HASH');
if ( $box->{'type'} eq 'component' ) {
- $box->{'Arguments'} ||= {},
- return $m->scomp( $box->{'Path'}, %{ $box->{'Arguments'} }, name => $name );
+ $box->{'arguments'} ||= {},
+ return $m->scomp( $box->{'path'}, %{ $box->{'arguments'} }, name => $name );
}
if ( $box->{'type'} eq 'text' ) {
- my $default = $box->{'Default'} || '';
- my $size = $box->{'Size'}? qq{size="$box->{'Size'}"} : '';
+ my $default = $box->{'default'} || '';
+ my $size = $box->{'size'}? qq{size="$box->{'Size'}"} : '';
return qq{<input name="$name" value="$default" $size />};
}
if ( $box->{'type'} eq 'select' ) {
my $res = '';
$res .= qq{<select name="$name">};
- my @options = @{ $box->{'Options'} };
+ my @options = @{ $box->{'options'} };
while( my $k = shift @options ) {
my $v = shift @options;
+ # BUG, FIXME, TODO: html-escape $v
$res .= qq{<option value="$k">$v</option>};
}
$res .= qq{</select>};
@@ -93,5 +94,5 @@
</%INIT>
<%ARGS>
-$Condition => {}
+$condition => {}
</%ARGS>
Modified: rt/branches/3.999-DANGEROUS/html/Search/Elements/PickBasics
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Search/Elements/PickBasics (original)
+++ rt/branches/3.999-DANGEROUS/html/Search/Elements/PickBasics Sun Feb 3 03:16:48 2008
@@ -46,163 +46,163 @@
%#
%# END BPS TAGGED BLOCK }}}
% foreach( @lines ) {
-<& ConditionRow, Condition => $_ &>
+<& ConditionRow, condition => $_ &>
% }
<%INIT>
my @lines = (
{
name => 'id',
- Field => _('id'),
- Op => {
+ field => _('id'),
+ op => {
type => 'component',
- Path => '/Elements/SelectEqualityOperator',
+ path => '/Elements/SelectEqualityOperator',
},
- Value => { type => 'text', Size => 5 }
+ value => { type => 'text', Size => 5 }
},
{
- name => 'Attachment',
- Field => {
+ name => 'attachment',
+ field => {
type => 'component',
- Path => '/Elements/SelectAttachmentField',
+ path => '/Elements/SelectAttachmentField',
},
- Op => {
+ op => {
type => 'component',
- Path => '/Elements/SelectBoolean',
- Arguments => {
+ path => '/Elements/SelectBoolean',
+ arguments => {
True => _("matches"),
False => _("does not match"),
TrueVal => 'LIKE',
FalseVal => 'NOT LIKE',
},
},
- Value => { type => 'text', Size => 20 },
+ value => { type => 'text', Size => 20 },
},
{
name => 'queue',
- Field => _('queue'),
- Op => {
+ field => _('queue'),
+ op => {
type => 'component',
- Path => '/Elements/SelectBoolean',
- Arguments => { TrueVal=> '=', FalseVal => '!=' },
+ path => '/Elements/SelectBoolean',
+ arguments => { TrueVal=> '=', FalseVal => '!=' },
},
- Value => {
+ value => {
type => 'component',
- Path => '/Elements/SelectQueue',
- Arguments => { named_values => 1, CheckQueueRight => 'ShowTicket' },
+ path => '/Elements/SelectQueue',
+ arguments => { named_values => 1, CheckQueueRight => 'ShowTicket' },
},
},
{
- name => 'Status',
- Field => _('Status'),
- Op => {
+ name => 'status',
+ field => _('Status'),
+ op => {
type => 'component',
- Path => '/Elements/SelectBoolean',
- Arguments => { TrueVal=> '=', FalseVal => '!=' },
+ path => '/Elements/SelectBoolean',
+ arguments => { TrueVal=> '=', FalseVal => '!=' },
},
- Value => {
+ value => {
type => 'component',
- Path => '/Elements/SelectStatus',
- Arguments => { SkipDeleted => 1 },
+ path => '/Elements/SelectStatus',
+ arguments => { SkipDeleted => 1 },
},
},
{
- name => 'Actor',
- Field => {
+ name => 'actor',
+ field => {
type => 'select',
- Options => [
- Owner => _('Owner'),
- Creator => _('Creator'),
- LastUpdatedBy => _('Last updated by'),
+ options => [
+ owner => _('Owner'),
+ creator => _('Creator'),
+ last_updated_by => _('Last updated by'),
],
},
- Op => {
+ op => {
type => 'component',
- Path => '/Elements/SelectBoolean',
- Arguments => { TrueVal=> '=', FalseVal => '!=' },
+ path => '/Elements/SelectBoolean',
+ arguments => { TrueVal=> '=', FalseVal => '!=' },
},
- Value => {
+ value => {
type => 'component',
- Path => '/Elements/SelectOwner',
- Arguments => { value_attribute => 'name' },
+ path => '/Elements/SelectOwner',
+ arguments => { value_attribute => 'name' },
},
},
{
- name => 'Watcher',
- Field => {
+ name => 'watcher',
+ field => {
type => 'component',
- Path => 'SelectPersonType',
- Arguments => { Default => 'Requestor' },
+ path => 'SelectPersonType',
+ arguments => { Default => 'Requestor' },
},
- Op => {
+ op => {
type => 'component',
- Path => '/Elements/SelectMatch',
+ path => '/Elements/SelectMatch',
},
- Value => { type => 'text', Size => 20 }
+ value => { type => 'text', Size => 20 }
},
{
name => 'date',
- Field => {
+ field => {
type => 'component',
- Path => '/Elements/SelectDateType',
+ path => '/Elements/SelectDateType',
},
- Op => {
+ op => {
type => 'component',
- Path => '/Elements/SelectDateRelation',
+ path => '/Elements/SelectDateRelation',
},
- Value => {
+ value => {
type => 'component',
- Path => '/Elements/SelectDate',
- Arguments => { ShowTime => 0, Default => '' },
+ path => '/Elements/SelectDate',
+ arguments => { ShowTime => 0, Default => '' },
},
},
{
name => 'Time',
- Field => {
+ field => {
type => 'select',
- Options => [
+ options => [
time_worked => _('Time Worked'),
time_estimated => _('Time Estimated'),
time_left => _('Time Left'),
],
},
- Op => {
+ op => {
type => 'component',
- Path => '/Elements/SelectEqualityOperator',
+ path => '/Elements/SelectEqualityOperator',
},
- Value => [
+ value => [
{ type => 'text', Size => 5 },
{
type => 'component',
- Path => '/Elements/SelectTimeUnits',
+ path => '/Elements/SelectTimeUnits',
},
],
},
{
name => 'Priority',
- Field => {
+ field => {
type => 'select',
- Options => [
- Priority => _('Priority'),
+ options => [
+ priority => _('Priority'),
initial_priority => _('Initial Priority'),
final_priority => _('Final Priority'),
],
},
- Op => {
+ op => {
type => 'component',
- Path => '/Elements/SelectEqualityOperator',
+ path => '/Elements/SelectEqualityOperator',
},
- Value => { type => 'text', Size => 5 }
+ value => { type => 'text', Size => 5 }
},
{
name => 'Links',
- Field => { type => 'component', Path => 'SelectLinks' },
- Op => {
+ field => { type => 'component', path => 'SelectLinks' },
+ op => {
type => 'component',
- Path => '/Elements/SelectBoolean',
- Arguments => { TrueVal=> '=', FalseVal => '!=' },
+ path => '/Elements/SelectBoolean',
+ arguments => { TrueVal=> '=', FalseVal => '!=' },
},
- Value => { type => 'text', Size => 5 }
+ value => { type => 'text', Size => 5 }
},
);
Modified: rt/branches/3.999-DANGEROUS/html/index.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/index.html (original)
+++ rt/branches/3.999-DANGEROUS/html/index.html Sun Feb 3 03:16:48 2008
@@ -83,10 +83,10 @@
my @results;
-if ( $ARGS{'QuickCreate'} ) {
+if ( $ARGS{'quick_create'} ) {
my $ticket = RT::Model::Ticket->new();
my ($tid, $trans, $tmsg) = $ticket->create(queue => $ARGS{'queue'},
- Owner => $ARGS{'Owner'},
+ owner => $ARGS{'owner'},
Requestor => Jifty->web->current_user->id,
subject => $ARGS{'subject'});
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/ScripCondition.pm Sun Feb 3 03:16:48 2008
@@ -83,8 +83,8 @@
column exec_module => type is 'text';
column argument => type is 'text';
column applicable_trans_types => type is 'text';
- column Creator => max_length is 11, type is 'int(11)', default is '0';
- column Created => type is 'datetime', default is '';
+ column creator => max_length is 11, type is 'int(11)', default is '0';
+ column created => type is 'datetime', default is '';
column
last_updated_by => max_length is 11,
type is 'int(11)', default is '0';
Modified: rt/branches/3.999-DANGEROUS/t/web/basic.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/basic.t (original)
+++ rt/branches/3.999-DANGEROUS/t/web/basic.t Sun Feb 3 03:16:48 2008
@@ -35,7 +35,7 @@
$agent->submit();
is($agent->{'status'}, 200, "Fetched the page ok");
ok( $agent->content =~ /Logout/i, "Found a logout link");
-$agent->get($url."Ticket/Create.html?Queue=1");
+$agent->get($url."Ticket/Create.html?queue=1");
is ($agent->{'status'}, 200, "Loaded Create.html");
$agent->form_number(3);
# Start with a string containing characters in latin1
@@ -48,7 +48,7 @@
ok($agent->{redirected_uri}, "Did redirection");
-$agent->get($url."Ticket/Create.html?Queue=1");
+$agent->get($url."Ticket/Create.html?queue=1");
is ($agent->{'status'}, 200, "Loaded Create.html");
$agent->form_number(3);
# Start with a string containing characters in latin1
@@ -86,16 +86,16 @@
# set the first value
ok($agent->form_name('BuildQuery'));
-$agent->field("AttachmentField", "subject");
-$agent->field("AttachmentOp", "LIKE");
-$agent->field("ValueOfAttachment", "aaa");
+$agent->field("attachment_field", "subject");
+$agent->field("attachment_op", "LIKE");
+$agent->field("value_of_attachment", "aaa");
$agent->submit("AddClause");
# set the next value
ok($agent->form_name('BuildQuery'));
-$agent->field("AttachmentField", "subject");
-$agent->field("AttachmentOp", "LIKE");
-$agent->field("ValueOfAttachment", "bbb");
+$agent->field("attachment_field", "subject");
+$agent->field("attachment_op", "LIKE");
+$agent->field("value_of_attachment", "bbb");
$agent->submit("AddClause");
ok($agent->form_name('BuildQuery'));
Modified: rt/branches/3.999-DANGEROUS/t/web/cf_access.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/cf_access.t (original)
+++ rt/branches/3.999-DANGEROUS/t/web/cf_access.t Sun Feb 3 03:16:48 2008
@@ -44,7 +44,7 @@
# Sort by numeric IDs in names
my @names = map { $_->[1] }
sort { $a->[0] <=> $b->[0] }
- map { /Object-1-CF-(\d+)/ ? [ $1 => $_ ] : () }
+ map { /object-1-CF-(\d+)/ ? [ $1 => $_ ] : () }
grep defined, map $_->name, $m->current_form->inputs;
$cf = pop(@names);
$cf =~ /(\d+)$/ or die "Hey this is impossible dude";
@@ -166,9 +166,9 @@
$m->submit_form(
form_name => "BuildQuery",
fields => {
- idOp => '=',
- ValueOfid => $tid,
- ValueOfQueue => 'General',
+ id_op => '=',
+ value_of_id => $tid,
+ value_of_queue => 'General',
},
button => 'AddClause',
);
Modified: rt/branches/3.999-DANGEROUS/t/web/custom_frontpage.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/custom_frontpage.t (original)
+++ rt/branches/3.999-DANGEROUS/t/web/custom_frontpage.t Sun Feb 3 03:16:48 2008
@@ -25,7 +25,7 @@
#create a saved search
$m->form_name ('BuildQuery');
-$m->field ( "ValueOfAttachment" => 'stupid');
+$m->field ( "value_of_attachment" => 'stupid');
$m->field ( "SavedSearchdescription" => 'stupid tickets');
$m->click_button (name => 'SavedSearchSave');
Modified: rt/branches/3.999-DANGEROUS/t/web/query_builder.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/query_builder.t (original)
+++ rt/branches/3.999-DANGEROUS/t/web/query_builder.t Sun Feb 3 03:16:48 2008
@@ -47,20 +47,20 @@
diag "add the first condition" if $ENV{'TEST_VERBOSE'};
{
ok $agent->form_name('BuildQuery'), "found the form once";
- $agent->field("ActorField", "Owner");
- $agent->field("ActorOp", "=");
- $agent->field("ValueOfActor", 'Nobody');
+ $agent->field("actor_field", "owner");
+ $agent->field("actor_op", "=");
+ $agent->field("value_of_actor", 'Nobody');
$agent->submit;
- is get_query_from_form, "Owner = 'Nobody'", 'correct query';
+ is lc get_query_from_form, lc "Owner = 'Nobody'", 'correct query';
}
diag "set the next condition" if $ENV{'TEST_VERBOSE'};
{
ok($agent->form_name('BuildQuery'), "found the form again");
- $agent->field("QueueOp", "!=");
- $agent->field("ValueOfQueue", "Regression");
+ $agent->field("queue_op", "!=");
+ $agent->field("value_of_queue", "Regression");
$agent->submit;
- is get_query_from_form, "Owner = 'Nobody' AND queue != 'Regression'",
+ is get_query_from_form, "owner = 'Nobody' AND queue != 'Regression'",
'correct query';
}
@@ -69,17 +69,17 @@
$agent->select("clauses", ["0"] );
$agent->click("DeleteClause");
ok $agent->form_name('BuildQuery'), "found the form";
- is get_query_from_form, "Queue != 'Regression'", 'correct query';
+ is get_query_from_form, "queue != 'Regression'", 'correct query';
}
diag "add a cond with OR and se number by the way" if $ENV{'TEST_VERBOSE'};
{
$agent->field("AndOr", "OR");
- $agent->select("idOp", ">");
- $agent->field("ValueOfid" => "1234");
+ $agent->select("id_op", ">");
+ $agent->field("value_of_id" => "1234");
$agent->click("AddClause");
ok $agent->form_name('BuildQuery'), "found the form again";
- is get_query_from_form, "Queue != 'Regression' OR id > 1234",
+ is get_query_from_form, "queue != 'Regression' OR id > 1234",
"added something as OR, and number not quoted";
is_deeply selected_clauses, ["1"], 'the id that we just entered is still selected';
@@ -95,9 +95,9 @@
diag "Move the second one right" if $ENV{'TEST_VERBOSE'};
{
- $agent->click("right");
+ $agent->click("Right");
ok $agent->form_name('BuildQuery'), "found the form again";
- is get_query_from_form, "Queue != 'Regression' OR ( id > 1234 )",
+ is get_query_from_form, "queue != 'Regression' OR ( id > 1234 )",
"moved over to the right (and down)";
is_deeply selected_clauses, ["2"], 'the one we moved right is selected';
}
@@ -132,7 +132,7 @@
diag "Add a condition into a nested block" if $ENV{'TEST_VERBOSE'};
{
$agent->select("clauses", ["1"]);
- $agent->select("ValueOfStatus" => "stalled");
+ $agent->select("value_of_status" => "stalled");
$agent->submit;
ok $agent->form_name('BuildQuery'), "found the form again";
is_deeply selected_clauses, ["2"], 'the one we added is only selected';
@@ -150,7 +150,7 @@
$agent->field("Query", "Status = 'new' OR ( Status = 'open' AND subject LIKE 'office' )");
$agent->submit;
is( get_query_from_form,
- "Status = 'new' OR ( Status = 'open' AND subject LIKE 'office' )",
+ "status = 'new' OR ( status = 'open' AND subject LIKE 'office' )",
"no aggregators change"
);
}
@@ -238,11 +238,11 @@
$agent->field("Query", "( Status = 'new' OR Status = 'open' )");
$agent->submit;
is( get_query_from_form,
- "( Status = 'new' OR Status = 'open' )",
+ "( status = 'new' OR status = 'open' )",
"query is the same"
);
$agent->select("clauses", [qw(0 1 2)]);
- $agent->field( ValueOfid => 10 );
+ $agent->field( value_of_id => 10 );
$agent->click("DeleteClause");
is( get_query_from_form,
Modified: rt/branches/3.999-DANGEROUS/t/web/rights1.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/rights1.t (original)
+++ rt/branches/3.999-DANGEROUS/t/web/rights1.t Sun Feb 3 03:16:48 2008
@@ -106,7 +106,7 @@
$agent->reload();
ok($agent->form_name('BuildQuery'), "Yep, form is still there");
-my $input = $agent->current_form->find_input('ValueOfActor');
+my $input = $agent->current_form->find_input('value_of_actor');
ok(grep(/customer-$$/, $input->value_names()), "Found self in the actor listing");
die join(',',$input->value_names);
More information about the Rt-commit
mailing list