[Rt-commit] r10709 - in rt/branches/3.999-DANGEROUS: html/Elements/GnuPG html/SelfService html/Ticket html/Ticket/Elements lib/RT lib/RT/Interface

ruz at bestpractical.com ruz at bestpractical.com
Sun Feb 3 22:20:51 EST 2008


Author: ruz
Date: Sun Feb  3 22:20:50 2008
New Revision: 10709

Modified:
   rt/branches/3.999-DANGEROUS/html/Elements/GnuPG/SignEncryptWidget
   rt/branches/3.999-DANGEROUS/html/SelfService/Display.html
   rt/branches/3.999-DANGEROUS/html/Ticket/Create.html
   rt/branches/3.999-DANGEROUS/html/Ticket/Elements/PreviewScrips
   rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html
   rt/branches/3.999-DANGEROUS/html/Ticket/Update.html
   rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Test.pm
   rt/branches/3.999-DANGEROUS/t/web/gnupg-outgoing.t
   rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-create.t

Log:
* variouse updates to fix t/web/gnupg-outgoing.t

Modified: rt/branches/3.999-DANGEROUS/html/Elements/GnuPG/SignEncryptWidget
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Elements/GnuPG/SignEncryptWidget	(original)
+++ rt/branches/3.999-DANGEROUS/html/Elements/GnuPG/SignEncryptWidget	Sun Feb  3 22:20:50 2008
@@ -64,7 +64,7 @@
 <%METHOD Check>
 <%ARGS>
 $self      => undef
-$Operation => 'update'
+$operation => 'update'
 $ticket_obj => undef
 $queue_obj  => undef
 </%ARGS>
@@ -95,7 +95,7 @@
 
     my @recipients;
 
-    if ( $Operation eq 'update' ) {
+    if ( $operation eq 'update' ) {
         # skip any email addresses that we won't be sending mail to
         my %squelch = $m->comp(
             '/Ticket/Elements/PreviewScrips:SquelchRecipients',
@@ -108,14 +108,14 @@
             %$self, ticket_obj => $ticket_obj
         );
     }
-    elsif ( $Operation eq 'create' ) {
+    elsif ( $operation eq 'create' ) {
         @recipients = $m->comp(
             '/Ticket/Elements/PreviewScrips:GetRecipientsOnCreate',
             %$self,
         );
     }
     else {
-        Jifty->log->fatal('Incorrect operation: '. $Operation );
+        Jifty->log->fatal('Incorrect operation: '. $operation );
     }
 
     my %seen;

Modified: rt/branches/3.999-DANGEROUS/html/SelfService/Display.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/SelfService/Display.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/SelfService/Display.html	Sun Feb  3 22:20:50 2008
@@ -111,8 +111,7 @@
 
     my $attachment = make_mime_entity(
         subject             => $subject,
-        Body                => "",
-        AttachmentFieldname => 'Attach'
+        AttachmentFieldname => 'Attach',
     );
 
     $session{'Attachments'} =

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/Create.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/Create.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/Create.html	Sun Feb  3 22:20:50 2008
@@ -70,7 +70,7 @@
 <td class="label"><&|/l&>Status</&>:
 </td>
 <td class="value">
-<& /Elements/SelectStatus, name => "Status", Default => $ARGS{Status}||'new', DefaultValue => 0 &>
+<& /Elements/SelectStatus, name => "status", Default => $ARGS{status}||'new', DefaultValue => 0 &>
 </td>
 <td class="label">
 <&|/l&>Owner</&>:
@@ -84,7 +84,7 @@
 <&|/l&>Requestors</&>:
 </td>
 <td class="value" colspan="5">
-    <input name="Requestors" value="<% ($ARGS{Requestors}) || Jifty->web->current_user->user_object->email %>" size="40" />
+    <input name="requestors" value="<% ($ARGS{requestors}) || Jifty->web->current_user->user_object->email %>" size="40" />
 </td>
 </tr>
 <tr>
@@ -257,7 +257,7 @@
     
     $clone->{$_} = $cloneticket_obj->$_() 
         for qw/owner subject final_priority time_estimated TimeWorked 
-                Status TimeLeft Starts Started Due Resolved/;
+                status TimeLeft Starts Started Due Resolved/;
     
         my $members = $cloneticket_obj->members;
         my ( @members, @members_of, @refers, @refers_by, @depends, @depends_by );
@@ -358,7 +358,6 @@
 
     my $attachment = make_mime_entity(
         subject             => $subject,
-        Body                => "",
         AttachmentFieldname => 'Attach'
     );
 

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/Elements/PreviewScrips
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/Elements/PreviewScrips	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/Elements/PreviewScrips	Sun Feb  3 22:20:50 2008
@@ -125,7 +125,7 @@
 
 my $Message = make_mime_entity(
     subject => $ARGS{'Updatesubject'},
-    Body    => $ARGS{'update_content'},
+    body    => $ARGS{'update_content'},
 );
 
 my ( $Transaction, $description, $object ) = $ticket_obj->$action(
@@ -161,7 +161,7 @@
 
 my $Message = make_mime_entity(
     subject => $ARGS{'Updatesubject'},
-    Body    => $ARGS{'update_content'},
+    body    => $ARGS{'update_content'},
 );
 
 my ( $id, $msg, $txn ) = $ticket_obj->$action(
@@ -194,8 +194,8 @@
 my $action;
 my $Message = make_mime_entity(
     subject => $ARGS{'subject'},
-    Cc => $ARGS{'Cc'},
-    Body    => $ARGS{'content'},
+    cc => $ARGS{'cc'},
+    body    => $ARGS{'content'},
 );
 
 my $ticket_obj = RT::Model::Ticket->new();

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html	Sun Feb  3 22:20:50 2008
@@ -176,7 +176,6 @@
 
         my $attachment = make_mime_entity(
            subject             => $subject,
-           Body                => "",
            AttachmentFieldname => 'UpdateAttachment'
         );
         delete $ARGS{'UpdateAttachment'};

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/Update.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/Update.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/Update.html	Sun Feb  3 22:20:50 2008
@@ -218,8 +218,7 @@
     $subject =~ s#^.*[\\/]##;
 
     my $attachment = make_mime_entity(
-        Filename             => $subject,
-        Body                => "",
+        filename             => $subject,
         AttachmentFieldname => 'Attach'
     );
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web.pm	Sun Feb  3 22:20:50 2008
@@ -276,15 +276,15 @@
     }
 
     my $due = RT::Date->new();
-    $due->set( format => 'unknown', value => $ARGS{'Due'} );
+    $due->set( format => 'unknown', value => $ARGS{'due'} );
     my $starts = RT::Date->new();
     $starts->set( format => 'unknown', value => $ARGS{'starts'} );
 
     my $mime_obj = make_mime_entity(
         subject => $ARGS{'subject'},
-        From    => $ARGS{'From'},
+        from    => $ARGS{'From'},
         cc      => $ARGS{'cc'},
-        Body    => $ARGS{'content'},
+        body    => $ARGS{'content'},
         type    => $ARGS{'content_type'},
     );
 
@@ -322,8 +322,8 @@
         time_estimated   => $ARGS{'time_estimated'},
         time_worked      => $ARGS{'time_worked'},
         subject          => $ARGS{'subject'},
-        Status           => $ARGS{'Status'},
-        Due              => $due->iso,
+        status           => $ARGS{'status'},
+        due              => $due->iso,
         starts           => $starts->iso,
         mime_obj          => $mime_obj
     );
@@ -526,7 +526,7 @@
 
     my $Message = make_mime_entity(
         subject => $args{args_ref}->{'Updatesubject'},
-        Body    => $args{args_ref}->{'update_content'},
+        body    => $args{args_ref}->{'update_content'},
         type    => $args{args_ref}->{'Updatecontent_type'},
     );
 
@@ -629,24 +629,24 @@
     #TODO document what else this takes.
     my %args = (
         subject             => undef,
-        From                => undef,
+        from                => undef,
         cc                  => undef,
-        Body                => undef,
+        body                => undef,
         AttachmentFieldname => undef,
         type                => undef,
         @_,
     );
     my $Message = MIME::Entity->build(
         Type    => 'multipart/mixed',
-        subject => $args{'subject'} || "",
-        From    => $args{'From'},
-        cc      => $args{'cc'},
+        Subject => $args{'subject'} || "",
+        From    => $args{'from'},
+        Cc      => $args{'cc'},
     );
 
-    if ( defined $args{'Body'} && length $args{'Body'} ) {
+    if ( defined $args{'body'} && length $args{'body'} ) {
 
         # Make the update content have no 'weird' newlines in it
-        $args{'Body'} =~ s/\r\n/\n/gs;
+        $args{'body'} =~ s/\r\n/\n/gs;
 
         # MIME::Head is not happy in utf-8 domain.  This only happens
         # when processing an incoming email (so far observed).
@@ -655,7 +655,7 @@
         $Message->attach(
             Type => $args{'type'} || 'text/plain',
             Charset => 'UTF-8',
-            Data    => $args{'Body'},
+            Data    => $args{'body'},
         );
     }
 

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Test.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Test.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Test.pm	Sun Feb  3 22:20:50 2008
@@ -51,7 +51,7 @@
         $mailsent++;
         return 1;
     };
-    RT::Config->set( 'MailCommand' => $mailfunc );
+    RT->config->set( 'MailCommand' => $mailfunc );
 }
 our $server_url;
 

Modified: rt/branches/3.999-DANGEROUS/t/web/gnupg-outgoing.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/gnupg-outgoing.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/web/gnupg-outgoing.t	Sun Feb  3 22:20:50 2008
@@ -253,7 +253,7 @@
     $m->goto_create_ticket( $queue );
     $m->form_name('TicketCreate');
     $m->field( subject    => 'test' );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content    => 'Some content' );
 
     foreach ( qw(sign encrypt) ) {

Modified: rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-create.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-create.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/web/gnupg-select-keys-on-create.t	Sun Feb  3 22:20:50 2008
@@ -50,7 +50,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( sign => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->submit;
     $m->content_like(
@@ -76,7 +76,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( encrypt => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->submit;
     $m->content_like(
@@ -111,7 +111,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( encrypt => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->submit;
     $m->content_like(
@@ -158,7 +158,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( encrypt => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->submit;
     $m->content_like(
@@ -203,7 +203,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( encrypt => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->submit;
     $m->content_like(
@@ -230,7 +230,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( encrypt => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->submit;
     $m->content_like(
@@ -262,7 +262,7 @@
     ok $m->goto_create_ticket( $queue ), "UI -> create ticket";
     $m->form_number(3);
     $m->tick( encrypt => 1 );
-    $m->field( Requestors => 'rt-test at example.com' );
+    $m->field( requestors => 'rt-test at example.com' );
     $m->field( content => 'Some content' );
     $m->field( Attach => $0 );
     $m->submit;


More information about the Rt-commit mailing list