[Rt-commit] r10592 - in rt/branches/3.999-DANGEROUS: html/REST/1.0/Forms/ticket html/REST/1.0/ticket html/Ticket html/Ticket/Elements html/User lib/RT lib/RT/Condition lib/RT/Interface/Email/Auth lib/RT/Model lib/RT/Shredder lib/RT/Shredder/Plugin t t/api t/delegation t/mail t/ticket

ruz at bestpractical.com ruz at bestpractical.com
Wed Jan 30 16:08:45 EST 2008


Author: ruz
Date: Wed Jan 30 16:08:43 2008
New Revision: 10592

Modified:
   rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/comment
   rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/links
   rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/comment
   rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/link
   rt/branches/3.999-DANGEROUS/html/Ticket/Elements/ShowTransaction
   rt/branches/3.999-DANGEROUS/html/Ticket/Elements/Tabs
   rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html
   rt/branches/3.999-DANGEROUS/html/Ticket/Update.html
   rt/branches/3.999-DANGEROUS/html/User/Delegation.html
   rt/branches/3.999-DANGEROUS/lib/RT/Condition/Generic.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Interface/Email/Auth/MailFrom.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/ACECollection.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Link.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomFieldValue.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Queue.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Record.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Template.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Transaction.pm
   rt/branches/3.999-DANGEROUS/lib/RT/Shredder/User.pm
   rt/branches/3.999-DANGEROUS/share/po/cs.po
   rt/branches/3.999-DANGEROUS/share/po/da.po
   rt/branches/3.999-DANGEROUS/share/po/de.po
   rt/branches/3.999-DANGEROUS/share/po/es.po
   rt/branches/3.999-DANGEROUS/share/po/fi.po
   rt/branches/3.999-DANGEROUS/share/po/fr.po
   rt/branches/3.999-DANGEROUS/share/po/he.po
   rt/branches/3.999-DANGEROUS/share/po/hu.po
   rt/branches/3.999-DANGEROUS/share/po/id.po
   rt/branches/3.999-DANGEROUS/share/po/it.po
   rt/branches/3.999-DANGEROUS/share/po/ja.po
   rt/branches/3.999-DANGEROUS/share/po/nl.po
   rt/branches/3.999-DANGEROUS/share/po/no.po
   rt/branches/3.999-DANGEROUS/share/po/pl.po
   rt/branches/3.999-DANGEROUS/share/po/pt_br.po
   rt/branches/3.999-DANGEROUS/share/po/ru.po
   rt/branches/3.999-DANGEROUS/share/po/sv.po
   rt/branches/3.999-DANGEROUS/share/po/tr.po
   rt/branches/3.999-DANGEROUS/share/po/zh_cn.po
   rt/branches/3.999-DANGEROUS/share/po/zh_tw.po
   rt/branches/3.999-DANGEROUS/t/api/record.t
   rt/branches/3.999-DANGEROUS/t/api/rights.t
   rt/branches/3.999-DANGEROUS/t/api/ticket.t
   rt/branches/3.999-DANGEROUS/t/delegation/revocation.t
   rt/branches/3.999-DANGEROUS/t/mail/gateway.t
   rt/branches/3.999-DANGEROUS/t/test_config.yml
   rt/branches/3.999-DANGEROUS/t/ticket/linking.t
   rt/branches/3.999-DANGEROUS/t/ticket/merge.t
   rt/branches/3.999-DANGEROUS/t/ticket/sort_by_cf.t

Log:
* API fixes

Modified: rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/comment
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/comment	(original)
+++ rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/comment	Wed Jan 30 16:08:43 2008
@@ -90,7 +90,7 @@
 }
 
 my $cgi = Jifty->handler->cgi;
-my $ent = MIME::Entity->build(Type => "multipart/mixed");
+my $ent = MIME::Entity->build(type => "multipart/mixed");
 $ent->attach(Data => $changes{Text}) if $changes{Text};
 
 my $i = 1;
@@ -127,7 +127,7 @@
 
 unless ($ticket->current_user_has_right('ModifyTicket') ||
         ($action eq "comment" &&
-         $ticket->current_user_has_right("commentOnTicket")) ||
+         $ticket->current_user_has_right("CommentOnTicket")) ||
         ($action eq "correspond" &&
          $ticket->current_user_has_right("ReplyToTicket")))
 {

Modified: rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/links
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/links	(original)
+++ rt/branches/3.999-DANGEROUS/html/REST/1.0/Forms/ticket/links	Wed Jan 30 16:08:43 2008
@@ -119,14 +119,14 @@
                 else {
                     my $type = $lfields{$key}->{Type};
                     my $mode = $lfields{$key}->{Mode};
-                    ($n, $s) = $ticket->delete_link(Type => $type, $mode => $u);
+                    ($n, $s) = $ticket->delete_link(type => $type, $mode => $u);
                     goto SET;
                 }
             }
             foreach my $u (keys %new) {
                 my $type = $lfields{$key}->{Type};
                 my $mode = $lfields{$key}->{Mode};
-                ($n, $s) = $ticket->add_link(Type => $type, $mode => $u);
+                ($n, $s) = $ticket->add_link(type => $type, $mode => $u);
                 goto SET;
             }
         }

Modified: rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/comment
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/comment	(original)
+++ rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/comment	Wed Jan 30 16:08:43 2008
@@ -106,7 +106,7 @@
 }
 
 my $cgi = Jifty->handler->cgi;
-my $ent = MIME::Entity->build(Type => "multipart/mixed");
+my $ent = MIME::Entity->build(type => "multipart/mixed");
 $ent->attach(Data => $k->{Text}) if $k->{Text};
 
 my $i = 1;
@@ -149,7 +149,7 @@
 }
 unless ($ticket->current_user_has_right('ModifyTicket') ||
         ($action eq "comment" &&
-         $ticket->current_user_has_right("commentOnTicket")) ||
+         $ticket->current_user_has_right("CommentOnTicket")) ||
         ($action eq "Correspond" &&
          $ticket->current_user_has_right("ReplyToTicket")))
 {

Modified: rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/link
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/link	(original)
+++ rt/branches/3.999-DANGEROUS/html/REST/1.0/ticket/link	Wed Jan 30 16:08:43 2008
@@ -108,7 +108,7 @@
 my $n = 1;
 my $op = $del ? "delete_link" : "add_link";
 
-($n, $output) = $ticket->$op(Type => $type, $mode => $to);
+($n, $output) = $ticket->$op(type => $type, $mode => $to);
 if ($n == 0) {
     $status = "500 Error";
 } else {

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/Elements/ShowTransaction
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/Elements/ShowTransaction	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/Elements/ShowTransaction	Wed Jan 30 16:08:43 2008
@@ -194,7 +194,7 @@
               . _('Reply')
               . "</a>]&nbsp;";
         }
-        if ( $can_modify || $ticket->current_user_has_right('commentOnTicket') ) {
+        if ( $can_modify || $ticket->current_user_has_right('CommentOnTicket') ) {
             $titlebar_commands .=
                 "[<a href=\"".$UpdatePath."?id="
               . $Transaction->ticket

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/Elements/Tabs
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/Elements/Tabs	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/Elements/Tabs	Wed Jan 30 16:08:43 2008
@@ -181,7 +181,7 @@
 
 }
 
-if ( $can{'ModifyTicket'} or $Ticket->current_user_has_right('commentOnTicket') ) {
+if ( $can{'ModifyTicket'} or $Ticket->current_user_has_right('CommentOnTicket') ) {
     $actions->{'E'} = {
         title => _('comment'),
         path  => "Ticket/Update.html?Action=comment&id=" . $id,

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/ModifyAll.html	Wed Jan 30 16:08:43 2008
@@ -144,7 +144,7 @@
 $CanRespond = 1 if ( $Ticket->current_user_has_right('ReplyToTicket') or
                      $Ticket->current_user_has_right('ModifyTicket') ); 
 
-$Cancomment = 1 if ( $Ticket->current_user_has_right('commentOnTicket') or
+$Cancomment = 1 if ( $Ticket->current_user_has_right('CommentOnTicket') or
                      $Ticket->current_user_has_right('ModifyTicket') );
 
 

Modified: rt/branches/3.999-DANGEROUS/html/Ticket/Update.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/Ticket/Update.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/Ticket/Update.html	Wed Jan 30 16:08:43 2008
@@ -194,7 +194,7 @@
 $CanRespond = 1 if ( $ticket_obj->current_user_has_right('ReplyToTicket') or
                      $ticket_obj->current_user_has_right('ModifyTicket') ); 
 
-$Cancomment = 1 if ( $ticket_obj->current_user_has_right('commentOnTicket') or
+$Cancomment = 1 if ( $ticket_obj->current_user_has_right('CommentOnTicket') or
                      $ticket_obj->current_user_has_right('ModifyTicket') ); 
 
 

Modified: rt/branches/3.999-DANGEROUS/html/User/Delegation.html
==============================================================================
--- rt/branches/3.999-DANGEROUS/html/User/Delegation.html	(original)
+++ rt/branches/3.999-DANGEROUS/html/User/Delegation.html	Wed Jan 30 16:08:43 2008
@@ -98,7 +98,7 @@
 my $acl = RT::Model::ACECollection->new();
 $acl->exclude_delegated_rights();
 $acl->limit_to_principal(Id => Jifty->web->current_user->id, 
-                       IncludeGroupMembership => 1
+                       include_group_membership => 1
                        );
 
 while(my $right = $acl->next) {

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Condition/Generic.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Condition/Generic.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Condition/Generic.pm	Wed Jan 30 16:08:43 2008
@@ -58,7 +58,7 @@
 		ticket_obj => $ti, 
 		scrip_obj => $scr, 
 		argument => $arg, 
-		Type => $type);
+		type => $type);
 
     if ($foo->is_applicable) {
  	   # do something

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Interface/Email/Auth/MailFrom.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Interface/Email/Auth/MailFrom.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Interface/Email/Auth/MailFrom.pm	Wed Jan 30 16:08:43 2008
@@ -108,11 +108,11 @@
             unless (
                 $everyone->principal_object->has_right(
                     object => $args{'queue'},
-                    right  => 'commentOnTicket'
+                    right  => 'CommentOnTicket'
                 )
                 || $unpriv->principal_object->has_right(
                     object => $args{'queue'},
-                    right  => 'commentOnTicket'
+                    right  => 'CommentOnTicket'
                 )
                 )
             {

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/ACECollection.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/ACECollection.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/ACECollection.pm	Wed Jan 30 16:08:43 2008
@@ -151,14 +151,14 @@
 
 # {{{ limit_ToPrincipal
 
-=head2 limit_ToPrincipal { type => undef, id => undef, IncludeGroupMembership => undef }
+=head2 limit_ToPrincipal { type => undef, id => undef, include_group_membership => undef }
 
 Limit the ACL to the principal with principal_id id and principal_type Type
 
 Id is not optional.
 Type is.
 
-if IncludeGroupMembership => 1 is specified, ACEs which apply to the principal due to group membership will be included in the resultset.
+if include_group_membership => 1 is specified, ACEs which apply to the principal due to group membership will be included in the resultset.
 
 
 =cut
@@ -168,10 +168,10 @@
     my %args = (
         type                   => undef,
         id                     => undef,
-        IncludeGroupMembership => undef,
+        include_group_membership => undef,
         @_
     );
-    if ( $args{'IncludeGroupMembership'} ) {
+    if ( $args{'include_group_membership'} ) {
         my $cgm = $self->new_alias('CachedGroupMembers');
         $self->join(
             alias1  => 'main',

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Link.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Link.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Link.pm	Wed Jan 30 16:08:43 2008
@@ -78,14 +78,14 @@
     column target => type is 'varchar(240)', max_length is 240, default is '';
     column base   => type is 'varchar(240)', max_length is 240, default is '';
     column local_target => type is 'int(11)', max_length is 11, default is '0';
-    column Creator     => type is 'int(11)', max_length is 11, default is '0';
+    column creator     => type is 'int(11)', max_length is 11, default is '0';
     column type => type is 'varchar(20)', max_length is 20, default is '';
     column
-        LastUpdatedBy => type is 'int(11)',
+        last_updated_by => type is 'int(11)',
         max_length is 11, default is '0';
-    column Created => type is 'datetime', default is '';
+    column created => type is 'datetime', default is '';
     column local_base => type is 'int(11)', max_length is 11, default is '0';
-    column LastUpdated => type is 'datetime', default is '';
+    column last_updated => type is 'datetime', default is '';
 
 };
 
@@ -188,7 +188,7 @@
 # }}}
 # {{{ sub loadByParams
 
-=head2 LoadByParams
+=head2 load_by_params
 
   Load an RT::Model::Link object from the database.  Takes three parameters
   

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomFieldValue.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomFieldValue.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/ObjectCustomFieldValue.pm	Wed Jan 30 16:08:43 2008
@@ -64,7 +64,7 @@
     column Creator => type is 'int(11)', max_length is 11, default is '0';
     column object_id => type is 'int(11)', max_length is 11, default is '0';
     column
-        LastUpdatedBy => type is 'int(11)',
+        last_updated_by => type is 'int(11)',
         max_length is 11, default is '0';
     column disabled => type is 'smallint(6)', max_length is 6, default is '0';
     column sort_order => type is 'int(11)', max_length is 11, default is '0';

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Queue.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Queue.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Queue.pm	Wed Jan 30 16:08:43 2008
@@ -141,7 +141,7 @@
     WatchAsAdminCc  => 'Sign up as a ticket or queue AdminCc',      # loc_pair
     create_ticket   => 'Create tickets in this queue',              # loc_pair
     ReplyToTicket   => 'Reply to tickets',                          # loc_pair
-    commentOnTicket => 'comment on tickets',                        # loc_pair
+    CommentOnTicket => 'comment on tickets',                        # loc_pair
     OwnTicket       => 'Own tickets',                               # loc_pair
     ModifyTicket    => 'Modify tickets',                            # loc_pair
     DeleteTicket    => 'Delete tickets',                            # loc_pair

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Template.pm	Wed Jan 30 16:08:43 2008
@@ -44,7 +44,7 @@
     column content     => type is 'blob',     default is '';
     column LastUpdated => type is 'datetime', default is '';
     column
-        LastUpdatedBy => max_length is 11,
+        last_updated_by => max_length is 11,
         type is 'int(11)', default is '0';
     column Creator => max_length is 11, type is 'int(11)', default is '0';
     column Created => type is 'datetime', default is '';

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm	Wed Jan 30 16:08:43 2008
@@ -94,17 +94,17 @@
     column time_worked => max_length is 11, type is 'int(11)', default is '0';
     column status => max_length is 10, type is 'varchar(10)', default is '';
     column time_left => max_length is 11, type is 'int(11)', default is '0';
-    column Told     => type is 'datetime', default is '';
+    column told     => type is 'datetime', default is '';
     column starts   => type is 'datetime', default is '';
-    column Started  => type is 'datetime', default is '';
-    column Due      => type is 'datetime', default is '';
+    column started  => type is 'datetime', default is '';
+    column due      => type is 'datetime', default is '';
     column resolved => type is 'datetime', default is '';
     column
         last_updated_by => max_length is 11,
         type is 'int(11)', default is '0';
     column last_updated => type is 'datetime', default is '';
-    column Creator => max_length is 11,   type is 'int(11)', default is '0';
-    column Created => type is 'datetime', default is '';
+    column creator => max_length is 11,   type is 'int(11)', default is '0';
+    column created => type is 'datetime', default is '';
     column disabled => max_length is 6, type is 'smallint(6)', default is '0';
 };
 
@@ -307,7 +307,7 @@
   time_worked -- an integer. time worked so far in minutes
   time_left -- an integer. time remaining in minutes
   starts -- an ISO date describing the ticket\'s start date and time in GMT
-  Due -- an ISO date describing the ticket\'s due date and time in GMT
+  due -- an ISO date describing the ticket\'s due date and time in GMT
   mime_obj -- a MIME::Entity object with the content of the initial ticket request.
   CustomField-<n> -- a scalar or array of values for the customfield with the id <n>
 
@@ -348,9 +348,9 @@
         time_worked         => "0",
         time_left           => 0,
         time_estimated      => 0,
-        Due                 => undef,
+        due                 => undef,
         starts              => undef,
-        Started             => undef,
+        started             => undef,
         resolved            => undef,
         mime_obj             => undef,
         _record_transaction => 1,
@@ -379,7 +379,7 @@
     #Now that we have a queue, Check the ACLS
     unless (
         $self->current_user->has_right(
-            right  => 'create_ticket',
+            right  => 'CreateTicket',
             object => $queue_obj
         )
         )
@@ -418,12 +418,12 @@
     # than assuming it's in ISO format.
 
     #Set the due date. if we didn't get fed one, use the queue default due in
-    my $Due = RT::Date->new();
-    if ( defined $args{'Due'} ) {
-        $Due->set( Format => 'ISO', value => $args{'Due'} );
+    my $due = RT::Date->new();
+    if ( defined $args{'due'} ) {
+        $due->set( Format => 'ISO', value => $args{'due'} );
     } elsif ( my $due_in = $queue_obj->default_due_in ) {
-        $Due->set_to_now;
-        $Due->add_days($due_in);
+        $due->set_to_now;
+        $due->add_days($due_in);
     }
 
     my $starts = RT::Date->new();
@@ -431,11 +431,11 @@
         $starts->set( Format => 'ISO', value => $args{'starts'} );
     }
 
-    my $Started = RT::Date->new();
-    if ( defined $args{'Started'} ) {
-        $Started->set( Format => 'ISO', value => $args{'Started'} );
+    my $started = RT::Date->new();
+    if ( defined $args{'started'} ) {
+        $started->set( Format => 'ISO', value => $args{'started'} );
     } elsif ( $args{'status'} ne 'new' ) {
-        $Started->set_to_now;
+        $started->set_to_now;
     }
 
     my $Resolved = RT::Date->new();
@@ -550,13 +550,13 @@
         time_left        => $args{'time_left'},
         type             => $args{'type'},
         starts           => $starts->iso,
-        Started          => $Started->iso,
+        started          => $started->iso,
         resolved         => $Resolved->iso,
-        Due              => $Due->iso
+        due              => $due->iso
     );
 
 # Parameters passed in during an import that we probably don't want to touch, otherwise
-    foreach my $attr qw(id Creator Created last_updated last_updated_by) {
+    foreach my $attr qw(id creator created last_updated last_updated_by) {
         $params{$attr} = $args{$attr} if $args{$attr};
     }
 
@@ -579,7 +579,7 @@
             _("Ticket could not be created due to an internal error") );
     }
 
-    #Set the ticket's effective ID now that we've Created it.
+    #Set the ticket's effective ID now that we've created it.
     my ( $val, $msg ) = $self->__set(
         column => 'effective_id',
         value  => ( $args{'effective_id'} || $id )
@@ -714,7 +714,7 @@
     }
 
 # }}}
-# Now that we've Created the ticket and set up its metadata, we can actually go and check OwnTicket on the ticket itself.
+# Now that we've created the ticket and set up its metadata, we can actually go and check OwnTicket on the ticket itself.
 # This might be different than before in cases where extensions like RTIR are doing clever things with RT's ACL system
     if ($DeferOwner) {
         if (!$DeferOwner->has_right( object => $self, right => 'OwnTicket' ) )
@@ -867,7 +867,7 @@
 
 =cut
 
-sub import {
+sub __import {
     my $self = shift;
     my ( $ErrStr, $queue_obj, $owner );
 
@@ -883,11 +883,11 @@
         final_priority   => undef,
         status           => 'new',
         time_worked      => "0",
-        Due              => undef,
-        Created          => undef,
+        due              => undef,
+        created          => undef,
         Updated          => undef,
         resolved         => undef,
-        Told             => undef,
+        told             => undef,
         @_
     );
 
@@ -911,7 +911,7 @@
     #Now that we have a queue, Check the ACLS
     unless (
         $self->current_user->has_right(
-            right  => 'create_ticket',
+            right  => 'CreateTicket',
             object => $queue_obj
         )
         )
@@ -997,15 +997,15 @@
         status           => $args{'status'},              # loc
         time_worked      => $args{'time_worked'},         # loc
         type             => $args{'type'},                # loc
-        Created          => $args{'Created'},             # loc
-        Told             => $args{'Told'},                # loc
+        created          => $args{'created'},             # loc
+        told             => $args{'told'},                # loc
         last_updated      => $args{'Updated'},             # loc
         resolved         => $args{'resolved'},            # loc
-        Due              => $args{'Due'},                 # loc
+        due              => $args{'due'},                 # loc
     );
 
     # If the ticket didn't have an id
-    # Set the ticket's effective ID now that we've Created it.
+    # Set the ticket's effective ID now that we've created it.
     if ( $args{'id'} ) {
         $self->load( $args{'id'} );
     } else {
@@ -1726,7 +1726,7 @@
     #    return(undef);
     #   }
 
-    #Tickets won't yet have owners when they're being Created.
+    #Tickets won't yet have owners when they're being created.
     unless ( $self->owner_obj->id ) {
         return (undef);
     }
@@ -1837,7 +1837,7 @@
     }
     unless (
         $self->current_user->has_right(
-            right  => 'create_ticket',
+            right  => 'CreateTicket',
             object => $Newqueue_obj
         )
         )
@@ -1999,7 +1999,7 @@
 =head2 started_obj
 
   Returns an RT::Date object which contains this ticket's 
-'Started' time.
+'started' time.
 
 =cut
 
@@ -2037,7 +2037,7 @@
 =head2 told_obj
 
   Returns an RT::Date object which contains this ticket's 
-'Told' time.
+'told' time.
 
 =cut
 
@@ -2133,7 +2133,7 @@
         @_
     );
 
-    unless ( ( $self->current_user_has_right('commentOnTicket') )
+    unless ( ( $self->current_user_has_right('CommentOnTicket') )
         or ( $self->current_user_has_right('ModifyTicket') ) )
     {
         return ( 0, _("Permission Denied"), undef );
@@ -2364,7 +2364,7 @@
 If Silent is true then no transaction would be recorded, in other
 case you can control creation of transactions on both base and
 target with Silentbase and Silenttarget respectively. By default
-both transactions are Created.
+both transactions are created.
 
 =cut 
 
@@ -2467,7 +2467,7 @@
 If Silent is true then no transaction would be recorded, in other
 case you can control creation of transactions on both base and
 target with Silentbase and Silenttarget respectively. By default
-both transactions are Created.
+both transactions are created.
 
 =cut
 
@@ -3115,7 +3115,7 @@
     #If we're changing the status from new, record that we've started
     if ( $self->status eq 'new' && $args{status} ne 'new' ) {
 
-        #Set the Started time to "now"
+        #Set the started time to "now"
         $self->_set(
             column             => 'started',
             value              => $now->iso,
@@ -3316,7 +3316,7 @@
 
 =head2 transaction_batch
 
-  Returns an array reference of all transactions Created on this ticket during
+  Returns an array reference of all transactions created on this ticket during
   this ticket object's lifetime, or undef if there were none.
 
   Only works when the C<Usetransaction_batch> config option is set to true.
@@ -3372,14 +3372,14 @@
         time_estimated   => { 'read' => 1, 'write' => 1 },
         time_worked      => { 'read' => 1, 'write' => 1 },
         time_left        => { 'read' => 1, 'write' => 1 },
-        Told             => { 'read' => 1, 'write' => 1 },
+        told             => { 'read' => 1, 'write' => 1 },
         resolved         => { 'read' => 1 },
         type             => { 'read' => 1 },
         starts        => { 'read' => 1, 'write' => 1 },
-        Started       => { 'read' => 1, 'write' => 1 },
-        Due           => { 'read' => 1, 'write' => 1 },
-        Creator       => { 'read' => 1, 'auto'  => 1 },
-        Created       => { 'read' => 1, 'auto'  => 1 },
+        started       => { 'read' => 1, 'write' => 1 },
+        due           => { 'read' => 1, 'write' => 1 },
+        creator       => { 'read' => 1, 'auto'  => 1 },
+        created       => { 'read' => 1, 'auto'  => 1 },
         last_updated_by => { 'read' => 1, 'auto'  => 1 },
         last_updated   => { 'read' => 1, 'auto'  => 1 }
     };

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/TicketCollection.pm	Wed Jan 30 16:08:43 2008
@@ -97,14 +97,14 @@
     status           => [ 'ENUM', ],
     queue            => [ 'ENUM' => 'Queue', ],
     type             => [ 'ENUM', ],
-    Creator          => [ 'ENUM' => 'User', ],
-    LastUpdatedBy    => [ 'ENUM' => 'User', ],
+    creator          => [ 'ENUM' => 'User', ],
+    last_updated_by    => [ 'ENUM' => 'User', ],
     owner            => [ 'WATCHERFIELD' => 'Owner', ],
     effective_id      => [ 'INT', ],
     id               => [ 'INT', ],
     initial_priority => [ 'INT', ],
     final_priority   => [ 'INT', ],
-    Priority         => [ 'INT', ],
+    priority         => [ 'INT', ],
     time_left        => [ 'INT', ],
     time_worked      => [ 'INT', ],
     time_estimated   => [ 'INT', ],
@@ -213,7 +213,7 @@
     queue subject
     Owner Created Due starts Started
     Told
-    resolved LastUpdated Priority time_worked time_left);
+    resolved LastUpdated priority time_worked time_left);
 
 =head2 SortFields
 
@@ -304,7 +304,7 @@
 =head2 _IntLimit
 
 Handle fields where the values are limited to integers.  (For example,
-Priority, time_worked.)
+priority, time_worked.)
 
 Meta Data:
   None

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm	Wed Jan 30 16:08:43 2008
@@ -1219,7 +1219,7 @@
     $deleg_acl->limit_to_principal(
         type                   => 'User',
         id                     => $self->principal_id,
-        IncludeGroupMembership => 1
+        include_group_membership => 1
     );
     $deleg_acl->limit(
         column   => 'right_name',

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Record.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Record.pm	Wed Jan 30 16:08:43 2008
@@ -507,7 +507,7 @@
 
 =head2 _setLastUpdated
 
-This routine updates the LastUpdated and LastUpdatedBy columns of the row in question
+This routine updates the LastUpdated and last_updated_by columns of the row in question
 It takes no options. Arguably, this is a bug
 
 =cut
@@ -522,7 +522,7 @@
         value  => $now->iso
     );
     ( $msg, $val ) = $self->__set(
-        column => 'LastUpdatedBy',
+        column => 'last_updated_by',
         value  => $self->current_user ? $self->current_user->id : 0
     );
 }

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Summary.pm	Wed Jan 30 16:08:43 2008
@@ -149,7 +149,7 @@
 sub _make_hash {
     my ( $self, $obj ) = @_;
     my $hash = $self->__make_hash($obj);
-    foreach ( grep exists $hash->{$_}, qw(Creator LastUpdatedBy) ) {
+    foreach ( grep exists $hash->{$_}, qw(Creator last_updated_by) ) {
         my $method = $_ . 'Obj';
         my $u      = $obj->$method();
         $hash->{$_} = $u->email || $u->name || $u->_as_string;

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Plugin/Users.pm	Wed Jan 30 16:08:43 2008
@@ -75,7 +75,7 @@
 
 When you delete user there is could be minor links to him in RT DB.
 This option allow you to replace this links with link to other user.
-This links are Creator and LastUpdatedBy, but NOT any watcher roles,
+This links are Creator and last_updated_by, but NOT any watcher roles,
 this mean that if user is watcher(Requestor, Owner,
 Cc or AdminCc) of the ticket or queue then link would be deleted.
 
@@ -135,7 +135,7 @@
     # XXX: we want preload only things we need, but later while
     # logging we need all data, TODO envestigate this
     # $objs->columns(qw(id name email lang Timezone
-    #                   Creator Created LastUpdated LastUpdatedBy));
+    #                   Creator Created LastUpdated last_updated_by));
     if ( my $s = $self->{'opt'}{'status'} ) {
         if ( $s eq 'any' ) {
             $objs->{'find_disabled_rows'} = 1;
@@ -188,7 +188,7 @@
         my $resolver = sub {
             my %args = (@_);
             my $t    = $args{'targetobject'};
-            foreach my $method (qw(Creator LastUpdatedBy)) {
+            foreach my $method (qw(Creator last_updated_by)) {
                 next unless $t->_accessible( $method => 'read' );
                 $t->__set( column => $method, value => $uid );
             }

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Record.pm	Wed Jan 30 16:08:43 2008
@@ -201,7 +201,7 @@
         }
     }
 
-    if ( $self->can('LastUpdatedBy') ) {
+    if ( $self->can('last_updated_by') ) {
         my $obj = RT::Model::Principal->new;
         $obj->load( $self->last_updated_by );
 
@@ -212,7 +212,7 @@
             $self = $rec->{'object'};
             $rec->{'State'} |= INVALID;
             push @{ $rec->{'description'} },
-                "Have no related User(LastUpdatedBy) #"
+                "Have no related User(last_updated_by) #"
                 . $self->last_updated_by
                 . " object";
         }

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Template.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Template.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Template.pm	Wed Jan 30 16:08:43 2008
@@ -104,7 +104,7 @@
             = "Have no related queue #" . $self->id . " object";
     }
 
-    # TODO: Users(Creator, LastUpdatedBy)
+    # TODO: Users(Creator, last_updated_by)
 
     $deps->_push_dependencies(
         base_object   => $self,

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Transaction.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Transaction.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/Transaction.pm	Wed Jan 30 16:08:43 2008
@@ -100,7 +100,7 @@
             = "Have no related Ticket #" . $self->id . " object";
     }
 
-    # TODO: Users(Creator, LastUpdatedBy)
+    # TODO: Users(Creator, last_updated_by)
 
     $deps->_push_dependencies(
         base_object   => $self,

Modified: rt/branches/3.999-DANGEROUS/lib/RT/Shredder/User.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Shredder/User.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Shredder/User.pm	Wed Jan 30 16:08:43 2008
@@ -114,12 +114,12 @@
         Shredder      => $args{'Shredder'}
     );
 
-    # TODO: Almost all objects has Creator, LastUpdatedBy and etc. fields
+    # TODO: Almost all objects has Creator, last_updated_by and etc. fields
     # which are references on users(Principal actualy)
     my @var_objs;
     foreach (@OBJECTS) {
         my $class = "RT::Model::$_";
-        foreach my $method (qw(Creator LastUpdatedBy)) {
+        foreach my $method (qw(Creator last_updated_by)) {
             my $objs = $class->new;
             next unless $objs->new_item->can($method);
             $objs->limit( column => $method, value => $self->id );

Modified: rt/branches/3.999-DANGEROUS/share/po/cs.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/cs.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/cs.po	Wed Jan 30 16:08:43 2008
@@ -1137,7 +1137,7 @@
 msgstr "Komentovat požadavky"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "Komentovat požadavky"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/da.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/da.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/da.po	Wed Jan 30 16:08:43 2008
@@ -1254,7 +1254,7 @@
 msgstr "Kommentar på sager"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "KommentarPåSag"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/de.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/de.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/de.po	Wed Jan 30 16:08:43 2008
@@ -971,7 +971,7 @@
 msgstr "Kommentiere Anfragen"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "AnfrageKommentieren"
 
 #: html/Ticket/ModifyAll.html:91 html/Ticket/Update.html:75

Modified: rt/branches/3.999-DANGEROUS/share/po/es.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/es.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/es.po	Wed Jan 30 16:08:43 2008
@@ -1203,8 +1203,8 @@
 msgstr "Comentario sobre los tickets"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
-msgstr "commentOnTicket"
+msgid "CommentOnTicket"
+msgstr "CommentOnTicket"
 
 #: NOT FOUND IN SOURCE
 msgid "comments"

Modified: rt/branches/3.999-DANGEROUS/share/po/fi.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/fi.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/fi.po	Wed Jan 30 16:08:43 2008
@@ -1114,7 +1114,7 @@
 msgstr "Kommentoi tapauksia"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr ""
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/fr.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/fr.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/fr.po	Wed Jan 30 16:08:43 2008
@@ -924,7 +924,7 @@
 msgstr "commentaire sur le ticket"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "commenterTicket"
 
 #: html/Ticket/ModifyAll.html:91 html/Ticket/Update.html:75

Modified: rt/branches/3.999-DANGEROUS/share/po/he.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/he.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/he.po	Wed Jan 30 16:08:43 2008
@@ -940,7 +940,7 @@
 msgstr ""
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr ""
 
 #: html/Ticket/ModifyAll.html:91 html/Ticket/Update.html:75

Modified: rt/branches/3.999-DANGEROUS/share/po/hu.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/hu.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/hu.po	Wed Jan 30 16:08:43 2008
@@ -918,7 +918,7 @@
 msgstr ""
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr ""
 
 #: html/Ticket/ModifyAll.html:91 html/Ticket/Update.html:75

Modified: rt/branches/3.999-DANGEROUS/share/po/id.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/id.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/id.po	Wed Jan 30 16:08:43 2008
@@ -974,7 +974,7 @@
 msgstr "Komentar pada Tiket"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "Komentar Pada Tiket"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/it.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/it.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/it.po	Wed Jan 30 16:08:43 2008
@@ -1225,7 +1225,7 @@
 msgstr "Aggiunta di commenti ai ticket"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "AggiungicommentiAlTicket"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/ja.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/ja.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/ja.po	Wed Jan 30 16:08:43 2008
@@ -1062,7 +1062,7 @@
 msgstr ""
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr ""
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/nl.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/nl.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/nl.po	Wed Jan 30 16:08:43 2008
@@ -1128,7 +1128,7 @@
 msgstr "commentaar op tickets"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "commentaarOpTicket"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/no.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/no.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/no.po	Wed Jan 30 16:08:43 2008
@@ -1237,7 +1237,7 @@
 msgstr "Kommenter saker"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "KommenterSak"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/pl.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/pl.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/pl.po	Wed Jan 30 16:08:43 2008
@@ -1263,8 +1263,8 @@
 msgstr "Komentarz do zgłoszeń"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
-msgstr "commentOnTicket"
+msgid "CommentOnTicket"
+msgstr "CommentOnTicket"
 
 #: NOT FOUND IN SOURCE
 msgid "comments"

Modified: rt/branches/3.999-DANGEROUS/share/po/pt_br.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/pt_br.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/pt_br.po	Wed Jan 30 16:08:43 2008
@@ -1221,8 +1221,8 @@
 msgstr "Comente sobre os tíquetes"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
-msgstr "commentOnTicket"
+msgid "CommentOnTicket"
+msgstr "CommentOnTicket"
 
 #: NOT FOUND IN SOURCE
 msgid "comments"

Modified: rt/branches/3.999-DANGEROUS/share/po/ru.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/ru.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/ru.po	Wed Jan 30 16:08:43 2008
@@ -1255,7 +1255,7 @@
 msgstr "Комментарии заявки"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "КомментироватьЗаявку"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/sv.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/sv.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/sv.po	Wed Jan 30 16:08:43 2008
@@ -996,7 +996,7 @@
 msgstr "Kommentar på ärenden"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "KommentarPåÄrende"
 
 #: html/Ticket/ModifyAll.html:91

Modified: rt/branches/3.999-DANGEROUS/share/po/tr.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/tr.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/tr.po	Wed Jan 30 16:08:43 2008
@@ -904,7 +904,7 @@
 msgstr "Biletler üzerine yorum yap"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr ""
 
 #: html/Ticket/ModifyAll.html:91 html/Ticket/Update.html:75

Modified: rt/branches/3.999-DANGEROUS/share/po/zh_cn.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/zh_cn.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/zh_cn.po	Wed Jan 30 16:08:43 2008
@@ -1520,7 +1520,7 @@
 msgstr "对申请单提出评论"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "评论申请单"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/share/po/zh_tw.po
==============================================================================
--- rt/branches/3.999-DANGEROUS/share/po/zh_tw.po	(original)
+++ rt/branches/3.999-DANGEROUS/share/po/zh_tw.po	Wed Jan 30 16:08:43 2008
@@ -1520,7 +1520,7 @@
 msgstr "對申請單提出評論"
 
 #: lib/RT/Queue_Overlay.pm:111
-msgid "commentOnTicket"
+msgid "CommentOnTicket"
 msgstr "評論申請單"
 
 #: NOT FOUND IN SOURCE

Modified: rt/branches/3.999-DANGEROUS/t/api/record.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/api/record.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/api/record.t	Wed Jan 30 16:08:43 2008
@@ -1,12 +1,10 @@
 
 use strict;
 use warnings;
-use RT::Test; use Test::More; 
+use RT::Test;
 plan tests => 22;
 use RT;
 
-
-
 {
 
 ok (require RT::Record);
@@ -14,6 +12,8 @@
 
 }
 
+die "bla-bla";
+
 {
 
 my $ticket = RT::Model::Ticket->new(current_user => RT->system_user);

Modified: rt/branches/3.999-DANGEROUS/t/api/rights.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/api/rights.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/api/rights.t	Wed Jan 30 16:08:43 2008
@@ -87,7 +87,7 @@
 ok( !$user->has_right( right => 'ReplyToTicket', object => $queue ), "user can't reply to ticket" );
 
 my $group = RT::Model::Group->new(current_user => RT->system_user );
-ok( $group->load_queue_role_group( queue => $queue_id, Type=> 'Owner' ), "load queue owners role group" );
+ok( $group->load_queue_role_group( queue => $queue_id, type=> 'Owner' ), "load queue owners role group" );
 my $ace = RT::Model::ACE->new(current_user => RT->system_user );
 my ($ace_id, $msg) = $group->principal_object->grant_right( right => 'ReplyToTicket', object => $queue );
 ok( $ace_id, "Granted queue owners role group with ReplyToTicket right: $msg" );
@@ -113,7 +113,7 @@
 
 # Testing of equiv_objects
 $group = RT::Model::Group->new(current_user => RT->system_user );
-ok( $group->load_queue_role_group( queue => $queue_id, Type=> 'AdminCc' ), "load queue AdminCc role group" );
+ok( $group->load_queue_role_group( queue => $queue_id, type=> 'AdminCc' ), "load queue AdminCc role group" );
 $ace = RT::Model::ACE->new(current_user => RT->system_user );
 ($ace_id, $msg) = $group->principal_object->grant_right( right => 'ModifyTicket', object => $queue );
 ok( $ace_id, "Granted queue AdminCc role group with ModifyTicket right: $msg" );

Modified: rt/branches/3.999-DANGEROUS/t/api/ticket.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/api/ticket.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/api/ticket.t	Wed Jan 30 16:08:43 2008
@@ -43,7 +43,7 @@
 ok(my $t = RT::Model::Ticket->new(current_user => RT->system_user));
 ok(my ($id, $msg) = $t->create( queue => $testqueue->id,
                subject => 'Testing',
-               Owner => $u->id
+               owner => $u->id
               ));
 isnt($id , 0);
 is ($t->owner_obj->id , $u->id, "Root is the ticket owner");
@@ -68,7 +68,7 @@
 my $t3 = RT::Model::Ticket->new(current_user => RT->system_user);
 my ($id3, $msg3) = $t3->create( queue => $testqueue->id,
                                 subject => 'Testing',
-                                Owner => $u->id);
+                                owner => $u->id);
 my ($cfv1, $cfm1) = $t->add_custom_field_value(Field => $testcf->id,
  Value => 'Value1');
 isnt($cfv1 , 0, "Adding a custom field to ticket 1 is successful: $cfm");
@@ -102,8 +102,8 @@
 my $ticket = RT::Model::Ticket->new(current_user => RT->system_user);
 my $msg;
 ($id, $msg) = $ticket->create(subject => "Foo",
-                Owner => RT->nobody->id,
-                Status => 'open',
+                owner => RT->nobody->id,
+                status => 'open',
                 Requestor => ['jesse at example.com'],
                 queue => '1'
                 );
@@ -136,7 +136,7 @@
 ok ($group->id, "Found the AdminCc object for this ticket");
 $group = RT::Model::Group->new(current_user => RT->system_user);
 ok($group->load_ticket_role_group(ticket => $id, type=> 'Owner'));
-ok ($group->id, "Found the Owner object for this ticket");
+ok ($group->id, "Found the owner object for this ticket");
 ok($group->has_member(RT->nobody->user_object->principal_object), "the owner group has the member 'RT_System'");
 
 

Modified: rt/branches/3.999-DANGEROUS/t/delegation/revocation.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/delegation/revocation.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/delegation/revocation.t	Wed Jan 30 16:08:43 2008
@@ -112,7 +112,7 @@
     # Revoke all rights granted to our cast
     my $acl = RT::Model::ACECollection->new(current_user => RT->system_user);
     foreach (@principals) {
-	$acl->limit_to_principal(Type => $$_->principal_object->principal_type,
+	$acl->limit_to_principal(type => $$_->principal_object->principal_type,
 			       id => $$_->principal_object->id);
     }
     while (my $ace = $acl->next()) {

Modified: rt/branches/3.999-DANGEROUS/t/mail/gateway.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/mail/gateway.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/mail/gateway.t	Wed Jan 30 16:08:43 2008
@@ -113,7 +113,7 @@
     $everyone_group->load_system_internal_group( 'Everyone' );
     ok ($everyone_group->id, "Found group 'everyone'");
 
-    foreach( qw(create_ticket ReplyToTicket commentOnTicket) ) {
+    foreach( qw(create_ticket ReplyToTicket CommentOnTicket) ) {
         $everyone_group->principal_object->revoke_right(right => $_);
     }
 }
@@ -387,11 +387,11 @@
 }
 
 
-diag "grant everyone 'commentOnTicket' right" if $ENV{'TEST_VERBOSE'};
+diag "grant everyone 'CommentOnTicket' right" if $ENV{'TEST_VERBOSE'};
 {
     ok( RT::Test->set_rights(
         { Principal => $everyone_group->principal_object,
-          right => [qw(create_ticket ReplyToTicket commentOnTicket)],
+          right => [qw(create_ticket ReplyToTicket CommentOnTicket)],
         },
     ), "Granted everybody the right to comment on tickets");
 }
@@ -774,7 +774,7 @@
 
 
 my $group = RT::Model::Group->new(current_user => RT->system_user );
-ok( $group->load_queue_role_group( queue => $qid, Type=> 'Owner' ), "load queue owners role group" );
+ok( $group->load_queue_role_group( queue => $qid, type=> 'Owner' ), "load queue owners role group" );
 $ace = RT::Model::ACE->new(current_user => RT->system_user );
 ($ace_id, $msg) = $group->principal_object->grant_right( right => 'ReplyToTicket', object => $queue );
 ok( $ace_id, "Granted queue owners role group with ReplyToTicket right" );

Modified: rt/branches/3.999-DANGEROUS/t/test_config.yml
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/test_config.yml	(original)
+++ rt/branches/3.999-DANGEROUS/t/test_config.yml	Wed Jan 30 16:08:43 2008
@@ -1,4 +1,4 @@
 --- 
 framework: 
-  LogLevel: DEBUG
+  LogLevel: WARN
 

Modified: rt/branches/3.999-DANGEROUS/t/ticket/linking.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/linking.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/linking.t	Wed Jan 30 16:08:43 2008
@@ -141,7 +141,7 @@
     my $child = RT::Model::Ticket->new( current_user => $creator);
     ($id,$tid,$msg) = $child->create( subject => 'Link test 1', queue => $q1->id );
     ok($id,$msg);
-    ($id, $msg) = $child->add_link(Type => 'MemberOf', target => $parent->id);
+    ($id, $msg) = $child->add_link(type => 'MemberOf', target => $parent->id);
     ok(!$id, $msg);
     is(link_count($filename), undef, "scrips ok");
     $child->current_user( RT->system_user );
@@ -159,7 +159,7 @@
     my $child = RT::Model::Ticket->new( current_user => $creator );
     ($id,$tid,$msg) = $child->create( subject => 'Link test 1', queue => $q1->id );
     ok($id,$msg);
-    ($id, $msg) = $child->add_link(Type => 'MemberOf', target => $parent->id);
+    ($id, $msg) = $child->add_link(type => 'MemberOf', target => $parent->id);
     ok($id, $msg);
     is(link_count($filename), 1, "scrips ok");
     $child->current_user( RT->system_user );
@@ -169,7 +169,7 @@
 
     # turn off feature and try to delete link, we should fail
     RT->config->set( StrictLinkACL => 1 );
-    ($id, $msg) = $child->add_link(Type => 'MemberOf', target => $parent->id);
+    ($id, $msg) = $child->add_link(type => 'MemberOf', target => $parent->id);
     ok(!$id, $msg);
     is(link_count($filename), 1, "scrips ok");
     $child->current_user( RT->system_user );
@@ -179,7 +179,7 @@
 
     # try to delete link, we should success as feature is active
     RT->config->set( StrictLinkACL => 0 );
-    ($id, $msg) = $child->delete_link(Type => 'MemberOf', target => $parent->id);
+    ($id, $msg) = $child->delete_link(type => 'MemberOf', target => $parent->id);
     ok($id, $msg);
     is(link_count($filename), 0, "scrips ok");
     $child->current_user( RT->system_user );
@@ -196,7 +196,7 @@
 
 diag('try link to itself') if $ENV{'TEST_VERBOSE'};
 {
-    my ($id, $msg) = $ticket->add_link(Type => 'RefersTo', target => $ticket->id);
+    my ($id, $msg) = $ticket->add_link(type => 'RefersTo', target => $ticket->id);
     ok(!$id, $msg);
     is(link_count($filename), 0, "scrips ok");
 }
@@ -204,7 +204,7 @@
 my $ticket2 = RT::Model::Ticket->new(current_user => RT->system_user);
 ($id, $tid, $msg) = $ticket2->create(subject => 'Link test 2', queue => $q2->id);
 ok ($id, $msg);
-($id,$msg) =$ticket->add_link(Type => 'RefersTo', target => $ticket2->id);
+($id,$msg) =$ticket->add_link(type => 'RefersTo', target => $ticket2->id);
 ok(!$id,$msg);
 is(link_count($filename), 0, "scrips ok");
 
@@ -212,12 +212,12 @@
 ok ($id,$msg);
 ($id,$msg) = $u1->principal_object->grant_right ( object => $q2, right => 'ModifyTicket');
 ok ($id,$msg);
-($id,$msg) = $ticket->add_link(Type => 'RefersTo', target => $ticket2->id);
+($id,$msg) = $ticket->add_link(type => 'RefersTo', target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 1, "scrips ok");
-($id,$msg) = $ticket->add_link(Type => 'RefersTo', target => -1);
+($id,$msg) = $ticket->add_link(type => 'RefersTo', target => -1);
 ok(!$id,$msg);
-($id,$msg) = $ticket->add_link(Type => 'RefersTo', target => $ticket2->id);
+($id,$msg) = $ticket->add_link(type => 'RefersTo', target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 1, "scrips ok");
 
@@ -227,7 +227,7 @@
 is( $transactions->first->field , 'ReferredToBy');
 is( $transactions->first->new_value , $ticket->uri );
 
-($id,$msg) = $ticket->delete_link(Type => 'RefersTo', target => $ticket2->id);
+($id,$msg) = $ticket->delete_link(type => 'RefersTo', target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 0, "scrips ok");
 $transactions = $ticket2->transactions;
@@ -238,15 +238,15 @@
 
 RT->config->set( LinkTransactionsRun1Scrip => 0 );
 
-($id,$msg) =$ticket->add_link(Type => 'RefersTo', target => $ticket2->id);
+($id,$msg) =$ticket->add_link(type => 'RefersTo', target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 2, "scrips ok");
-($id,$msg) =$ticket->delete_link(Type => 'RefersTo', target => $ticket2->id);
+($id,$msg) =$ticket->delete_link(type => 'RefersTo', target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 0, "scrips ok");
 
 # tests for silent behaviour
-($id,$msg) = $ticket->add_link(Type => 'RefersTo', target => $ticket2->id, Silent => 1);
+($id,$msg) = $ticket->add_link(type => 'RefersTo', target => $ticket2->id, Silent => 1);
 ok($id,$msg);
 is(link_count($filename), 0, "scrips ok");
 {
@@ -259,11 +259,11 @@
     is( $transactions->count, 2, "Still two txns on the target" );
 
 }
-($id,$msg) =$ticket->delete_link(Type => 'RefersTo', target => $ticket2->id, Silent => 1);
+($id,$msg) =$ticket->delete_link(type => 'RefersTo', target => $ticket2->id, Silent => 1);
 ok($id,$msg);
 is(link_count($filename), 0, "scrips ok");
 
-($id,$msg) = $ticket->add_link(Type => 'RefersTo', target => $ticket2->id, Silentbase => 1);
+($id,$msg) = $ticket->add_link(type => 'RefersTo', target => $ticket2->id, Silentbase => 1);
 ok($id,$msg);
 is(link_count($filename), 1, "scrips ok");
 {
@@ -276,11 +276,11 @@
     is( $transactions->count, 3, "+1 txn on the target" );
 
 }
-($id,$msg) =$ticket->delete_link(Type => 'RefersTo', target => $ticket2->id, Silentbase => 1);
+($id,$msg) =$ticket->delete_link(type => 'RefersTo', target => $ticket2->id, Silentbase => 1);
 ok($id,$msg);
 is(link_count($filename), 0, "scrips ok");
 
-($id,$msg) = $ticket->add_link(Type => 'RefersTo', target => $ticket2->id, Silenttarget => 1);
+($id,$msg) = $ticket->add_link(type => 'RefersTo', target => $ticket2->id, Silenttarget => 1);
 ok($id,$msg);
 is(link_count($filename), 1, "scrips ok");
 {
@@ -292,7 +292,7 @@
     $transactions->limit( column => 'type', value => 'AddLink' );
     is( $transactions->count, 3, "three txns on the target" );
 }
-($id,$msg) =$ticket->delete_link(Type => 'RefersTo', target => $ticket2->id, Silenttarget => 1);
+($id,$msg) =$ticket->delete_link(type => 'RefersTo', target => $ticket2->id, Silenttarget => 1);
 ok($id,$msg);
 is(link_count($filename), 0, "scrips ok");
 

Modified: rt/branches/3.999-DANGEROUS/t/ticket/merge.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/merge.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/merge.t	Wed Jan 30 16:08:43 2008
@@ -82,9 +82,9 @@
     ok ($t3->id);
 
     my ($id,$val);
-    ($id,$val) = $t->add_link(Type => 'DependsOn', target => $t3->id);
+    ($id,$val) = $t->add_link(type => 'DependsOn', target => $t3->id);
     ok($id,$val);
-    ($id,$val) = $t2->add_link(Type => 'DependsOn', target => $t3->id);
+    ($id,$val) = $t2->add_link(type => 'DependsOn', target => $t3->id);
     ok($id,$val);
 
     ($id,$val) = $t->merge_into($t2->id);

Modified: rt/branches/3.999-DANGEROUS/t/ticket/sort_by_cf.t
==============================================================================
--- rt/branches/3.999-DANGEROUS/t/ticket/sort_by_cf.t	(original)
+++ rt/branches/3.999-DANGEROUS/t/ticket/sort_by_cf.t	Wed Jan 30 16:08:43 2008
@@ -36,26 +36,26 @@
                              queue => 0,
                              sort_order => 1,
                              description => q{Something to compare results for, since we can't guarantee ticket ID},
-                             Type=> 'FreeformSingle');
+                             type=> 'FreeformSingle');
 ok($ret, "Custom Field Order Created");
 
 ($ret, $msg) = $cfA->create( name => 'Alpha',
                              queue => $queue_obj->id,
                              sort_order => 1,
                              description => 'A Testing custom field',
-                             Type=> 'FreeformSingle');
+                             type=> 'FreeformSingle');
 ok($ret, "Custom Field Alpha Created");
 
 ($ret, $msg) = $cfB->create( name => 'Beta',
                              queue => $queue_obj->id,
                              description => 'A Testing custom field',
-                             Type=> 'FreeformSingle');
+                             type=> 'FreeformSingle');
 ok($ret, "Custom Field Beta Created");
 
 ($ret, $msg) = $cfC->create( name => 'Charlie',
                              queue => $queue_obj->id,
                              description => 'A Testing custom field',
-                             Type=> 'FreeformSingle');
+                             type=> 'FreeformSingle');
 ok($ret, "Custom Field Charlie Created");
 
 # ----- Create some tickets to test with.  Assign them some values to


More information about the Rt-commit mailing list