[Rt-commit] r10610 - in rt/branches/3.999-DANGEROUS/lib: . RT RT/Model
ruz at bestpractical.com
ruz at bestpractical.com
Wed Jan 30 19:31:35 EST 2008
Author: ruz
Date: Wed Jan 30 19:31:34 2008
New Revision: 10610
Modified:
rt/branches/3.999-DANGEROUS/lib/RT.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm
rt/branches/3.999-DANGEROUS/lib/RT/Record.pm
rt/branches/3.999-DANGEROUS/lib/RT/Reminders.pm
rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm
Log:
* fix t/ticket/linking.t
* fix calls to _new_transaction data and field arguments
Modified: rt/branches/3.999-DANGEROUS/lib/RT.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT.pm Wed Jan 30 19:31:34 2008
@@ -12,32 +12,32 @@
use vars qw($Config $System $nobody $Handle );
our $VERSION = '3.7.14';
-our $BASE_PATH = '/home/jesse/svk/3.999-DANGEROUS';
-our $EtcPath = '/home/jesse/svk/3.999-DANGEROUS/etc';
-our $BinPath = '/home/jesse/svk/3.999-DANGEROUS/bin';
-our $VarPath = '/home/jesse/svk/3.999-DANGEROUS/var';
-our $LocalPath = '/home/jesse/svk/3.999-DANGEROUS/local';
-our $LocalLibPath = '/home/jesse/svk/3.999-DANGEROUS/local/lib';
-our $LocalEtcPath = '/home/jesse/svk/3.999-DANGEROUS/local/etc';
-our $LocalLexiconPath = '/home/jesse/svk/3.999-DANGEROUS/local/po';
+our $BASE_PATH = '/home/cubic/projs/RT/3.999-DANGEROUS';
+our $EtcPath = '/home/cubic/projs/RT/3.999-DANGEROUS/etc';
+our $BinPath = '/home/cubic/projs/RT/3.999-DANGEROUS/bin';
+our $VarPath = '/home/cubic/projs/RT/3.999-DANGEROUS/var';
+our $LocalPath = '/home/cubic/projs/RT/3.999-DANGEROUS/local';
+our $LocalLibPath = '/home/cubic/projs/RT/3.999-DANGEROUS/local/lib';
+our $LocalEtcPath = '/home/cubic/projs/RT/3.999-DANGEROUS/local/etc';
+our $LocalLexiconPath = '/home/cubic/projs/RT/3.999-DANGEROUS/local/po';
our $LocalPluginPath = $LocalPath . "/plugins";
# $MasonComponentRoot is where your rt instance keeps its mason html files
-our $MasonComponentRoot = '/home/jesse/svk/3.999-DANGEROUS/html';
+our $MasonComponentRoot = '/home/cubic/projs/RT/3.999-DANGEROUS/html';
# $MasonLocalComponentRoot is where your rt instance keeps its site-local
# mason html files.
-our $MasonLocalComponentRoot = '/home/jesse/svk/3.999-DANGEROUS/local/html';
+our $MasonLocalComponentRoot = '/home/cubic/projs/RT/3.999-DANGEROUS/local/html';
# $MasonDataDir Where mason keeps its datafiles
-our $MasonDataDir = '/home/jesse/svk/3.999-DANGEROUS/var/mason_data';
+our $MasonDataDir = '/home/cubic/projs/RT/3.999-DANGEROUS/var/mason_data';
# RT needs to put session data (for preserving state between connections
# via the web interface)
-our $MasonSessionDir = '/home/jesse/svk/3.999-DANGEROUS/var/session_data';
+our $MasonSessionDir = '/home/cubic/projs/RT/3.999-DANGEROUS/var/session_data';
=head1 name
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Group.pm Wed Jan 30 19:31:34 2008
@@ -1256,11 +1256,11 @@
}
}
- my $Old = $self->SUPER::_value("$args{'Field'}");
+ my $Old = $self->SUPER::_value( $args{'column'} );
my ( $ret, $msg ) = $self->SUPER::_set(
- column => $args{'Field'},
- value => $args{'Value'}
+ column => $args{'column'},
+ value => $args{'value'}
);
#If we can't actually set the field to the value, don't record
@@ -1271,8 +1271,8 @@
my ( $Trans, $Msg, $TransObj ) = $self->_new_transaction(
type => $args{'TransactionType'},
- Field => $args{'Field'},
- new_value => $args{'Value'},
+ field => $args{'column'},
+ new_value => $args{'value'},
old_value => $Old,
time_taken => $args{'time_taken'},
);
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/Ticket.pm Wed Jan 30 19:31:34 2008
@@ -1258,7 +1258,7 @@
$self->_new_transaction(
type => 'AddWatcher',
new_value => $principal->id,
- Field => $args{'type'}
+ field => $args{'type'}
);
}
@@ -1392,7 +1392,7 @@
$self->_new_transaction(
type => 'del_watcher',
old_value => $principal->id,
- Field => $args{'type'}
+ field => $args{'type'}
);
}
@@ -2430,7 +2430,7 @@
unless ( $args{ 'Silent' . $direction } ) {
my ( $Trans, $Msg, $TransObj ) = $self->_new_transaction(
type => 'DeleteLink',
- Field => $LINKDIRMAP{ $args{'type'} }->{$direction},
+ field => $LINKDIRMAP{ $args{'type'} }->{$direction},
old_value => $remote_uri->uri || $remote_link,
time_taken => 0
);
@@ -2443,7 +2443,7 @@
my $OtherObj = $remote_uri->object;
my ( $val, $Msg ) = $OtherObj->_new_transaction(
type => 'DeleteLink',
- Field => $direction eq 'target'
+ field => $direction eq 'target'
? $LINKDIRMAP{ $args{'type'} }->{base}
: $LINKDIRMAP{ $args{'type'} }->{target},
old_value => $self->uri,
@@ -2572,7 +2572,7 @@
unless ( $args{ 'Silent' . $direction } ) {
my ( $Trans, $Msg, $TransObj ) = $self->_new_transaction(
type => 'AddLink',
- Field => $LINKDIRMAP{ $args{'type'} }->{$direction},
+ field => $LINKDIRMAP{ $args{'type'} }->{$direction},
new_value => $remote_uri->uri || $remote_link,
time_taken => 0
);
@@ -2585,7 +2585,7 @@
my $OtherObj = $remote_uri->object;
my ( $val, $msg ) = $OtherObj->_new_transaction(
type => 'AddLink',
- Field => $direction eq 'target'
+ field => $direction eq 'target'
? $LINKDIRMAP{ $args{'type'} }->{base}
: $LINKDIRMAP{ $args{'type'} }->{target},
new_value => $self->uri,
@@ -2962,7 +2962,7 @@
my ( $val, $msg ) = $self->_new_transaction(
type => $Type,
- Field => 'Owner',
+ field => 'Owner',
new_value => $NewOwnerObj->id,
old_value => $OldOwnerObj->id,
time_taken => 0,
@@ -3446,7 +3446,7 @@
my ( $Trans, $Msg, $TransObj ) = $self->_new_transaction(
type => $args{'transaction_type'},
- Field => $args{'column'},
+ field => $args{'column'},
new_value => $args{'value'},
old_value => $Old,
time_taken => $args{'time_taken'},
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Model/User.pm Wed Jan 30 19:31:34 2008
@@ -1294,7 +1294,7 @@
my ( $Trans, $Msg, $TransObj ) = $self->_new_transaction(
type => $args{'transaction_type'},
- Field => $args{'column'},
+ field => $args{'column'},
new_value => $args{'value'},
old_value => $Old,
time_taken => $args{'time_taken'},
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Record.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Record.pm Wed Jan 30 19:31:34 2008
@@ -1237,8 +1237,8 @@
old_reference => undef,
new_reference => undef,
reference_type => undef,
- Data => undef,
- Field => undef,
+ data => undef,
+ field => undef,
mime_obj => undef,
ActivateScrips => 1,
commit_scrips => 1,
@@ -1264,8 +1264,8 @@
object_type => ref($self),
time_taken => $args{'time_taken'},
type => $args{'type'},
- Data => $args{'Data'},
- Field => $args{'Field'},
+ data => $args{'data'},
+ field => $args{'field'},
new_value => $args{'new_value'},
old_value => $args{'old_value'},
new_reference => $new_ref,
@@ -1473,7 +1473,7 @@
my ( $transaction_id, $Msg, $transaction_obj )
= $self->_new_transaction(
type => 'CustomField',
- Field => $cf->id,
+ field => $cf->id,
old_reference => $value,
);
}
@@ -1535,7 +1535,7 @@
my ( $transaction_id, $Msg, $transaction_obj )
= $self->_new_transaction(
type => 'CustomField',
- Field => $cf->id,
+ field => $cf->id,
old_reference => $old_value,
new_reference => $new_value,
);
@@ -1575,7 +1575,7 @@
if ( $args{'record_transaction'} ) {
my ( $tid, $msg ) = $self->_new_transaction(
type => 'CustomField',
- Field => $cf->id,
+ field => $cf->id,
new_reference => $new_value_id,
reference_type => 'RT::Model::ObjectCustomFieldValue',
);
@@ -1628,7 +1628,7 @@
my ( $transaction_id, $Msg, $transaction_obj ) = $self->_new_transaction(
type => 'CustomField',
- Field => $cf->id,
+ field => $cf->id,
old_reference => $val,
reference_type => 'RT::Model::ObjectCustomFieldValue',
);
Modified: rt/branches/3.999-DANGEROUS/lib/RT/Reminders.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Reminders.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Reminders.pm Wed Jan 30 19:31:34 2008
@@ -112,16 +112,16 @@
my $self = shift;
my %args = (
subject => undef,
- Owner => undef,
- Due => undef,
+ owner => undef,
+ due => undef,
@_
);
my $reminder = RT::Model::Ticket->new;
$reminder->create(
subject => $args{'subject'},
- Owner => $args{'Owner'},
- Due => $args{'Due'},
+ owner => $args{'Owner'},
+ due => $args{'Due'},
RefersTo => $self->ticket,
type => 'reminder',
queue => $self->ticket_obj->queue,
@@ -129,7 +129,7 @@
);
$self->ticket_obj->_new_transaction(
type => 'AddReminder',
- column => 'RT::Model::Ticket',
+ field => 'RT::Model::Ticket',
new_value => $reminder->id
);
@@ -142,7 +142,7 @@
$reminder->set_status('open');
$self->ticket_obj->_new_transaction(
type => 'OpenReminder',
- column => 'RT::Model::Ticket',
+ field => 'RT::Model::Ticket',
new_value => $reminder->id
);
}
@@ -153,7 +153,7 @@
$reminder->set_status('resolved');
$self->ticket_obj->_new_transaction(
type => 'ResolveReminder',
- column => 'RT::Model::Ticket',
+ field => 'RT::Model::Ticket',
new_value => $reminder->id
);
}
Modified: rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm (original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/ScripAction/AutoOpen.pm Wed Jan 30 19:31:34 2008
@@ -88,10 +88,10 @@
$self->ticket_obj->__set( column => 'Status', value => 'open' );
$self->ticket_obj->_new_transaction(
type => 'Status',
- Field => 'Status',
+ field => 'Status',
old_value => $oldstatus,
new_value => 'open',
- Data => 'Ticket auto-opened on incoming correspondence'
+ data => 'Ticket auto-opened on incoming correspondence'
);
return 1;
More information about the Rt-commit
mailing list