[Rt-commit] r13930 - in rtfm/trunk: . html/Admin/RTFM/Elements html/RTFM/Article/Elements

falcone at bestpractical.com falcone at bestpractical.com
Wed Jul 9 16:45:42 EDT 2008


Author: falcone
Date: Wed Jul  9 16:45:41 2008
New Revision: 13930

Modified:
   rtfm/trunk/   (props changed)
   rtfm/trunk/html/Admin/RTFM/Classes/Modify.html
   rtfm/trunk/html/Admin/RTFM/Elements/Tabs
   rtfm/trunk/html/RTFM/Article/Elements/EditTopics

Log:
 r35344 at ketch:  falcone | 2008-07-09 16:45:01 -0400
 * quiet more warnings


Modified: rtfm/trunk/html/Admin/RTFM/Classes/Modify.html
==============================================================================
--- rtfm/trunk/html/Admin/RTFM/Classes/Modify.html	(original)
+++ rtfm/trunk/html/Admin/RTFM/Classes/Modify.html	Wed Jul  9 16:45:41 2008
@@ -156,7 +156,7 @@
 my $HotListChecked = $ClassObj->HotList ? "CHECKED" : "";
 
 my $current_subtab;
-if ($Create == 1) {
+if ($Create && $Create == 1) {
     $current_subtab = "Admin/RTFM/Classes/Modify.html?Create=1";
 } else { 
     $current_subtab = "Admin/RTFM/Classes/Modify.html?id=$id";

Modified: rtfm/trunk/html/Admin/RTFM/Elements/Tabs
==============================================================================
--- rtfm/trunk/html/Admin/RTFM/Elements/Tabs	(original)
+++ rtfm/trunk/html/Admin/RTFM/Elements/Tabs	Wed Jul  9 16:45:41 2008
@@ -62,11 +62,13 @@
                                 .$m->comp('/Elements/QueryString', type => 'RT::FM::Class-RT::FM::Article'),
                       },
 	     };
-  foreach my $tab (sort keys %{$tabs}) {
-    if ($tabs->{$tab}->{'path'} eq $current_tab) {
-      $tabs->{$tab}->{"subtabs"} = $subtabs;
-      $tabs->{$tab}->{"current_subtab"} = $current_subtab;
-    }
+  if (defined $current_tab) {
+      foreach my $tab (sort keys %{$tabs}) {
+        if ($tabs->{$tab}->{'path'} eq $current_tab) {
+          $tabs->{$tab}->{"subtabs"} = $subtabs;
+          $tabs->{$tab}->{"current_subtab"} = $current_subtab;
+        }
+      }
   }
 
 </%INIT>

Modified: rtfm/trunk/html/RTFM/Article/Elements/EditTopics
==============================================================================
--- rtfm/trunk/html/RTFM/Article/Elements/EditTopics	(original)
+++ rtfm/trunk/html/RTFM/Article/Elements/EditTopics	Wed Jul  9 16:45:41 2008
@@ -143,6 +143,6 @@
 <%ARGS>
 $ArticleObj => new RT::FM::Article($session{'CurrentUser'})
 @Classes => ()
- at Topics => undef
+ at Topics => ()
 $OnlyThisClass => undef
 </%ARGS>


More information about the Rt-commit mailing list