[Rt-commit] r15865 - in rt/branches/3.999-DANGEROUS: lib/RT/Interface/Web

sunnavy at bestpractical.com sunnavy at bestpractical.com
Tue Sep 9 06:32:17 EDT 2008


Author: sunnavy
Date: Tue Sep  9 06:32:16 2008
New Revision: 15865

Modified:
   rt/branches/3.999-DANGEROUS/   (props changed)
   rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Request.pm

Log:
 r16557 at sunnavys-mb:  sunnavy | 2008-09-09 18:31:23 +0800
 don't need our own alter_superclass since we have HTML::Mason 1.40+


Modified: rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Request.pm
==============================================================================
--- rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Request.pm	(original)
+++ rt/branches/3.999-DANGEROUS/lib/RT/Interface/Web/Request.pm	Tue Sep  9 06:32:16 2008
@@ -66,40 +66,6 @@
     return $class->SUPER::new(@_);
 }
 
-# XXX TODO: This alter_superclass replaces teh funcitonality in Mason 1.39
-# with code which doesn't trigger a bug in Perl 5.10.
-# (Perl 5.10.0 does NOT take kindly to having its @INC entries changed)
-# http://rt.perl.org/rt3/Public/Bug/Display.html?id=54566
-#
-# This routine can be removed when either:
-#   * RT depends on a version of mason which contains this fix
-#   * Perl 5.10.0 is not supported for running RT
-sub alter_superclass {
-    my $class     = shift;
-    my $new_super = shift;
-    my $isa_ref;
-    {
-        no strict 'refs';
-        my @entries = @{ $class . "::ISA" };
-        $isa_ref = \@entries;
-    }
-
-    # handles multiple inheritance properly and preserve
-    # inheritance order
-    for ( my $x = 0 ; $x <= $#{$isa_ref} ; $x++ ) {
-        if ( $isa_ref->[$x]->isa('HTML::Mason::Request') ) {
-            my $old_super = $isa_ref->[$x];
-            $isa_ref->[$x] = $new_super
-              if ( $old_super ne $new_super );
-            last;
-        }
-    }
-
-    { no strict 'refs'; @{ $class . "::ISA" } = @$isa_ref; }
-    $class->valid_params( %{ $class->valid_params } );
-}
-
-
 =head2 callback
 
 Method replaces deprecated component C<Element/Callback>.


More information about the Rt-commit mailing list