[Rt-commit] rt branch, admin_ui, updated. 8c0de72089d40cd91f48d44baa63cc50dbc7a4a8

[sunnavy at bestpractical.com]

The branch, admin_ui has been updated
       via  8c0de72089d40cd91f48d44baa63cc50dbc7a4a8 (commit)
      from  3c4c1f0dce86a25ad6b876b27784b48242a4a83d (commit)

Summary of changes:
 lib/RT/Action/SelectWorkflowMappings.pm |   37 -------------------------------
 lib/RT/View/Admin/Global/Workflows.pm   |   23 ++++++++++---------
 2 files changed, 12 insertions(+), 48 deletions(-)
 delete mode 100644 lib/RT/Action/SelectWorkflowMappings.pm

- Log -----------------------------------------------------------------
commit 8c0de72089d40cd91f48d44baa63cc50dbc7a4a8
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Dec 17 12:06:14 2009 +0800

    no need SelectWorkflowMappings action

diff --git a/lib/RT/Action/SelectWorkflowMappings.pm b/lib/RT/Action/SelectWorkflowMappings.pm
deleted file mode 100644
index 0dd3b03..0000000
--- a/lib/RT/Action/SelectWorkflowMappings.pm
+++ /dev/null
@@ -1,37 +0,0 @@
-use strict;
-use warnings;
-
-package RT::Action::SelectWorkflowMappings;
-use base qw/RT::Action Jifty::Action/;
-use RT::Workflow;
-use Scalar::Defer;
-
-sub arguments {
-    my $self = shift;
-    my $args = {};
-    for (qw/from to/) {
-        $args->{$_} = {
-            render_as     => 'Select',
-            available_values => defer { [ RT::Workflow->list ] }
-        };
-    }
-    return $args;
-}
-
-=head2 take_action
-
-=cut
-
-sub take_action {
-    my $self = shift;
-
-    my $from = $self->argument_value('from');
-    my $to   = $self->argument_value('to');
-    return unless $from && $to;
-    Jifty->web->_redirect(
-        "/admin/global/workflows/mappings?from=$from&to=$to&",
-    );
-}
-
-1;
-
diff --git a/lib/RT/View/Admin/Global/Workflows.pm b/lib/RT/View/Admin/Global/Workflows.pm
index 30158b0..354b292 100644
--- a/lib/RT/View/Admin/Global/Workflows.pm
+++ b/lib/RT/View/Admin/Global/Workflows.pm
@@ -353,18 +353,19 @@ template 'mappings' => page {
     }
     else {
         show('missing_maps');
-        if ( !$from || !$to ) {
-            my $moniker = 'select_workflow_mappings';
-            my $action  = new_action(
-                class   => 'SelectWorkflowMappings',
-                moniker => $moniker,
-            );
-            with( name => $moniker ), form {
-                render_action($action);
-                form_submit( label => _('Select') );
+        form {
+            outs(_('From: '));
+            select { attr { name => 'from' };
+                option { attr { value => $_ } _($_) } for @list;
             };
-        }
-        else {
+            outs( _('To: '));
+            select { attr { name => 'to' };
+                option { attr { value => $_ } _($_) } for @list;
+            };
+            form_submit( label => _('Select') );
+        };
+
+        if ( $from && $to ) {
             my $moniker = 'modify_workflow_mappings';
             my $action  = new_action(
                 class   => 'EditWorkflowMappings',

-----------------------------------------------------------------------