[Rt-commit] r18726 - in rt/3.999/trunk: lib/RT/Model

[ruz at bestpractical.com]

Author: ruz
Date: Thu Mar  5 23:24:14 2009
New Revision: 18726

Modified:
   rt/3.999/trunk/lib/RT/Model/Group.pm
   rt/3.999/trunk/t/api/group.t

Log:
* oops, I've reversed recursive logic

Modified: rt/3.999/trunk/lib/RT/Model/Group.pm
==============================================================================
--- rt/3.999/trunk/lib/RT/Model/Group.pm	(original)
+++ rt/3.999/trunk/lib/RT/Model/Group.pm	Thu Mar  5 23:24:14 2009
@@ -970,13 +970,13 @@
     return undef unless $id;
 
     my $class = $args{'recursively'}
-        ? 'RT::Model::GroupMember'
-        : 'RT::Model::CachedGroupMember';
+        ? 'RT::Model::CachedGroupMember'
+        : 'RT::Model::GroupMember';
 
     my $member_obj = new $class;
     $member_obj->load_by_cols(
         member_id => $id,
-        group_id  => $self->id
+        group_id  => $self->id,
     );
 
     if ( my $member_id = $member_obj->id ) {

Modified: rt/3.999/trunk/t/api/group.t
==============================================================================
--- rt/3.999/trunk/t/api/group.t	(original)
+++ rt/3.999/trunk/t/api/group.t	Thu Mar  5 23:24:14 2009
@@ -25,9 +25,9 @@
 
 ok (($id,$msg) = $ng->add_member('1'), "Added a member to the group");
 ok($id, $msg);
-ok (($id,$msg) = $ng->add_member('2' ), "Added a member to the group");
+ok (($id,$msg) = $ng->add_member('2'), "Added a member to the group");
 ok($id, $msg);
-ok (($id,$msg) = $ng->add_member('3' ), "Added a member to the group");
+ok (($id,$msg) = $ng->add_member('3'), "Added a member to the group");
 ok($id, $msg);
 
 # Group 1 now has members 1, 2 ,3