[Rt-commit] r19606 - in rt/3.8/branches/forward-with-transaction: etc

[falcone at bestpractical.com]

Author: falcone
Date: Fri May  8 18:01:06 2009
New Revision: 19606

Modified:
   rt/3.8/branches/forward-with-transaction/etc/RT_Config.pm.in
   rt/3.8/branches/forward-with-transaction/share/html/Elements/MessageBox

Log:
don't wrap textareas when using the RichText editor

hlb discovered that wrap="" causes some really incredible
IE bugs on all versions (6-8) when reloading a page (such
as adding an additional attachment or using RTFM) or when
creating a ticket with a user that has a signature.

Modified: rt/3.8/branches/forward-with-transaction/etc/RT_Config.pm.in
==============================================================================
--- rt/3.8/branches/forward-with-transaction/etc/RT_Config.pm.in	(original)
+++ rt/3.8/branches/forward-with-transaction/etc/RT_Config.pm.in	Fri May  8 18:01:06 2009
@@ -886,6 +886,10 @@
 
 Default wrapping: "HARD"  (choices "SOFT", "HARD")
 
+Wrapping is disabled when using MessageBoxRichText because
+of a bad interaction between IE and wrapping with the Rich
+Text Editor.
+
 =cut
 
 Set($MessageBoxWrap, "HARD");

Modified: rt/3.8/branches/forward-with-transaction/share/html/Elements/MessageBox
==============================================================================
--- rt/3.8/branches/forward-with-transaction/share/html/Elements/MessageBox	(original)
+++ rt/3.8/branches/forward-with-transaction/share/html/Elements/MessageBox	Fri May  8 18:01:06 2009
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<textarea class="messagebox" cols="<% $Width %>" rows="<% $Height %>" wrap="<% $Wrap %>" name="<% $Name %>" id="<% $Name %>">\
+<textarea class="messagebox" cols="<% $Width %>" rows="<% $Height %>" <% $wrap_type %> name="<% $Name %>" id="<% $Name %>">\
 % $m->callback( %ARGS );
 <% $Default || '' %><% $message %><% $signature %></textarea>
 % $m->callback( %ARGS, CallbackName => 'AfterTextArea' );
@@ -64,6 +64,12 @@
 	$signature = "-- \n". $text;
 }
 
+# wrap="something" seems to really break IE + richtext
+my $wrap_type;
+if ( not RT->Config->Get('MessageBoxRichText',  $session{'CurrentUser'}) ) {
+    $wrap_type = qq(wrap="$Wrap");
+}
+
 </%INIT>
 <%ARGS>
 $QuoteTransaction => undef