[Rt-commit] rt branch, create-action, updated. 68a0be13704109180b7fd6409c3b7aecb8a66da4

sartak at bestpractical.com sartak at bestpractical.com
Mon Nov 9 18:08:18 EST 2009


The branch, create-action has been updated
       via  68a0be13704109180b7fd6409c3b7aecb8a66da4 (commit)
      from  1bf6b54164f888e16c6f6142a4b44b07a13af8cc (commit)

Summary of changes:
 lib/RT/Model/Transaction.pm |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

- Log -----------------------------------------------------------------
commit 68a0be13704109180b7fd6409c3b7aecb8a66da4
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon Nov 9 18:08:05 2009 -0500

    Kill old bad API

diff --git a/lib/RT/Model/Transaction.pm b/lib/RT/Model/Transaction.pm
index 49c7a84..c003dd1 100755
--- a/lib/RT/Model/Transaction.pm
+++ b/lib/RT/Model/Transaction.pm
@@ -1158,21 +1158,6 @@ sub update_custom_fields {
     my $self = shift;
     my %args = (@_);
 
-    # This method used to have an API that took a hash of a single
-    # value "args_ref", which was a reference to a hash of arguments.
-    # This was insane. The next few lines of code preserve that API
-    # while giving us something saner.
-
-    # TODO: 3.6: DEPRECATE OLD API
-
-    my $args;
-
-    if ( $args{'args_ref'} ) {
-        $args = $args{args_ref};
-    } else {
-        $args = \%args;
-    }
-
     foreach my $arg ( keys %$args ) {
         next
             unless ( $arg =~ /^(?:object-RT::Model::Transaction--)?CustomField-(\d+)/ );

-----------------------------------------------------------------------


More information about the Rt-commit mailing list