[Rt-commit] rt branch, 3.999-trunk, updated. 72c3edcb7492c6494f94bac38f356bd1efa3fec2

sunnavy at bestpractical.com sunnavy at bestpractical.com
Tue Nov 10 22:49:14 EST 2009


The branch, 3.999-trunk has been updated
       via  72c3edcb7492c6494f94bac38f356bd1efa3fec2 (commit)
       via  966e2a4af4b98cc2bd46992acc705024ead99728 (commit)
      from  8fce162bfb508f4773f6fddd1e74b4a6693d7508 (commit)

Summary of changes:
 lib/RT/Dispatcher.pm                               |    2 +-
 share/html/Admin/Elements/ObjectCustomFields       |    8 +++-----
 .../Admin/Global/Workflows/Elements/MissingMaps    |    2 +-
 share/html/Admin/Global/Workflows/Elements/Tabs    |    6 +++---
 share/html/Admin/Global/Workflows/Interface.html   |    4 ++--
 share/html/Admin/Global/Workflows/Mappings.html    |    8 ++++----
 share/html/Admin/Global/Workflows/Statuses.html    |    4 ++--
 share/html/Admin/Global/Workflows/Summary.html     |    2 +-
 share/html/Admin/Global/Workflows/Transitions.html |    4 ++--
 share/html/Admin/Global/Workflows/index.html       |    4 ++--
 share/html/Admin/Users/Memberships.html            |    3 +--
 share/html/Admin/Users/Modify.html                 |    4 ++--
 share/html/Dashboards/Render.html                  |    2 +-
 share/html/Dashboards/Subscription.html            |    2 +-
 share/html/Search/Elements/ResultViews             |    4 ++--
 share/html/Widgets/SavedSearch                     |    2 +-
 t/mail/sendmail.t                                  |    6 +++---
 17 files changed, 32 insertions(+), 35 deletions(-)

- Log -----------------------------------------------------------------
commit 966e2a4af4b98cc2bd46992acc705024ead99728
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Nov 11 11:42:59 2009 +0800

    fix uninitialized warnings

diff --git a/share/html/Admin/Elements/ObjectCustomFields b/share/html/Admin/Elements/ObjectCustomFields
index 8d13a75..6ace3e9 100644
--- a/share/html/Admin/Elements/ObjectCustomFields
+++ b/share/html/Admin/Elements/ObjectCustomFields
@@ -60,11 +60,9 @@ $id ? (
 
 <& /Admin/Elements/EditCustomFields, %ARGS, title => $title, object => $object &>
 <%INIT>
-# XXX TODO: Validate here?
-#$object_type =~ /^RT::(queue|User|Group)$/
-#    or abort(_("object of type %1 cannot take custom fields", $object_type), SuppressHeader => 1);
-
-
+ XXX TODO: Validate here?
+$object_type =~ /^RT::Model::(Queue|User|Group)$/
+    or abort(_("object of type %1 cannot take custom fields", $object_type), suppress_header => 1);
 
 my $Type = $1;
 my $Types = $Type.'s';
diff --git a/share/html/Admin/Global/Workflows/Elements/MissingMaps b/share/html/Admin/Global/Workflows/Elements/MissingMaps
index 18c1e7c..1fe819f 100644
--- a/share/html/Admin/Global/Workflows/Elements/MissingMaps
+++ b/share/html/Admin/Global/Workflows/Elements/MissingMaps
@@ -19,5 +19,5 @@ if ( $schema ) {
 return unless @maps;
 </%INIT>
 <%ARGS>
-$schema => undef
+$schema => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/Elements/Tabs b/share/html/Admin/Global/Workflows/Elements/Tabs
index 9df2cce..76adeaf 100644
--- a/share/html/Admin/Global/Workflows/Elements/Tabs
+++ b/share/html/Admin/Global/Workflows/Elements/Tabs
@@ -58,7 +58,7 @@ else {
 
 </%INIT>
 <%ARGS>
-$schema      => undef
-$title       => undef
-$current_tab => undef
+$schema      => ''
+$title       => ''
+$current_tab => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/Interface.html b/share/html/Admin/Global/Workflows/Interface.html
index 31028b2..be8f9bf 100644
--- a/share/html/Admin/Global/Workflows/Interface.html
+++ b/share/html/Admin/Global/Workflows/Interface.html
@@ -85,6 +85,6 @@ if ( $update ) {
 
 </%INIT>
 <%ARGS>
-$name => undef
-$update => undef
+$name => ''
+$update => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/Mappings.html b/share/html/Admin/Global/Workflows/Mappings.html
index 7be09a0..2a7244d 100644
--- a/share/html/Admin/Global/Workflows/Mappings.html
+++ b/share/html/Admin/Global/Workflows/Mappings.html
@@ -117,8 +117,8 @@ if ( $update && $from_schema && $to_schema ) {
 
 </%INIT>
 <%ARGS>
-$from   => undef
-$to     => undef
-$update => undef
-$select => undef
+$from   => ''
+$to     => ''
+$update => ''
+$select => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/Statuses.html b/share/html/Admin/Global/Workflows/Statuses.html
index c5a98aa..2b93d90 100644
--- a/share/html/Admin/Global/Workflows/Statuses.html
+++ b/share/html/Admin/Global/Workflows/Statuses.html
@@ -54,6 +54,6 @@ if ( $update ) {
 
 </%INIT>
 <%ARGS>
-$name => undef
-$update => undef
+$name => ''
+$update => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/Summary.html b/share/html/Admin/Global/Workflows/Summary.html
index 3d001e2..896e412 100644
--- a/share/html/Admin/Global/Workflows/Summary.html
+++ b/share/html/Admin/Global/Workflows/Summary.html
@@ -85,5 +85,5 @@ my @all_maps = RT::Workflow->list;
 
 </%INIT>
 <%ARGS>
-$name => undef
+$name => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/Transitions.html b/share/html/Admin/Global/Workflows/Transitions.html
index 772ede3..ce2dee9 100644
--- a/share/html/Admin/Global/Workflows/Transitions.html
+++ b/share/html/Admin/Global/Workflows/Transitions.html
@@ -58,6 +58,6 @@ if ( $update ) {
 
 </%INIT>
 <%ARGS>
-$name => undef
-$update => undef
+$name => ''
+$update => ''
 </%ARGS>
diff --git a/share/html/Admin/Global/Workflows/index.html b/share/html/Admin/Global/Workflows/index.html
index b1c5036..10763da 100644
--- a/share/html/Admin/Global/Workflows/index.html
+++ b/share/html/Admin/Global/Workflows/index.html
@@ -49,6 +49,6 @@ if ( $create ) {
 
 </%INIT>
 <%ARGS>
-$name => undef
-$create => undef 
+$name => ''
+$create => '' 
 </%ARGS>
diff --git a/share/html/Admin/Users/Memberships.html b/share/html/Admin/Users/Memberships.html
index f31bc40..95179e7 100644
--- a/share/html/Admin/Users/Memberships.html
+++ b/share/html/Admin/Users/Memberships.html
@@ -134,8 +134,7 @@ $format ||= q{'<a href="__WebPath__/Admin/Groups/Modify.html?id=__id__">__id__</
     .q{,'__description__'};
 </%INIT>
 <%ARGS>
-$id     => undef
-
+$id     => ''
 $update => 0,
 @add    => (),
 @delete => (),
diff --git a/share/html/Admin/Users/Modify.html b/share/html/Admin/Users/Modify.html
index cf8bc34..82e8133 100755
--- a/share/html/Admin/Users/Modify.html
+++ b/share/html/Admin/Users/Modify.html
@@ -390,8 +390,8 @@ $id = $user_object->id;
 
 
 <%ARGS>
-$id => undef
-$name  => undef
+$id => ''
+$name  => ''
 $comments  => undef
 $signature  => undef
 $email  => undef
diff --git a/share/html/Dashboards/Render.html b/share/html/Dashboards/Render.html
index 347a01d..cbded2e 100644
--- a/share/html/Dashboards/Render.html
+++ b/share/html/Dashboards/Render.html
@@ -110,7 +110,7 @@ my $show_cb = sub {
 
 </%INIT>
 <%ARGS>
-$id => undef
+$id => ''
 $preview => 1
 </%ARGS>
 
diff --git a/share/html/Dashboards/Subscription.html b/share/html/Dashboards/Subscription.html
index 577d7bb..9075934 100644
--- a/share/html/Dashboards/Subscription.html
+++ b/share/html/Dashboards/Subscription.html
@@ -278,7 +278,7 @@ else {
 
 </%INIT>
 <%ARGS>
-$dashboard_id => undef
+$dashboard_id => ''
 $frequency   => undef
 $hour        => undef
 $dow         => undef
diff --git a/share/html/Search/Elements/ResultViews b/share/html/Search/Elements/ResultViews
index dcd4aa4..9d0f146 100644
--- a/share/html/Search/Elements/ResultViews
+++ b/share/html/Search/Elements/ResultViews
@@ -75,6 +75,6 @@ $short_query_string => undef
 <%init>
 my $ical_path = join '/', map $m->interp->apply_escapes($_, 'u'),
     Jifty->web->current_user->user_object->name,
-    Jifty->web->current_user->user_object->generate_auth_string( $query ),
-    $query;
+    Jifty->web->current_user->user_object->generate_auth_string( $query || '' ),
+    $query || '';
 </%init>
diff --git a/share/html/Widgets/SavedSearch b/share/html/Widgets/SavedSearch
index bf421e9..72dc649 100644
--- a/share/html/Widgets/SavedSearch
+++ b/share/html/Widgets/SavedSearch
@@ -136,7 +136,7 @@ $args
 <%method show>
 <form method="post" action="<% $action %>" name="save_search">
 <& /Search/Elements/EditSearches,
-    id            => $self->{Searchid},
+    id            => $self->{SearchId},
     type          => $self->{SearchType},
     current_search => $self->{CurrentSearch},
     title         => $title,
diff --git a/t/mail/sendmail.t b/t/mail/sendmail.t
index 2235825..ce9d16d 100644
--- a/t/mail/sendmail.t
+++ b/t/mail/sendmail.t
@@ -301,7 +301,7 @@ sub text_html_redef_sendmessage {
     eval 'sub RT::ScripAction::SendEmail::send_message { 
                 my $self = shift;
                 my $MIME = shift;
-                return (1) unless ($self->hints->{source_scripaction_name} eq "Notify AdminCcs" );
+                return (1) unless ( $self->hints->{source_scrip_action_name} && $self->hints->{source_scripaction_name} eq "Notify AdminCcs" );
                 is ($MIME->parts, 0, "generated correspondence mime entity
                         does not have parts");
                 is ($MIME->head->mime_type , "text/plain", "The mime type is a plain");
@@ -366,7 +366,7 @@ sub text_plain_russian_redef_sendmessage {
     eval 'sub RT::ScripAction::SendEmail::send_message { 
                 my $self = shift; 
                 my $MIME = shift; 
-                return (1) unless ($self->hints->{source_scripaction_name} eq "Notify AdminCcs" );
+                return (1) unless ( $self->hints->{source_scripaction_name} && $self->hints->{source_scripaction_name} eq "Notify AdminCcs" );
                 is ($MIME->head->mime_type , "text/plain", "The only part is text/plain ");
                  my $subject  = $MIME->head->get("subject");
                 chomp($subject);
@@ -409,7 +409,7 @@ sub text_plain_nested_redef_sendmessage {
     eval 'sub RT::ScripAction::SendEmail::send_message { 
                 my $self = shift; 
                 my $MIME = shift; 
-                return (1) unless ($self->hints->{source_scripaction_name} eq "Notify AdminCcs" );
+                return (1) unless ( $self->hints->{source_scrip_action_name} && $self->hints->{source_scrip_action_name} eq "Notify AdminCcs" );
                 is ($MIME->head->mime_type , "multipart/mixed", "It is a mixed multipart");
                  my $subject  =  $MIME->head->get("subject");
                  $subject  = MIME::Base64::decode_base64( $subject);

commit 72c3edcb7492c6494f94bac38f356bd1efa3fec2
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Nov 11 11:45:17 2009 +0800

    warning fix

diff --git a/lib/RT/Dispatcher.pm b/lib/RT/Dispatcher.pm
index 485d2f4..5877296 100644
--- a/lib/RT/Dispatcher.pm
+++ b/lib/RT/Dispatcher.pm
@@ -180,7 +180,7 @@ on qr{^/Ticket/Graphs/(\d+)} => run {
 
 before qr{^/Search/Build.html} => run {
     my $querystring      = '';
-    my $selected_clauses = Jifty->web->request->argument('clauses');
+    my $selected_clauses = Jifty->web->request->argument('clauses') || 0;
     my ( $saved_search, $current_search, $results ) = RT::Interface::Web::QueryBuilder->setup_query();
 
     my $tree = RT::Interface::Web::QueryBuilder::Tree->new('AND');

-----------------------------------------------------------------------


More information about the Rt-commit mailing list