[Rt-commit] rt branch, create-action, updated. 0df2a4957574c4f3378f244a475e3fec92aa359e

sartak at bestpractical.com sartak at bestpractical.com
Wed Oct 7 15:08:05 EDT 2009


The branch, create-action has been updated
       via  0df2a4957574c4f3378f244a475e3fec92aa359e (commit)
       via  8685c82a6048303d9118a382bc9845f452d75540 (commit)
      from  94834487bbaafcc97fea1bc6c1cb32ff8b7053de (commit)

Summary of changes:
 lib/RT/Action/CreateTicket.pm         |    2 +-
 lib/RT/View/Form/Field/SelectOwner.pm |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 8685c82a6048303d9118a382bc9845f452d75540
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Wed Oct 7 15:05:15 2009 -0400

    Pass just nobody's ID not his object

diff --git a/lib/RT/Action/CreateTicket.pm b/lib/RT/Action/CreateTicket.pm
index 92ffcbb..39888ee 100644
--- a/lib/RT/Action/CreateTicket.pm
+++ b/lib/RT/Action/CreateTicket.pm
@@ -17,7 +17,7 @@ use Jifty::Action schema {
     param owner =>
         render as 'RT::View::Form::Field::SelectOwner',
         # valid_values are queue-specific
-        valid_values are lazy { RT->nobody },
+        valid_values are lazy { RT->nobody->id },
         label is _('Owner');
 
     param subject =>

commit 0df2a4957574c4f3378f244a475e3fec92aa359e
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Wed Oct 7 15:07:34 2009 -0400

    Jifty wraps the value in a display/value hashref

diff --git a/lib/RT/View/Form/Field/SelectOwner.pm b/lib/RT/View/Form/Field/SelectOwner.pm
index 2b64612..3f8192a 100644
--- a/lib/RT/View/Form/Field/SelectOwner.pm
+++ b/lib/RT/View/Form/Field/SelectOwner.pm
@@ -11,6 +11,7 @@ sub _render_select_values {
 
     my $current_value = $self->current_value;
     for my $value ($self->available_values) {
+        $value = $value->{value} if ref($value) eq 'HASH';
         $value = "" unless defined $value;
         $rendered .= qq!<option value="@{[ Jifty->web->escape($value) ]}"!;
         $rendered .= qq! selected="selected"!

-----------------------------------------------------------------------


More information about the Rt-commit mailing list