[Rt-commit] rt branch, lcore, updated. 9ad9c66087d4266e726f83cd3b7da9e2d61bd6e5

jesse jesse at bestpractical.com
Wed Oct 7 20:38:11 EDT 2009


The branch, lcore has been updated
       via  9ad9c66087d4266e726f83cd3b7da9e2d61bd6e5 (commit)
      from  0202a0e8a1e9f781ba8ffbb7fb5e802203ad240b (commit)

Summary of changes:
 lib/RT/View/Form/Field/RuleTextarea.pm |    4 ++--
 share/web/static/js/rulebuilder.js     |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 9ad9c66087d4266e726f83cd3b7da9e2d61bd6e5
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Wed Oct 7 20:37:35 2009 -0400

    Now we get the right content into the visual rule editor
    
     (there was a
    small error in the jQuery code that caused us to only get the _original_
    code)

diff --git a/lib/RT/View/Form/Field/RuleTextarea.pm b/lib/RT/View/Form/Field/RuleTextarea.pm
index c003375..3f3db3e 100644
--- a/lib/RT/View/Form/Field/RuleTextarea.pm
+++ b/lib/RT/View/Form/Field/RuleTextarea.pm
@@ -13,14 +13,14 @@ sub render_widget {
 
 sub render_rulebuilder_launcher {
 	Jifty->web->out('
-<input type="submit" value="Edit!" onclick="RuleBuilder.load_and_edit_lambda([
+<input type="submit" value="Edit!" onClick="RuleBuilder.load_and_edit_lambda([
     { expression: \'ticket\',
       type: \'RT::Model::Ticket\'
     },
     { expression: \'transaction\',
       type: \'RT::Model::Transaction\'
     }
-], \'Bool\', this) ;"/>
+], \'Bool\', this);"/>
 
 
 		');
diff --git a/share/web/static/js/rulebuilder.js b/share/web/static/js/rulebuilder.js
index 3e7e2f7..ae5784c 100644
--- a/share/web/static/js/rulebuilder.js
+++ b/share/web/static/js/rulebuilder.js
@@ -24,7 +24,7 @@ RuleBuilder.expressions = [
 ];
 
 RuleBuilder.load_and_edit_lambda = function (params, return_type, el) {
-    var lambda_text = jQuery(el).prev('textarea').text();
+    var lambda_text = jQuery(el).prev('textarea').val();
     jQuery.post('/rulebuilder/parse_lambda.json', { lambda_text: lambda_text },
                function(response, status) {
                    var rb = new RuleBuilder("#expressionbuilder",

-----------------------------------------------------------------------


More information about the Rt-commit mailing list