[Rt-commit] rt branch, 3.999-trunk, updated. 006ee9071a6dec05d945742072bff880fd72e624

jesse jesse at bestpractical.com
Tue Oct 13 13:43:14 EDT 2009


The branch, 3.999-trunk has been updated
       via  006ee9071a6dec05d945742072bff880fd72e624 (commit)
      from  9981e5c1ce70b9c51d2616e9e118bb5f1d9a41f9 (commit)

Summary of changes:
 share/html/Elements/CollectionList     |    2 --
 share/html/Elements/Header             |    1 -
 share/html/Ticket/Elements/ShowHistory |    3 ---
 share/html/Widgets/TitleBoxEnd         |    3 ---
 4 files changed, 0 insertions(+), 9 deletions(-)

- Log -----------------------------------------------------------------
commit 006ee9071a6dec05d945742072bff880fd72e624
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Oct 13 13:42:58 2009 -0400

    $m->flush_buffer is incompatible with the new world order

diff --git a/share/html/Elements/CollectionList b/share/html/Elements/CollectionList
index 24a0de0..015a424 100644
--- a/share/html/Elements/CollectionList
+++ b/share/html/Elements/CollectionList
@@ -128,8 +128,6 @@ if ( $show_header ) {
 
 my ($i, $column_map) = (0, {});
 while ( my $record = $collection->next ) {
-    # Every ten rows, flush the buffer and put something on the page.
-    $m->flush_buffer unless ++$i % 10;
     $m->comp('/Elements/CollectionAsTable/Row',
         i => $i,
         format => \@format,
diff --git a/share/html/Elements/Header b/share/html/Elements/Header
index c9b3b5f..b52c024 100755
--- a/share/html/Elements/Header
+++ b/share/html/Elements/Header
@@ -109,7 +109,6 @@
 <div id="body">
 % }
 % $m->callback( %ARGS, callback_name => 'BeforeBody' );
-% $m->flush_buffer(); # we've got the page laid out, let's flush the buffer;
 
 <%INIT>
 $r->content_type('text/html; charset=utf-8');
diff --git a/share/html/Ticket/Elements/ShowHistory b/share/html/Ticket/Elements/ShowHistory
index a2cd1bf..c8cca70 100755
--- a/share/html/Ticket/Elements/ShowHistory
+++ b/share/html/Ticket/Elements/ShowHistory
@@ -123,9 +123,6 @@ while ( my $Transaction = $Transactions->next ) {
               last_transaction      => $IsLastTransaction,
  );
 
-# manually flush the content buffer after each txn, so the user sees
-# some update
-$m->flush_buffer(); 
 }
 
 </%perl>
diff --git a/share/html/Widgets/TitleBoxEnd b/share/html/Widgets/TitleBoxEnd
index 8f7301e..b5ebefc 100755
--- a/share/html/Widgets/TitleBoxEnd
+++ b/share/html/Widgets/TitleBoxEnd
@@ -49,9 +49,6 @@
   </div>
 </div>
 
-% #Manually flush the content buffer after each titlebox is displayed
-% $m->flush_buffer();
-
 <%ARGS>
 $title => undef
 $content => undef

-----------------------------------------------------------------------


More information about the Rt-commit mailing list