[Rt-commit] rt branch, 3.999-trunk, updated. 21322e26734dd1ba5f4998ef5a7bb3cec16e0feb

clkao at bestpractical.com clkao at bestpractical.com
Fri Oct 23 10:45:22 EDT 2009


The branch, 3.999-trunk has been updated
       via  21322e26734dd1ba5f4998ef5a7bb3cec16e0feb (commit)
      from  4146043229a8be1823577d542bfc5c6aa42d9657 (commit)

Summary of changes:
 lib/RT/Graph/Tickets.pm           |    2 +-
 t/ticket/cfsort-freeform-single.t |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 21322e26734dd1ba5f4998ef5a7bb3cec16e0feb
Author: Chia-liang Kao <clkao at bestpractical.com>
Date:   Fri Oct 23 22:45:08 2009 +0800

    order_by should be called with column, not field.

diff --git a/lib/RT/Graph/Tickets.pm b/lib/RT/Graph/Tickets.pm
index b90332f..10c706f 100644
--- a/lib/RT/Graph/Tickets.pm
+++ b/lib/RT/Graph/Tickets.pm
@@ -165,7 +165,7 @@ sub ticket_properties {
     );
     my $cfs = RT::Model::CustomFieldCollection->new(current_user => $user);
     $cfs->limit_to_lookup_type('RT::Model::Queue-RT::Model::Ticket');
-    $cfs->order_by( field => 'name' );
+    $cfs->order_by( column => 'name' );
     my ( $first, %seen ) = (1);
     while ( my $cf = $cfs->next ) {
         next if $seen{ lc $cf->name }++;
diff --git a/t/ticket/cfsort-freeform-single.t b/t/ticket/cfsort-freeform-single.t
index 32262bd..6e85856 100644
--- a/t/ticket/cfsort-freeform-single.t
+++ b/t/ticket/cfsort-freeform-single.t
@@ -85,7 +85,7 @@ sub run_tests {
             my $error = 0;
             my $tix = RT::Model::TicketCollection->new(current_user => RT->system_user );
             $tix->from_sql( $query );
-            $tix->order_by( field => $test->{'Order'}, order => $order );
+            $tix->order_by( column => $test->{'Order'}, order => $order );
 
             ok($tix->count, "found ticket(s)")
                 or $error = 1;

-----------------------------------------------------------------------


More information about the Rt-commit mailing list