[Rt-commit] rtir branch, 2.5-greenville, created. eaa53cef6817a0359ae4c2bd1b095af555fe599b

[Kevin Falcone]

The branch, 2.5-greenville has been created
        at  eaa53cef6817a0359ae4c2bd1b095af555fe599b (commit)

- Log -----------------------------------------------------------------
commit fb28dd37f423cce78f84823a57fc615e443c51ab
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Aug 28 16:38:18 2009 -0400

    Switch simplesearch over to the buttonless version from rt-3.8
    
    On IE and smaller resolutions, this stops the menu bar from wrapping
    really oddly by svaing us some space.

diff --git a/html/RTIR/Elements/SimpleSearch b/html/RTIR/Elements/SimpleSearch
index cfcb7d3..f28d310 100644
--- a/html/RTIR/Elements/SimpleSearch
+++ b/html/RTIR/Elements/SimpleSearch
@@ -24,6 +24,5 @@
 <form action="<% RT->Config->Get('WebPath') %>/RTIR/index.html" id="simple-search">
 <input type="hidden" name="NewSearch" value="1" />
 <input type="hidden" name="Queue" value="Incidents" />
-<input size="12" name="q" accesskey="0" />
-<input type="submit" class="button" value="<&|/l&>Search Incidents</&>" />&nbsp;
+<input size="15" name="q" accesskey="0" value="<&|/l&>Search Incidents</&>..." onfocus="if (this.value=='<&|/l&>Search Incidents</&>...') this.value=''" />
 </form>

commit 02cee56a0ebcb7bf16f77c90c0504ca16d20b47d
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri Aug 28 16:42:09 2009 -0400

    Be clear that we're editing RTIR at a Glance
    
    This introduces another translatable string

diff --git a/html/RTIR/Prefs/Home.html b/html/RTIR/Prefs/Home.html
index b6f5217..61f1393 100644
--- a/html/RTIR/Prefs/Home.html
+++ b/html/RTIR/Prefs/Home.html
@@ -5,7 +5,7 @@
 <& /Widgets/SelectionBox:header, nojs => 1 &>
 % foreach my $box( @boxes ) {
 <&|/Widgets/TitleBox,
-    title => loc('RT at a glance') .': '. loc( $box->{Name} ),
+    title => loc('RTIR at a glance') .': '. loc( $box->{Name} ),
     bodyclass => ""
 &>
 <& /Widgets/SelectionBox:show, self => $box, nojs => 1 &>

commit 77e19f4ceb0c81126c180719d521d6b698a29a2a
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Sep 1 16:20:30 2009 -0400

    ignore vim swp files

diff --git a/.gitignore b/.gitignore
index 642007d..19902d6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,3 +3,4 @@ Makefile.old
 MANIFEST.bak
 blib/
 pm_to_blib
+*.swp

commit a4f6711b01cf8fbaf297d9c2c74ec28ad9467a0f
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Sep 1 16:21:50 2009 -0400

    silence an annoying warning

diff --git a/html/RTIR/Elements/AddWatchers b/html/RTIR/Elements/AddWatchers
index 956aece..b6389a5 100644
--- a/html/RTIR/Elements/AddWatchers
+++ b/html/RTIR/Elements/AddWatchers
@@ -39,7 +39,7 @@
 <tr><td><&|/l&>Type</&></td><td><&|/l&>Group</&></td></tr>
 % while ( my $g = $Groups->Next ) {
 <tr><td><& /Elements/SelectWatcherType, Name => "Ticket-AddWatcher-Principal-". $g->PrincipalId, Scope => 'queue' &></td>
-<td><% $g->Name %> (<% $g->Description %>)</td></tr>
+<td><% $g->Name %> (<% $g->Description||'' %>)</td></tr>
 % }
 % }
 

commit eaa53cef6817a0359ae4c2bd1b095af555fe599b
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Sep 1 16:45:59 2009 -0400

    If Constituency isn't valid for the ticket, don't show it in the Edit page

diff --git a/html/RTIR/Edit.html b/html/RTIR/Edit.html
index 74915ac..dbaf935 100644
--- a/html/RTIR/Edit.html
+++ b/html/RTIR/Edit.html
@@ -79,7 +79,7 @@
     <td class="label"><&|/l&>Time Worked</&>:</td>
     <td class="value"><input name="TimeWorked" value="<%$Ticket->TimeWorked|h%>" size="5" /></td>
   </tr>
-% if ( $constituency_propagation ne 'reject' || !$has_parent ) {
+% if ( ($constituency_propagation ne 'reject' || !$has_parent) && $HasConstituency->First ) {
   <tr>
     <td class="labeltop"><&|/l&>Constituency</&>:</td>
     <td class="value">
@@ -166,6 +166,9 @@ if ( $constituency_propagation eq 'reject' ) {
     $has_parent = $tickets->First ? 1 : 0;
 }
 
+my $HasConstituency = $Ticket->CustomFields;
+$HasConstituency->Limit(FIELD => 'Name', VALUE => 'Constituency');
+
 if ( $SaveChanges && !$OnlySearchForPeople ) {
     my $checks_failure = 0;
     my $oldstate = RT::IR::Ticket::FirstCustomFieldValue( $Ticket, 'State' );
diff --git a/html/RTIR/Incident/Edit.html b/html/RTIR/Incident/Edit.html
index 4ad10d9..8c27e0b 100644
--- a/html/RTIR/Incident/Edit.html
+++ b/html/RTIR/Incident/Edit.html
@@ -69,7 +69,7 @@
     <td class="label"><&|/l&>Time Worked</&>:</td>
     <td class="value"><input name="TimeWorked" value="<%$Ticket->TimeWorked|h%>" size="5" /></td>
   </tr>
-% if ( $constituency_propagation ne 'reject' || !$has_children ) {
+% if ( ($constituency_propagation ne 'reject' || !$has_children) && $HasConstituency->First ) {
   <tr>
     <td class="label"><&|/l&>Constituency</&>:</td>
     <td class="value">
@@ -137,6 +137,9 @@ if ( $constituency_propagation eq 'reject' ) {
     $has_children = $tickets->First ? 1 : 0;
 }
 
+my $HasConstituency = $Ticket->CustomFields;
+$HasConstituency->Limit(FIELD => 'Name', VALUE => 'Constituency');
+
 my @results;
 if ( $SaveChanges && !$OnlySearchForPeople ) {
     my $checks_failure = 0;

-----------------------------------------------------------------------