[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-232-g9dc4e7c

[Thomas Sibley]

The branch, 3.9-trunk has been updated
       via  9dc4e7c8b38b22231c50cc15f3d22ade7b14cd31 (commit)
       via  4070b529332c9eb2eb709029873106fae7d84b6d (commit)
      from  38f6a984ded09c54527d05f57db0e17ae4fc1543 (commit)

Summary of changes:
 share/html/NoAuth/css/base/ticket-form.css |    4 ++++
 share/html/Ticket/Elements/EditBasics      |   14 ++++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)

- Log -----------------------------------------------------------------
commit 4070b529332c9eb2eb709029873106fae7d84b6d
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Aug 9 20:33:32 2010 -0400

    Enable specifying defaults for EditBasics, making the default fields more reusable

diff --git a/share/html/NoAuth/css/base/ticket-form.css b/share/html/NoAuth/css/base/ticket-form.css
index f743489..d4ae325 100644
--- a/share/html/NoAuth/css/base/ticket-form.css
+++ b/share/html/NoAuth/css/base/ticket-form.css
@@ -1,3 +1,7 @@
+.ticket-info-basics input[name="Subject"] {
+    width: 20em;
+}
+
 #ticket-create-metadata .cflabel .name,
 #ticket-update-metadata .cflabel .name {
     font-weight: normal;
diff --git a/share/html/Ticket/Elements/EditBasics b/share/html/Ticket/Elements/EditBasics
index 7f38ff4..76a14b3 100755
--- a/share/html/Ticket/Elements/EditBasics
+++ b/share/html/Ticket/Elements/EditBasics
@@ -49,25 +49,27 @@
 $TicketObj => undef
 @fields => ()
 $InTable => 0
+%defaults => ()
 </%ARGS>
 <%INIT>
 unless ( @fields ) {
     @fields = (
         {   name => 'Subject',
-            html => '<input name="Subject" value="'.$m->interp->apply_escapes( $TicketObj->Subject, 'h' ).'" size="50" />',
+            html => '<input name="Subject" value="'.$m->interp->apply_escapes( $defaults{'Subject'} || $TicketObj->Subject, 'h' ).'" />',
         },
         {   name => 'Status',
             comp => '/Elements/SelectStatus',
             args => {
                 Name => 'Status',
                 DefaultLabel => loc("[_1] (Unchanged)",loc($TicketObj->Status)),
+                Default => $defaults{'Status'} || undef,
             },
         },
         {   name => 'Queue',
             comp => '/Elements/SelectQueue',
             args => {
                 Name => 'Queue',
-                Default => $TicketObj->QueueObj->Id,
+                Default => $defaults{'Queue'} || $TicketObj->QueueObj->Id,
                 ShowNullOption => 0,
             }
         },
@@ -77,7 +79,7 @@ unless ( @fields ) {
                 Name => 'Owner',
                 QueueObj => $TicketObj->QueueObj,
                 TicketObj => $TicketObj,
-                Default => $TicketObj->OwnerObj->Id,
+                Default => $defaults{'Owner'} || $TicketObj->OwnerObj->Id,
                 DefaultValue => 0,
             }
         },
@@ -90,7 +92,7 @@ unless ( @fields ) {
                     comp => '/Elements/EditTimeValue',
                     args => {
                         Name => $field,
-                        Default => $TicketObj->$field,
+                        Default => $defaults{$field} || $TicketObj->$field,
                     }
                 }
             } ('Time Estimated', 'Time Worked', 'Time Left')
@@ -104,7 +106,7 @@ unless ( @fields ) {
                     comp => '/Elements/SelectPriority',
                     args => {
                         Name => $field,
-                        Default => $TicketObj->$field,
+                        Default => $defaults{$field} || $TicketObj->$field,
                     }
                 }
             } ('Priority', 'Final Priority')

commit 9dc4e7c8b38b22231c50cc15f3d22ade7b14cd31
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Aug 9 20:34:12 2010 -0400

    Use the field as the class(es) for the table row, similar to ShowBasics

diff --git a/share/html/Ticket/Elements/EditBasics b/share/html/Ticket/Elements/EditBasics
index 76a14b3..59345ea 100755
--- a/share/html/Ticket/Elements/EditBasics
+++ b/share/html/Ticket/Elements/EditBasics
@@ -130,7 +130,7 @@ for my $field (@fields) {
 <table>
 % }
 % for my $field (@fields) {
-  <tr>
+  <tr class="<% lc $field->{'name'} %>">
     <td class="label"><&|/l&><% $field->{'name'} %></&>:</td>
     <td class="value"><% $field->{'html'} |n %></td>
   </tr>

-----------------------------------------------------------------------